Received-SPF: pass (google.com: domain of linux-kernel+bounces-148398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240416085454.3547175-1-dawei.li@shingroup.cn> <20240416085454.3547175-6-dawei.li@shingroup.cn>
In-Reply-To: <20240416085454.3547175-6-dawei.li@shingroup.cn>
From: Anup Patel <anup@brainfault.org>
Date: Wed, 17 Apr 2024 16:52:00 +0530
Message-ID: <CAAhSdy0b8xV9a4=W5TGWM+piizJVWHDFKgLjnxH1UvkjFTbNbw@mail.gmail.com>
Subject: Re: [PATCH v2 5/7] irqchip/riscv-aplic-direct: Avoid explicit cpumask
 allocation on stack
To: Dawei Li <dawei.li@shingroup.cn>
Cc: tglx@linutronix.de, yury.norov@gmail.com, rafael@kernel.org, 
	akpm@linux-foundation.org, maz@kernel.org, florian.fainelli@broadcom.com, 
	chenhuacai@kernel.org, jiaxun.yang@flygoat.com, palmer@dabbelt.com, 
	samuel.holland@sifive.com, linux@rasmusvillemoes.dk, 
	daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 2:26=E2=80=AFPM Dawei Li <dawei.li@shingroup.cn> wr=
ote:
>
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
>
> Use cpumask_first_and_and() to avoid the need for a temporary cpumask on
> the stack.
>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>

LGTM.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
>  drivers/irqchip/irq-riscv-aplic-direct.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/irqchip/irq-riscv-aplic-direct.c b/drivers/irqchip/i=
rq-riscv-aplic-direct.c
> index 06bace9b7497..4a3ffe856d6c 100644
> --- a/drivers/irqchip/irq-riscv-aplic-direct.c
> +++ b/drivers/irqchip/irq-riscv-aplic-direct.c
> @@ -54,15 +54,12 @@ static int aplic_direct_set_affinity(struct irq_data =
*d, const struct cpumask *m
>         struct aplic_direct *direct =3D container_of(priv, struct aplic_d=
irect, priv);
>         struct aplic_idc *idc;
>         unsigned int cpu, val;
> -       struct cpumask amask;
>         void __iomem *target;
>
> -       cpumask_and(&amask, &direct->lmask, mask_val);
> -
>         if (force)
> -               cpu =3D cpumask_first(&amask);
> +               cpu =3D cpumask_first_and(&direct->lmask, mask_val);
>         else
> -               cpu =3D cpumask_any_and(&amask, cpu_online_mask);
> +               cpu =3D cpumask_first_and_and(&direct->lmask, mask_val, c=
pu_online_mask);
>
>         if (cpu >=3D nr_cpu_ids)
>                 return -EINVAL;
> --
> 2.27.0
>