Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp545320lqb; Wed, 17 Apr 2024 04:27:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVUKlBGwXAnQWQ5eeqHzrDBvdQSvDgjFTNaRZQAr7wfuNhvWiVeH5fWGDkiraKlKFWVmomxsHxXRkZKTE1HZo5Fzn6MrYovrHCMbUaIgQ== X-Google-Smtp-Source: AGHT+IEtO8spoV0IOCQUpg28OgQt7L6b4E+cy6aBkNHUyBqduYcrOQe+AuklGrZ5q0zD0zYDknXK X-Received: by 2002:a17:90b:3554:b0:2a7:455d:82db with SMTP id lt20-20020a17090b355400b002a7455d82dbmr12776771pjb.36.1713353257539; Wed, 17 Apr 2024 04:27:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713353257; cv=pass; d=google.com; s=arc-20160816; b=Qbd8YSZOiK3fPxZKaHvfNWlEzF5dL8115fat26b5GBlL/lJlsf4NVWsDsLsUxeJ+UJ ph5tTgCtpL+NVjLymT9WUsv8aPHV6qq514488Ua+aPfwgvoRfPkI76LfP9s+kdoUxAEy g4q44NNIBTQURicnPs4LENX2Q2W4onSfQRuao1NlWucQ/RpAwwKf7mu8Wyyv82xZe87Z J0mkkSosl+/LStUXQ2gvl7wP0DiJtADGYdCm+Z7Ac13kSqReNMyi+D0bYvm2oFNWovjk e2+Vaf9GE5nR3KT30ZCKSn7uP//vpVv7uzfI/c+Oa0j46LQiHUldasPQulRDuOKV4btx IDgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date; bh=7CCDGWbFaGuv/1GZWXNM4ygoZi3LNJrZZ2a5MpHR69g=; fh=Y2hb2xKKhpgnFSJoDH2Y1IzbjLwA5kTdcUCu+DUDwfo=; b=KZpwh/n7aveNqkTi4OnTFM8A5XGpfBzlc5FtioiD8ahVuYKepehqAu71lgsmrR+lTZ r8umQ5P/EgbX3n881S4Ihpd33cZRqfhXR5SozgwUE28Ho2h4HTTWulFPyTL/5mLZhnWT TxNqcWwMagqsw7rQWHfFGDdRx0AnA/f2xoO+oJxdOpwi/3aLmLJ/x8kHGxdT/lpILYWR /rGnsze1ePMLPazfAweaBAhgHvX6RJGKsvetImoLxt2wjEVTrhMSOaafK8spYOq8vNvl tHdi8AxAgyVp1MjcQpqn8FowcZQyklOWEWBywFqSI2rDCd6ofzP3VuPpadLm3yuJoKUK 33rw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=alpha.franken.de); spf=pass (google.com: domain of linux-kernel+bounces-148384-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148384-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id z9-20020a17090ad78900b002aaec2d077esi1088417pju.183.2024.04.17.04.27.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 04:27:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148384-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=alpha.franken.de); spf=pass (google.com: domain of linux-kernel+bounces-148384-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148384-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4D54EB25BF9 for ; Wed, 17 Apr 2024 11:14:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B108513C8FE; Wed, 17 Apr 2024 11:14:27 +0000 (UTC) Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3906313C68A; Wed, 17 Apr 2024 11:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713352467; cv=none; b=Xl9KMYjqiWXVtFeIhBARzIra9E0ufqyXUrco+iiJN+cE7yfymRW2BLmUK7lsZMsVkf96k7seVIQirZwB1ui92SwQv/k8flYk8vzuTZgns7AkVssyvtzw59sco1qR/ZE6lZ/KLiXJYtxdnUqdHRLxGcO2QXHmuRYjh6ah/IDmC5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713352467; c=relaxed/simple; bh=Gl1vItHn+rNA+MEGIq5JA3lS5NZmhUbWAoI2YhYHJTE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VsM5I4ZHhNsK1v42NDj0YK1MqvzDTydIGtOglBEmVZuDPvZ2PAl4oA5SHmvORK2XjSOeuYeWBK/7h6Ig6pt7+M5zqwq1PFBEXaWr52lTMPQAtGxO7hHXF6jce9laWPRtMI3ViiR/o3B/+f+qs0M+2JRGwJ+wPy1MCfEmnGl1lDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1rx3En-0003qh-00; Wed, 17 Apr 2024 13:14:01 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D8324C0168; Wed, 17 Apr 2024 13:13:48 +0200 (CEST) Date: Wed, 17 Apr 2024 13:13:48 +0200 From: Thomas Bogendoerfer To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Yury Norov Subject: Re: [PATCH] MIPS: SGI-IP30: Use bitmap API when iterating over bitmap Message-ID: References: <20240417071830.47703-1-philmd@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240417071830.47703-1-philmd@linaro.org> On Wed, Apr 17, 2024 at 09:18:29AM +0200, Philippe Mathieu-Daud? wrote: > Do not open-code bitmap_set(). Besides, API > allows architecture specific optimizations, so prefer it. > > Use the HEART_NUM_IRQS definition to express the end of the > HEART bitmap. please use HEART_L4_INT_HEART_EXCP + 1, like what the code did before. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]