Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp560179lqb; Wed, 17 Apr 2024 04:59:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVRwqDzKJ1rWxpCmdz9ExIcFx/DpKPrsB/Ff2In7YdvwhJWz1rLI1Sfk/7DDUOtEJfoVO7IEXJf/I3tvf4vMKVsndU683IM9SHpfXTDaA== X-Google-Smtp-Source: AGHT+IHmUddwgmfCxv8GaRg40zQXjdH6uo8XdYNyMDfUyfv4gPkiAfNbQqP4ZxNReGbLYcxCIRZx X-Received: by 2002:ad4:5aa2:0:b0:69b:683b:8686 with SMTP id u2-20020ad45aa2000000b0069b683b8686mr16579138qvg.3.1713355145573; Wed, 17 Apr 2024 04:59:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713355145; cv=pass; d=google.com; s=arc-20160816; b=d1USGsHumuuxF4C8abNKC4sM/7bSqgkLP27P/C93syVQSvp8JfSpULC0ZflvCUSPr9 GZbb79cgIzKGLlIutL/TzAHhlsgY3qzA+zVMABcwUYbJ++xO4Gg0+vOIK4dNjvMjZYzb QLbIvrisq8BcavK5LNhp37pS+KltrgqnoUXEjqRY+FZySmjalLb0KeJ5OJhTV8VTKC8A jPVuVYi5JRI3rgFOe1eSnCU7rWMK3RXjMC7zXXFMwhyw1WWuZwX+uVQR7DJFOtMaTvvH f9skQxY9HmvWqAkIT4EoilXYY+gnd3hBU4u/5aBlmrHXkRZhKL2lcXI22xe3spbdoPFP UzPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=XOPPymOpNWV4lEvf0/qp/BaWhSNyYN4sXc1brxkavt8=; fh=zA9jnyKDduoNv55CrDXGunGYEaEyGE6Am9uKrsjNEwo=; b=uaeSaZhWDiOb56wFU5kbF2cABEVZcb6sQXgKQzk6iiP50xVP2DMjvKghWi8nsHlKM5 myoZs/GxtC9+liONaJpFq3MTHMYxtWgNBL66+C6onaElVmQh+yD27tm/vqh3Q1GtsnFy tgBvoLyrkNiARvjul1KRN4X/zqd0e2jNiMqDuquK7HWBumcd2Devz/7j6XkGaAwDOdua jwIi3ioNlQh3aPpbRpBx9x9l8r8b6Q+e09VKL8xcSEay7r2O+RDTGTTZca3yH71D9ROa 2rPG8l/dsA4VnejoOW3uqW6D3Jb1AnZJqCyj4VqwECanZfQDTysDwROm3fcwZ9vp4pIz hI6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ggQP+mbx; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-148443-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ea20-20020ad458b4000000b0069b5620da91si13062203qvb.164.2024.04.17.04.59.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 04:59:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148443-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ggQP+mbx; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-148443-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DFFFA1C210F5 for ; Wed, 17 Apr 2024 11:59:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A33FB13D244; Wed, 17 Apr 2024 11:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ggQP+mbx" Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB807FBD2 for ; Wed, 17 Apr 2024 11:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713355131; cv=none; b=R4Lu9VzGbvk9jlWN4TvwrdEcgHuWC6dtN6wt41b+NioRt7/Yyqpw17+amLLqGWR50An6ST3OxN4Wgr/1dMhETbeczRmgSdK1SAig2yVADe2c843kRiZHRdmV6bmehgqwlf4QMxmNEGw2oPV5C8oioWJJrdEl4TeQZFY+CEu8uTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713355131; c=relaxed/simple; bh=Z17/MC6Fv2pd536Z3BjzeHPao04MS0TnqDelEF/QRdw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=UOchhSSJd0gieQW3Jyz3S1u2XXAYenPWsvbrt2dT3D/hdrt0eSFQ3Zlm9S/RF3yHhZfbNerOZQlbGiLGIalGOSPBHPyAi6iy0VohL011pBjTKg9VVH/fw8u+MnIeLp0cNUS7nMsUrDanM8Cjetp8iRGCV4Tt+mKpKXuCY9qwzZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ggQP+mbx; arc=none smtp.client-ip=209.85.219.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-dcc73148611so6126025276.3 for ; Wed, 17 Apr 2024 04:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713355129; x=1713959929; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XOPPymOpNWV4lEvf0/qp/BaWhSNyYN4sXc1brxkavt8=; b=ggQP+mbxdG3Ff6vyyhZnj5ajWlGQ2Rw8ejmvuXriReR8IdHW37w0InVZOH5iK0gZlU T9i7qQjl1jMb8cHzKDDE+0p9CFGShV9BFebdq9Jf+FTRCa0L/eHFMnrKysUBzUGOggxJ 5QEavAyZ8O74AZ0InL4kwTZYwsWtmy40XXOmQ/+ujx+ZHDImAwMIRvnNZs0vlc+kMyUP j2Zd8nHrET+3wwIs6RPqzXvqQTYxDgEDxbRYebO4DO90r9iNybhBmZNVsJFeAKiqqdaD rDdIQjbK4nHoTgxveazbdg508+6quCwBVGEaCkiy5NR/C3ksNi1sdAqLZKDkXI1zo/kB MTSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713355129; x=1713959929; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XOPPymOpNWV4lEvf0/qp/BaWhSNyYN4sXc1brxkavt8=; b=mXTbzxPKW5Dl9YMYGRAeo22equW+cXMa0/9qNS7WJquq8thtTYYPzy8WABNWmsHa7E HF2A96lYXy+iAQtoYNDlZUqNStFpc3tx9eEzXTFpfHvAt+0aNN/i+TwV2Y/5P4N/F5pg biqO1msrCFOcC9w7tR9ecFbWB5SfvOgXioLjhH0WbaKb13AEkAN1XTt1CWzRHxgNBmVY lmwiq2JEBRz0SUXCyQPM63+jYfEPutnWcLWxhbLOa/sgHghJPnLhcDMtk8U0me+b9+6n 3N8xtt45QkKyzOT6qR/KZoChneqLvTh22gO+6YiNDnD3ipYeBgYaUWL5JwmN4Yq+WJ4c Egfw== X-Forwarded-Encrypted: i=1; AJvYcCV9io05Ef64aAWH++6Voljv/RNoW+CiXNRYuX4zABuwLgCFk6YwtQZ3GeNVluE40NR0PoFtVJHpCi5owaH+GebUaaFjsZzu8mgYeefP X-Gm-Message-State: AOJu0YxXJbqNR9pPShbQ5APB0y7DfZNN0OYsKUIjVIOqZeU7pLOxSyQB owVKqrYIW8wjLhSlQ7Mwo7jbvuIio+wLBck7ExNv2RMSz0kaDUZ+avgRfheALxhE4YhmUFm4UVr nj/U+WnBW/SXCvvQFmhp+oi2PKT2rRzLKxYQDGQ== X-Received: by 2002:a05:6902:1345:b0:dcd:aee6:fa9 with SMTP id g5-20020a056902134500b00dcdaee60fa9mr15751750ybu.53.1713355129449; Wed, 17 Apr 2024 04:58:49 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-0-78ae3ee9a697@somainline.org> <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-3-78ae3ee9a697@somainline.org> In-Reply-To: <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-3-78ae3ee9a697@somainline.org> From: Dmitry Baryshkov Date: Wed, 17 Apr 2024 14:58:38 +0300 Message-ID: Subject: Re: [PATCH 3/7] drm/msm/dpu: Always flush the slave INTF on the CTL To: Marijn Suijten Cc: Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Archit Taneja , Chandan Uddaraju , Vinod Koul , Sravanthi Kollukuduru , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , Rajesh Yadav , Jeykumar Sankaran , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen Content-Type: text/plain; charset="UTF-8" On Wed, 17 Apr 2024 at 02:57, Marijn Suijten wrote: > > As we can clearly see in a downstream kernel [1], flushing the slave INTF > is skipped /only if/ the PPSPLIT topology is active. > > However, when DPU was originally submitted to mainline PPSPLIT was no > longer part of it (seems to have been ripped out before submission), but > this clause was incorrectly ported from the original SDE driver. Given > that there is no support for PPSPLIT (currently), flushing the slave > INTF should /never/ be skipped (as the `if (ppsplit && !master) goto > skip;` clause downstream never becomes true). > > [1]: https://git.codelinaro.org/clo/la/platform/vendor/opensource/display-drivers/-/blob/display-kernel.lnx.5.4.r1-rel/msm/sde/sde_encoder_phys_cmd.c?ref_type=heads#L1131-1139 > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Marijn Suijten > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry