Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp571473lqb; Wed, 17 Apr 2024 05:14:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWjh12juCYo/HnIbdsiuuNWkccW/yvQ4Tnq7fYRbSkF91ampfGv1ZYP5TG3vz4oDXlVNhIN7OdyyM+Ghx4oD8YDSx9YJ4KiIol7O4H9FA== X-Google-Smtp-Source: AGHT+IH5zHEUjklN3d2ncmCMlAB3EK7bPiJ4FPEagNuKvRbV2MG+LKu8Vv+crcEUB37m2fK0TEu5 X-Received: by 2002:a17:90b:350e:b0:29f:e772:61c3 with SMTP id ls14-20020a17090b350e00b0029fe77261c3mr15168567pjb.27.1713356091650; Wed, 17 Apr 2024 05:14:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713356091; cv=pass; d=google.com; s=arc-20160816; b=TMQ8++j9iFVkHwtN2LYHBeBgKekAv3JCxnLG5HQjPKxfCiVRzq5a5W5yTnMq0GVMS5 yicIydZBOCXIpHWJMoXJL9L1Ns2y6PTFpFvOa+bavxSe9jG82p96oG5VyQnRAKotdPvr Y7tZKCnBTwIjdTSNmTzqXh6s6rxQ/kdx5I8nGsQWbpMPiblzoM/nnpx12EyiHU60jMJc JQO8wK1OW4YPJXFdMoK92frsAf/wRpO/mL8iO+Daqt/Ze5xNBXPq618L4nsBCs7cKaJD 1VbI8HQrWoZmf+6RecG16kRgG2GM8zhTuzhLIIjNK5+YP8FnFShDK9QYDgVeNbHUY0oC /RMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=7V6DnLCsUFkJaBmXGBgPYovHMmnV4qT3enJ4vhqHZQM=; fh=jlCfDayFzZYEQkRpVAMyvIuBTz2skGIgv3HxGJRcnbg=; b=YOPL1Q/dKXdHzJgNnef6N+vvQj147bjg2T3c4Td9rt2d0JONnQUAVfdolI1Asmtxx7 dBWkp6qEm/TZR2YPKcdqTPEoaRjyA6ytD7dirJNl+9e/6QNvOC5njI9YHLPBmDnoZu/m xannFDhuHzrOZaLEiLvBKdlHake9pZaTqpstkTDsVuCswWYR9c3tf1bO+akmB3+nWfZ4 YvhKMURlrB0zlp5bLRit6J0MPJkPXw3/W6CybcZ+ry+Py2ZTkvSJl094J03DB6Ts8koE IyZh+G51yrva8gKDll6n6uHcr2MptOtE2eKgo3M8/ahUOTp/IaVbSF+1q4xl1Ss2O1wt SHgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TdQI+8Lv; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-148440-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148440-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id cl21-20020a17090af69500b002a5a407e79csi1192633pjb.159.2024.04.17.05.14.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 05:14:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148440-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TdQI+8Lv; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-148440-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148440-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id ED4A3B2578D for ; Wed, 17 Apr 2024 11:57:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02A7013CFBC; Wed, 17 Apr 2024 11:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TdQI+8Lv" Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7C07137766 for ; Wed, 17 Apr 2024 11:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713355022; cv=none; b=HAu4YN4y9DtiMWCnT/gc/GZmLE4WMLfqOeIxcBLJGFcREB41/Us12QZJrsPWTDHT9dwpNhDzyyDnX8/AoSnMQpMxpOd0AzeAqXuYt44766XHkRyX3ZE4L7HJIkDsPfKRTC3tvtB+d90Yb2Our5YRC161YtQUfSr2Pt/9gI0vpoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713355022; c=relaxed/simple; bh=rFWYHRR/8wQe0/h8nXEAewAVnKCnbdH3Rt5dV8yzjTw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=NX3GLW+nnfx4OHm7Iu/CempjLe9Pz7pT+7qoDockB5hCe44S5EJdrUgjNADKMyPuuYYERQWwfLfWsDoLf0Pekhd4lKS3i8qc0PlTiJg/SxJ4EnwVRLaR6KwcsOy+NIwGdbrti2bdpvyR02GK+nXz68OgGkvntijQE6cY9/KaOkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TdQI+8Lv; arc=none smtp.client-ip=209.85.219.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-ddda842c399so5714854276.3 for ; Wed, 17 Apr 2024 04:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713355020; x=1713959820; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7V6DnLCsUFkJaBmXGBgPYovHMmnV4qT3enJ4vhqHZQM=; b=TdQI+8LvzmqPZn1yvqFHpPhC2u92d9udMKJM9NfzRHMAzuTe2zp06QyzB3p4zMhrN6 Su1io/EHPQCMCAWqeicjs65L7HFh/Tx42tFPibBJNmNoFoXThVgClvw6y3CUTBa1dl9b PPa/kZKkacwtrVsXSh2t0CroQqeX/L0Dp0+9C4CGpk7NapZOXCS1LVOfx48mm3Xv3ylB ZXv3IFKnlbyMXJOUXH9h7xzoNAbxGlrQusFjbE5kn0Ht4qvkJkhoXQ8EYrMl+Ir9mAsx DCdAcZS447NmJ9J933ex3tLTVRPpWTNEnTVDD7k9oQj56+FkkayAiuf9JEkMAZtqAl4s 5CFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713355020; x=1713959820; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7V6DnLCsUFkJaBmXGBgPYovHMmnV4qT3enJ4vhqHZQM=; b=nqzQdKVZly36vYunsHbq9muwRWCKWtVRCpyLCu/ZWmntvw9tulAe/9zoNjtKQgdD12 u4nRQLpFfV+QWB6ynMJdbIykm/+DxCmcNqQT8kM5W3h2YCZ9jg+DEGaTEiTTA4FE/2VW 6FaHaC3VWn3kkDiEROGkUiyDeqsWFxZMwiVYm4jSDPjOe+TDvQqQp75kctEyP5QjefyQ msSOHFIQWzIe7bzyvy5WVLOdR2D/PafOZKu7ZPYl/LxwNADcVJL1mztur85q0pvvlkRO Jsz1tOVR8q7+kUIZhRX0oMCLzQ+zzCMC6r/2gVF6zZLZ2KBhU/otQ9QSw9Rv0PSd1dfD K68A== X-Forwarded-Encrypted: i=1; AJvYcCVWTzJ0M6rrSh/QcnV8+daK0GjMxfTdA8qSz+jk2XDIT+lheN8LWKkgM/u+EL05BWWI7xjRR6L8yy8/CkIVzX+oJI8Kz/PG6LDpGXLT X-Gm-Message-State: AOJu0YzW3ofZig4BKp11RtfWhFoac1KwSO75qEHwHvdaVW5EyXy0B9fc c+m9S466d+zuFU8sIS69lKHJcEbdoV8TdrA18FRB43oi2qqYGXhnN0rwTAbiASXe5TfsOeSxzjt vgEAsOrsBMrm6GZdT0ca9YG7T/uyYnA7s6X+d1g== X-Received: by 2002:a25:4ec2:0:b0:dcc:1449:71ea with SMTP id c185-20020a254ec2000000b00dcc144971eamr15228037ybb.50.1713355019639; Wed, 17 Apr 2024 04:56:59 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-0-78ae3ee9a697@somainline.org> <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-1-78ae3ee9a697@somainline.org> In-Reply-To: <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-1-78ae3ee9a697@somainline.org> From: Dmitry Baryshkov Date: Wed, 17 Apr 2024 14:56:48 +0300 Message-ID: Subject: Re: [PATCH 1/7] drm/msm/dsi: Print dual-DSI-adjusted pclk instead of original mode pclk To: Marijn Suijten Cc: Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Archit Taneja , Chandan Uddaraju , Vinod Koul , Sravanthi Kollukuduru , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , Rajesh Yadav , Jeykumar Sankaran , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen Content-Type: text/plain; charset="UTF-8" On Wed, 17 Apr 2024 at 02:57, Marijn Suijten wrote: > > When dual-DSI (bonded DSI) was added in commit ed9976a09b48 > ("drm/msm/dsi: adjust dsi timing for dual dsi mode") some DBG() prints > were not updated, leading to print the original mode->clock rather > than the adjusted (typically the mode clock divided by two, though more > recently also adjusted for DSC compression) msm_host->pixel_clk_rate > which is passed to clk_set_rate() just below. Fix that by printing the > actual pixel_clk_rate that is being set. > > Fixes: ed9976a09b48 ("drm/msm/dsi: adjust dsi timing for dual dsi mode") > Signed-off-by: Marijn Suijten > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry