Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp634289lqb; Wed, 17 Apr 2024 06:53:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVLfk4GjI65EBLEh1dtoCckVl0Xqrxm9GmGtNe5LWsHNMna14zJEU2g9TEynncwXHqMeG2cn4+C4Lj8lfmLs3onK82gEdzE25Mnlk/XyQ== X-Google-Smtp-Source: AGHT+IGSsiSmWhdhPq0QlE3fm07//qJ7akRwzceOlft514utNBn9khGd7uTKsxx0zZV+al5jioQH X-Received: by 2002:a17:90a:ea86:b0:2a9:1b6f:36a4 with SMTP id h6-20020a17090aea8600b002a91b6f36a4mr7397688pjz.49.1713362013886; Wed, 17 Apr 2024 06:53:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713362013; cv=pass; d=google.com; s=arc-20160816; b=f5xGfH0N9Y/0Ko51Oe7+J5vAeYIG+1Jbs79/ZCYkLNplSbzocwo77N1jg0kNylDKah g78IKt5VIeidgKZ02qq8TyEM8IsojbeUz9SCcMiB4Fef+zb2fTSkWMyDn/9iT8+6AYON b7EoYAi3dfq0WR8bweGOY2hRqp9VW+d1cis8D2+S7JnMZXSEEcQwq8CS2I2vwm3H1PiC WTZKwD9aZJ7qGOqAtqf3/wtfH55fNcd6f58ll2isfZrXwhp4+nQgy0HePsRXv+9Ngzyu apn1kR3o3zMGZbenxk5CY7Qd5bm2natTaocDUMxrmp3xRwHXU0q6YC6G/rHB5QDPtH1A Tz4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=3cy+aLOQBEMjVG/9jY6YpbDq0/VFwsk91NU4FfipASw=; fh=kd66CHglWFibi2REbWdKa3lOldhY4yXsbicFtcRp4hg=; b=TRuvqZfbWg+O0hE+3aNufn/vxfieNOklRc2jxE0skEkhi5qrcBKBXPjGbJIp3Tus1k yTMUwLEbUt6YUWrqS7g6FT8M5HnBJJEZ8Kc1mmt+tES3jOlHiii6AbBfRF39e/3NQyQ3 2wKt00w3OMWOaLKVzikR1IgNmgMT0P7eOwudPQrHtZ90hcC05eyZhdT50rWZkU8u0Sik +CRlaZgVvHdLOcLd8lVrTBXuxjJFSyi2D2DE3wNNQfnYHHSPS6PxuxOM2YxAspIeLxVQ t2al1GWPrsS7H3MD1Qwrb7wo7Z+4wlaI9vLIGUJza94nPBJ65mBegPZuhaUw9jJahmwb 9Cig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Mykj5nAq; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-148631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id qc12-20020a17090b288c00b002ab69dde334si610051pjb.31.2024.04.17.06.53.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 06:53:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Mykj5nAq; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-148631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5701A28319F for ; Wed, 17 Apr 2024 13:52:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1AD0314037E; Wed, 17 Apr 2024 13:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Mykj5nAq" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04CD413C81F for ; Wed, 17 Apr 2024 13:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713361946; cv=none; b=ZM/N2LUOcAubMN04fzWnpyJVe9RuF6RlCBbw3DdOH1Xt8lc1m15jbwRsFhCbyj527VkVHI5QZ4Ma/UuDaC8BeXqlCJxzbU+Jr1FAhsrYZbbbFhcOr3ZH1y2K7ggYquXlsslgqmS3ZTkSdEDJDvJwEoNLHqsGL3HUzgPd019kk+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713361946; c=relaxed/simple; bh=VxunfktQMOjppOCQpES9K8zlG6woQD+gav0HVLUYdWw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=MdvBFch1gSWTbYrGnjOQMHciihUiCrvTAtX8jNWpZEGJjnqIIjkGtoSaycgbHs/4zg6ZbKqGMXflHI6lWY8V3khk09ibOH5BCyhwA4kPG/Bou3LePEmuG2MVtICK+s+Kspbk3+ZkZdohxOP5+ycAXE0PRRKjMoefmfMQZW2KXTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Mykj5nAq; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713361942; bh=VxunfktQMOjppOCQpES9K8zlG6woQD+gav0HVLUYdWw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Mykj5nAq4uZmDGUy8aeGxuqe1I9F/q86kU0nNQ1xVNXcg8XVae31Bm2y0lTzMLRxz sCbBts3Q1SnTtyf+WFufvN7v6WNYpJwBUoN1k7kZTBFXzQr3V5p5NWX3Od/aVo/z13 dcyJZqtU2prWJkdPjLYZkRNp7EoJzGjc7SHTX5MKlH0rQh2+K9hh1JGB/+PJkfi8iK 58QYY/y1ZXU2KXl29NUD5sHJrhTDD3on7edMTS7rVk+37dU6erHEzcqvjviarUFc6h M0BkSzY5TVdDI0g1canrfGMTmTSWsLkVVnnRDYmVwIiYpaCBC2x2gaSqy9+8cL/6e8 jsIu2PVVQMrHQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7EB49378001E; Wed, 17 Apr 2024 13:52:21 +0000 (UTC) Message-ID: <275e760d-e4e2-4a6b-88f7-9a8590b0773b@collabora.com> Date: Wed, 17 Apr 2024 15:52:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value To: Wojciech Macek , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev References: <20240417103819.990512-1-wmacek@chromium.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240417103819.990512-1-wmacek@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 17/04/24 12:38, Wojciech Macek ha scritto: > In case there is no DP device attached to the port the > transfer function should return IO error, similar to what > other drivers do. > In case EAGAIN is returned then any read from /dev/drm_dp_aux > device ends up in an infinite loop as the upper layers > constantly repeats the transfer request. > > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Signed-off-by: Wojciech Macek Reviewed-by: AngeloGioacchino Del Regno