Received-SPF: pass (google.com: domain of linux-kernel+bounces-148641-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 17 Apr 2024 15:00:01 +0100
From: Gary Guo <gary@garyguo.net>
To: Conor Dooley <conor@kernel.org>
Cc: linux-riscv@lists.infradead.org, Conor Dooley
 <conor.dooley@microchip.com>, Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor
 <alex.gaynor@gmail.com>, Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun
 Feng <boqun.feng@gmail.com>, =?UTF-8?B?QmrDtnJu?= Roy Baron
 <bjorn3_gh@protonmail.com>, Jonathan Corbet <corbet@lwn.net>, Paul Walmsley
 <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Nathan
 Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>,
 rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v3 1/1] RISC-V: enable building 64-bit kernels with rust
 support
Message-ID: <20240417150001.37e48479@eugeo>
In-Reply-To: <20240409-silencer-book-ce1320f06aab@spud>
References: <20240409-unsaddle-skittle-c93eb77732bb@spud>
	<20240409-silencer-book-ce1320f06aab@spud>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?79LdlXS6zVAo1FKEkwI4clqlNbPHDQUi7OfAuxXDXA11QVpG/1bN9tdgq7fA?=
 =?us-ascii?Q?44v9iKJvNIUVAOOu9QdhPaJltrH+FI8K5B9WD3oghscqJ6OYz6qNcdMVg9Xn?=
 =?us-ascii?Q?dPfKmNB3MEJLYsov4ofBL1mxHPgP5m5g9R/PMAy8iInfaW5SvO0DMRGJ6NCn?=
 =?us-ascii?Q?LN7LyQe/AsaNfS8mR3qAvQEt2egoJK8RryIb3E3bn1iyEQJ2H6mvwitW7NhT?=
 =?us-ascii?Q?A39/qcGVQHJIUmRdlyyI3ApmTHZbiae12wfJSn1bXat5u+/5P/fRqqwypF7Z?=
 =?us-ascii?Q?SgxuWw20lehwWtHWZmXtvuImvF595DCQQW+a6147Xfy408pMp534OC6/ihGs?=
 =?us-ascii?Q?wGhuawe8q8sg6yXoeW9+t1+k4CafC8bos6+4S25Knm6+QcFO6aV6PyrZPKFB?=
 =?us-ascii?Q?jBuM1t/7ROWCEcXqKAGe6IAliGXHSSC/ES90K3sXJ4Pt00K0kiFUKzO9qSfW?=
 =?us-ascii?Q?wNIHQ7piZXxYkITyma1GLiremdJ2vTJ0kN858+byzK5TWoXDAKYoqlurin+z?=
 =?us-ascii?Q?wqe9eYq9e2OETjgNjfo9qzCSUUaBedKbzniSgvxn0qlIQBcQ+KJXbB+gKhrg?=
 =?us-ascii?Q?CLMN+67UJYegAgyIXPxYUv1wS/yj4svbSvhKl8bf6FbNYm4JYvi08UNB7SFW?=
 =?us-ascii?Q?Xc1o7x7IgsRjEJIzhTz7bmZurSuXMNOKp8DBqvf2Lm9Sq2eIWXioBEEuQiEL?=
 =?us-ascii?Q?5WGyQwc/KblHLc5nqFkahc4/4utwfllRgzvdNtaR8msUd69Y5hKP2tgDZ386?=
 =?us-ascii?Q?D9KfpfmBg6sO16TRFMx9Mz+WaUlRJDN0348OkneCH/YKD7ziM98cKlB+eWEM?=
 =?us-ascii?Q?JaZLc3zB8VDxoDSAPIwQuiMnih/zkzuj2TmzrpkB6Gi7XTfijPT+1WK1J7vc?=
 =?us-ascii?Q?BN7oShiabDDwV2BPKU02FNQWMUmgHOeon/eFO2yy8OCBIFrwVTsA88kLQwuJ?=
 =?us-ascii?Q?SFstiRTW90nr17i5GlUezwJy+TiUoACt+H2Vy+umyiwrASJ+yZerGTIczoE0?=
 =?us-ascii?Q?sC3oEgqjWyE4IST8haJ9ZlbZCLU1gDEpY2UtrgNOtnhG3nlfyfVA8Q8xW4/9?=
 =?us-ascii?Q?oFs4FWZH9zjEwek9NLGLeGBaY1eISWFxIDieaFEFW6ZlXDyXCwtgtxXh5vwm?=
 =?us-ascii?Q?cdoL7HvSluz82X88yxzwPRuwgcDrejjiwEAuUD7IJGLGYk/+Za1HZLP9bI0h?=
 =?us-ascii?Q?Q9AwDmINxE2u+c2Ed9ue/9+e/eG9xkvOutn8xxML8/UoS4fqvCK6ESdD54gn?=
 =?us-ascii?Q?Q4Si4hAv02WmMyUTGprj4131qomg0Kad+ROJSAA3Mk2K2j8xEAMd8HR2VTnT?=
 =?us-ascii?Q?GlF291zojJ7poOi/Y0FxLFWq9gJAhRIjfVU2oFN7LdtLl7KRe9c9JM6Ab0LO?=
 =?us-ascii?Q?LEaLfmSG8HxeZk/km2xzPaJ9UJEEBSJ5tz5UagbaKCbMJon9KsC5msVfrNWt?=
 =?us-ascii?Q?+VeLla8NOeKUSJtMtVEvRDJgffQ7ye5sKk/lc3OTNMZEfA+7AsSJ3UHySpA2?=
 =?us-ascii?Q?w6F03x6MKHl3SVTkfrpdcDTg9sMqSSQ9U7SlSwfTsShwRM8VKahLsNNViiya?=
 =?us-ascii?Q?637RfUvfXf83pAqs36x+Slo6Hk3FMCgZH2X2L0JG?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cb95bfb-9829-49bd-4b84-08dc5ee6aeb3
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 14:00:04.7674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NhYt1pFBHz2tK1NL95wZhgtVC8Z/2q9NWLligH6U/v0FdACGrr4/cb0hSGbdKwBLgcTs1+NEPMhbJ0yrr2ND/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB5426

On Tue,  9 Apr 2024 18:25:16 +0100
Conor Dooley <conor@kernel.org> wrote:

> From: Miguel Ojeda <ojeda@kernel.org>
> 
> The rust modules work on 64-bit RISC-V, with no twiddling required.
> Select HAVE_RUST and provide the required flags to kbuild so that the
> modules can be used. The Makefile and Kconfig changes are lifted from
> work done by Miguel in the Rust-for-Linux tree, hence his authorship.
> Following the rabbit hole, the Makefile changes originated in a script,
> created based on config files originally added by Gary, hence his
> co-authorship.

Thanks for sending the patch!

> 32-bit is broken in core rust code, so support is limited to 64-bit:
> ld.lld: error: undefined symbol: __udivdi3

I wouldn't call the core rust code broken :)

The missing symbol here should be easily stubbed by changing the
redirect-intrinsics in rust/Makefile and adding a stub in
compiler_builtins.rs. Although we probably instead of panicking, want
to redirect the division to kernel division routine (IIRC the division
is used for formatting integers, which is a legit use of division).

> 
> As 64-bit RISC-V is now supported, add it to the arch support table.
> 
> Co-developed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> Co-developed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  Documentation/rust/arch-support.rst | 1 +
>  arch/riscv/Kconfig                  | 1 +
>  arch/riscv/Makefile                 | 7 +++++++
>  scripts/generate_rust_target.rs     | 6 ++++++
>  4 files changed, 15 insertions(+)