Received-SPF: pass (google.com: domain of linux-kernel+bounces-148629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b5ecdc56-11c6-47b0-9cc1-87d384b01d0f@amd.com>
Date: Wed, 17 Apr 2024 09:50:58 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
 Avadhut.Naik@amd.com, John.Allen@amd.com
Subject: Re: [PATCH v2 01/16] x86/mce: Define mce_setup() helpers for common
 and per-CPU fields
To: Borislav Petkov <bp@alien8.de>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-2-yazen.ghannam@amd.com>
 <20240416100206.GEZh5MnlDJMeaERfQ5@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240416100206.GEZh5MnlDJMeaERfQ5@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WGhmZ29OcmYzakMxeTh0YzMxMHpKR2cvc2hPQXYzaktZaElnTWgzZ2grZE91?=
 =?utf-8?B?TFZtaGU2V3poWjJPcFR1QkpjMytsWUVpUDFEQWF1YzB4ZlpzVEdVR0VtT2VY?=
 =?utf-8?B?SWdKMzEwQkhGKzFXSXdVT3FJL200cmg5TDA4YXZ2Qng4bmtHbnFYOWV3bllz?=
 =?utf-8?B?ZHFwcWlWUExQOS8xcGZXdTdUWlhGK2ZKS1NiTUw4d1dZeG5lL3FmSHJ5M1Br?=
 =?utf-8?B?ZEVpbUoyZUI1bWN0YzFvZzF1YjdHcy9kT0R1bTlLd3VGRkhGWjNPTmw3aU9N?=
 =?utf-8?B?RFFmYWdBZVZTTm9nNXdPbVNDSm9jazROeUNFUUFydFc2dU01Sy9VaG1TMkJV?=
 =?utf-8?B?MTNlbTR6WGgzTjdZN0ZlZWFtU0cvdkgveHhoTnA0Um9ydEVkU1plOXJ4U3Fl?=
 =?utf-8?B?MzM3S1VnRjQ4ZzdSWWVHcGlzNFVEc09HZERkanRqS010N0luRUxLSGYvRDl6?=
 =?utf-8?B?dzZrVnhRM2FjK2hYUUcxek1MRmZ2UjB0WHFEd3ZKYzArVzQzTU5hcVB1dzN0?=
 =?utf-8?B?WWs3N3RWTWJOd0htelZLcUFOdVc4dHVPRkViZ3AvTS8vQzdQWmZablFWbUdj?=
 =?utf-8?B?RzZGY1F4VFFDV2F2TndGTDlza1ZwVmZ5Y2ZjdDlGbXl1azRXVkdlc1VLQldk?=
 =?utf-8?B?MGxPOFN2eVZQaGdNTDZ2YnB1eXlzUFczZ2xwZDk2VnBrcEpwNkpDdzlGbkFF?=
 =?utf-8?B?ZEFONEU4YUtFZnMyTkJVWDVsSDNmV0dwL1QxUG1McjJoU1lrekF0aXI4L0hi?=
 =?utf-8?B?Smp2UTV3SVRBNmFvRTM1djJoNGRTNG1Cdlp2T3dUTDFHQUU5VVVDenR2emJv?=
 =?utf-8?B?bGdrS2NRclE0VXdkL2UxZXdrd1JQSkdoc2V5aE5NdFhtT0ZUWWNTQVNJVUxB?=
 =?utf-8?B?N3ZlWDhPcWRSZU50NUsxdW5jU1hLUnI4dmVqRFZDV2hzbE1HcW1RNktkYitk?=
 =?utf-8?B?L1pzUndBZjBBNWFBSmJqZnZGZnVrK0kzaHVyNjRwWE04NHhDTUZTSUhFOGow?=
 =?utf-8?B?cm1Lc3lPZDZJNEhEV1hTZS8rNXhlWkN5YUszbFdLRktnaktadmY4d2t5ZXBq?=
 =?utf-8?B?UTUySTU4WEtWTlNZOWxpQzE5UWlDai84ZU42dmI2M1ZZN3BwVlhlSFFabnJY?=
 =?utf-8?B?NzhTWTFuRGRKYzBIeW1wZmtQT2djUkhlZ3dwQksvY0VhdkM5TlhTOWpySkJK?=
 =?utf-8?B?V011clZCV0xGNzBGQU5IZGFFdjJQK2xMb3hPTTMwWWtMWUIySGJTK2hIb3B2?=
 =?utf-8?B?c2RpeWFFUFkvSzR4K09Va0tVNFJOcTVZQityZWJseUpmdTUzWkdlbE1CcmdD?=
 =?utf-8?B?K2R0YUhjai9FV01lKzRFTlV3N1A1Y3JlUlIxUFhCVTRSL1RJUFJFS1djbFg1?=
 =?utf-8?B?SE53ZkJ1QktiOWZwWEFGNCtZM085Y21tbjZpQ0FPditoSjYyczRFMTlab25Q?=
 =?utf-8?B?Mm9rNG5ncC92RVJFQ2YyZk5WMGhRajB2QzRLMWNGSUVkYlBmbFMwWXJSZkQ0?=
 =?utf-8?B?R01kTGZ6L05Wd2tscXpnTlEzMDkweXE5UHorTTRxQmh5K1dkTjA3WjQ1dllX?=
 =?utf-8?B?dW1HV1BqWmV6c0lNQ3l6VXowQ1d1ak9NVkpTNHBRUFA3M2xUakZjTFBHajUr?=
 =?utf-8?B?TXZVZkFsV3hadjNKTHdMbHRkVzFLMTM5Unl0cldRcHRhMHpneDRuTUZRbWh5?=
 =?utf-8?B?dDVUVHZHbnRSLytJdHY2N3NFL2RJa1lmdmgvTml0dlRlRkZVTTkxQlYxTXBG?=
 =?utf-8?B?NW5UU1ptMk1waXUzVmdkOHNVMW9mZ0d5VVM1OFlBK1NOQ29BYW5BbFJTV3NQ?=
 =?utf-8?B?UURQSWVaaGh1c1hnN3l3UDZvVnlXcUcrYW0yd0N5UHlpSjQzb0hmcmpVTlVY?=
 =?utf-8?B?cW5YTTd6TFNERVNFa2pvN3lGb1BNZFlYSG4wdGVabXFQUjNBTkRGMWU1Q1g2?=
 =?utf-8?B?ZTMrQzlrRUR0bVQwZTg2MFRBK0pnM0t4YW1hT3FWQzJhMElmeW9vS0NNYTJC?=
 =?utf-8?B?US83c0hIY2wwVXd3VGVtZktnVmRZTnhwOU1OS3phVTQ5UmN5dkk2QS9ieVlp?=
 =?utf-8?B?QVE4d2FORnRpVURSWXIyMGppNEFVVTdDajlVYnVlVTRaUlF4WEhHMHN6WGZT?=
 =?utf-8?Q?siLHuZ+Lc/nXwwINtr0qZQNP1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 028127bb-e47e-4de4-36a5-08dc5ee56a96
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 13:51:00.9705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HMLllcVr1dA0UD+VfyF2z+IO5sxOpG6XG2Czut6EpTRShU4CQofTzImN0almyoi2dD1IjrWQHEr850DVQg80tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6041


On 4/16/24 06:02, Borislav Petkov wrote:
> On Thu, Apr 04, 2024 at 10:13:44AM -0500, Yazen Ghannam wrote:
>> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
>> index b5cc557cfc37..7a857b33f515 100644
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> @@ -117,20 +117,32 @@ static struct irq_work mce_irq_work;
>>    */
>>   BLOCKING_NOTIFIER_HEAD(x86_mce_decoder_chain);
>>   
>> -/* Do initial initialization of a struct mce */
>> -void mce_setup(struct mce *m)
>> +void mce_setup_common(struct mce *m)
> 
> Since we're touching this...
> 
> mce_setup() is a perfectly wrong name for what it does. So let's clean
> it up. Diff ontop below.
> 
> * mce_prep_record() - the name says what the function does.
> 
> * mce_prep_record_per_cpu() - "per_cpu" as this is a common kernel
> concept and we do use per_cpu data in there.
> 
> Please do this in two patches:
> 
> - the first one renames mce_setup() only without adding the additional
>    functionality
> 
> - the second one does the split
> 
> Thx.
>

Okay, will do.

Should I send another revision of this entire set? Or should I split out
the mce_setup() patches?

Thanks,
Yazen