Received-SPF: pass (google.com: domain of linux-kernel+bounces-148618-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Geethasowjanya Akula <gakula@marvell.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
        "oe-kbuild@lists.linux.dev"
	<oe-kbuild@lists.linux.dev>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "lkp@intel.com" <lkp@intel.com>,
        "oe-kbuild-all@lists.linux.dev"
	<oe-kbuild-all@lists.linux.dev>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com"
	<pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil
 Kovvuri Goutham <sgoutham@marvell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH 2/9] octeontx2-pf: RVU representor
 driver
Thread-Topic: [EXTERNAL] Re: [net-next PATCH 2/9] octeontx2-pf: RVU
 representor driver
Thread-Index: AQHaj7vZFA2SON2HBESfh0LFpSC0crFseXAAgAABokA=
Date: Wed, 17 Apr 2024 13:45:27 +0000
Message-ID: 
 <CH0PR18MB43390E834F5AA7E8911B1AF7CD0F2@CH0PR18MB4339.namprd18.prod.outlook.com>
References: <20240416050616.6056-3-gakula@marvell.com>
 <546b7783-78ec-4fec-b338-f1980a5871d0@moroto.mountain>
In-Reply-To: <546b7783-78ec-4fec-b338-f1980a5871d0@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?q7+vXWXqauLWUU5W/1MS+z2vZvKpTj4B/557qQ9+o+qTMt5Qeu4uWVtjrMbN?=
 =?us-ascii?Q?VbjBmbB3W61dPFJTmsQfOTvwOLlIDsh3QkmKmKW4NVaNnu2jzj8U27B/g6Yy?=
 =?us-ascii?Q?8jksFf6PIkYCqEnFnYwp/DnhaB3Vu/ljU61taw0H1yJavvm79CZuTa+D8ILl?=
 =?us-ascii?Q?SNNlmzqAaO2bMdUI0RM91NvjWCHdMbjWF0gSeyLwQCfRa6pycuuiUmj6iKoL?=
 =?us-ascii?Q?NyzN1kKlho7DYm1v5uDFCkUPIit+t9XYtbblqb5xa7poTMkg28vn12l7o9ns?=
 =?us-ascii?Q?AP/JJE27pJIkRgK6D0NhZT+dhyaAQUf26Q15Cr1MXyfHSs31yaGrT6XLu8s6?=
 =?us-ascii?Q?jcJEnzoEsmWjMX4fVfn5cJGXMGGqoJuzZy4Kt3wQu6WSZt7kcj4o/Orp54L5?=
 =?us-ascii?Q?NCTryTZoSwTrtkTVZ2uO/m8dam/mJkvnn9Pv5zUOeq99z6YCeAOkW0wGW9f+?=
 =?us-ascii?Q?ujUZGva2P3DO0eTwEzXqBOy1pHjhRWVfZzEQCzsDHNJZxG/W/nfJEi+dqx2M?=
 =?us-ascii?Q?5LVjEkQINePIV9y5ULxMzqYGzrDQzMXziVsu+06HFw3Z+uTEvf60c1IngLds?=
 =?us-ascii?Q?0FRDqEEqRsGFWMHW1cWnmsh3yAn+Eh+ezecwBLNbrOB3JHu4VNmfq5PWupp1?=
 =?us-ascii?Q?LA0pIKDzTOTAaE8L2t+ZWPMCv9HFfjFnfFeRUdGt6gnGj/JBkUQIq42kbSxw?=
 =?us-ascii?Q?H1b+ddOGqbwgO6wpMx4OYVj7QYBfAdrtV31V/6BcidldOKPa0lCRR0Ofwl7M?=
 =?us-ascii?Q?YaxY9Sl24q4vuh+covwsRJr69urCij4+iTUUe8TNQL5aCEFBG4PJhhzsnGiE?=
 =?us-ascii?Q?CMArShYeAAD0Ia3DkysO45XVFEFhdBgizc87uZqI9LbGwwDz5X/BJL/soxvC?=
 =?us-ascii?Q?jX/3x8nuj6B4Ym1ZebD+yVH3rguwoyJaB+cbe6KsyOBdjlLJTLYe+UTNfIZ8?=
 =?us-ascii?Q?zPLoTVnu6KHeOe27ejAHUzVa6C0n0FgQnQLSKwDZ6IpDm/0mPz6vBXKoSp8q?=
 =?us-ascii?Q?i+q5PzDvA83CR24M+5py+iq2djcVCk2Gi6EOB33SoQI4o+8Q8pzG71TiM6gv?=
 =?us-ascii?Q?7QXs8PDfGwHdNOoEfkUVqUysALyUUsIsuDYmH8HLEM2bVYCWo6ms0nqSfbYK?=
 =?us-ascii?Q?gR3HDvQzhHhrGeqnByAcooDgYGq5uM9K2fAPYC0ebeqKQCc1mW9KPAsaAoYI?=
 =?us-ascii?Q?/Izv4bClBg5X5dBBn/29deHBqVOA+PlYi484YX8pyWIbdYN2/BgMwVvobXSJ?=
 =?us-ascii?Q?TY5Q3bUtVJ5cuUhw/7kbhJpjpk0fkAMDro2r5H/HHQEre75O11/yXqT8XIRJ?=
 =?us-ascii?Q?6edTZ5TbuiNuBkTGEfUR97G6gHl3K5t0n4XwSVvHkLHmiczRadLFxZeZtLmC?=
 =?us-ascii?Q?Hc49QkAXtIsaqApD8S0ALgehpkggRc8LIMteLFcYrB5HAgvJ54e3l4cpPtRo?=
 =?us-ascii?Q?ACTv7ceSC1gexxIqUmQZmzoJptXhDKFXT+rhC6e7k2milRK4uem3q+LMeRna?=
 =?us-ascii?Q?VRTioCH6Vi2C/1wTTIM6qR3p+WnYpDJmqYq7OWXoazOgc67iYs1kR1dFxANq?=
 =?us-ascii?Q?cW56Igx7QLb4Ge5zifw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR18MB4339.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b7a6820-0710-430b-385e-08dc5ee4a42c
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2024 13:45:27.9069
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6KtcaWIt631bhSThhRQH/rRT7OExbMkFiiOJPEolFqMHG/RH29bbIOkQ2PgK496XXMmfXTxI9A138kg4qYIfFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4515
X-Proofpoint-GUID: CiXD4JTecNQZxKiz8Ya6Un373bOnKnxr
X-Proofpoint-ORIG-GUID: CiXD4JTecNQZxKiz8Ya6Un373bOnKnxr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-17_11,2024-04-16_01,2023-05-22_02


> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: Wednesday, April 17, 2024 7:08 PM
> To: oe-kbuild@lists.linux.dev; Geethasowjanya Akula <gakula@marvell.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: lkp@intel.com; oe-kbuild-all@lists.linux.dev; kuba@kernel.org;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
> Hariprasad Kelam <hkelam@marvell.com>
> Subject: [EXTERNAL] Re: [net-next PATCH 2/9] octeontx2-pf: RVU represento=
r
> driver
>=20
> Prioritize security for external emails: Confirm sender and content safet=
y
> before clicking links or opening attachments
>=20
> ----------------------------------------------------------------------
> Hi Geetha,
>=20
> kernel test robot noticed the following build warnings:
Sorry for the noise. Will submit v2.=20
>=20
> url:    https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__github.com_intel-2Dlab-2Dlkp_linux_commits_Geetha-
> 2Dsowjanya_octeontx2-2Dpf-2DRefactoring-2DRVU-2Ddriver_20240416-
> 2D131052&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DUiEt_nUeYFctu7JVLX
> VlXDhTmq_EAfooaZEYInfGuEQ&m=3Dpcjq_-
> V9lD5zAfvLDvrlTSM6DYTEg3uJVXYiddlZa89uqDZsmg4dN-
> MbQRGQK6ji&s=3DChDNOMytP7EFyLLxwRY3cHm7DMPhPlK3Wv2IEhbgJ6g&e=3D
> base:   net-next/main
> patch link:    https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__lore.kernel.org_r_20240416050616.6056-2D3-2Dgakula-
> 2540marvell.com&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DUiEt_nUeYFct
> u7JVLXVlXDhTmq_EAfooaZEYInfGuEQ&m=3Dpcjq_-
> V9lD5zAfvLDvrlTSM6DYTEg3uJVXYiddlZa89uqDZsmg4dN-
> MbQRGQK6ji&s=3DYSpWxF94IMzRZMCAUDJtHTF24ZOUEQndVX3_OEwQeT4&e=3D
> patch subject: [net-next PATCH 2/9] octeontx2-pf: RVU representor driver
> config: alpha-randconfig-r081-20240417
> (https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__download.01.org_0day-
> 2Dci_archive_20240417_202404172056.MpOMwcGB-2Dlkp-
> 40intel.com_config&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DUiEt_nUeYF
> ctu7JVLXVlXDhTmq_EAfooaZEYInfGuEQ&m=3Dpcjq_-
> V9lD5zAfvLDvrlTSM6DYTEg3uJVXYiddlZa89uqDZsmg4dN-
> MbQRGQK6ji&s=3DQOW0AEuofAe4zzEOmhoLGIMNdsEeECwaFcWF59IbfGs&e=3D
> )
> compiler: alpha-linux-gcc (GCC) 13.2.0
>=20
> If you fix the issue in a separate patch/commit (i.e. not just a new vers=
ion of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes:
> | https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__lore.kernel.org_=
r
> | _202404172056.MpOMwcGB-2Dlkp-
> 40intel.com_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz
> | 7xtfQ&r=3DUiEt_nUeYFctu7JVLXVlXDhTmq_EAfooaZEYInfGuEQ&m=3Dpcjq_-
> V9lD5zAfvL
> | DvrlTSM6DYTEg3uJVXYiddlZa89uqDZsmg4dN-
> MbQRGQK6ji&s=3DjPDXgsvu9jd0deKZBs1
> | uke91fxvHYp_S6gFl1gnq5Rk&e=3D
>=20
> New smatch warnings:
> drivers/net/ethernet/marvell/octeontx2/nic/rep.c:95 rvu_get_rep_cnt() war=
n:
> passing zero to 'PTR_ERR'
> drivers/net/ethernet/marvell/octeontx2/nic/rep.c:140 rvu_rep_probe() warn=
:
> missing unwind goto?
>=20
> vim +/PTR_ERR +95 drivers/net/ethernet/marvell/octeontx2/nic/rep.c
>=20
> 1e15129a77b419 Geetha sowjanya 2024-04-16   76  static int
> rvu_get_rep_cnt(struct otx2_nic *priv)
> 1e15129a77b419 Geetha sowjanya 2024-04-16   77  {
> 1e15129a77b419 Geetha sowjanya 2024-04-16   78  	struct
> get_rep_cnt_rsp *rsp;
> 1e15129a77b419 Geetha sowjanya 2024-04-16   79  	struct mbox_msghdr
> *msghdr;
> 1e15129a77b419 Geetha sowjanya 2024-04-16   80  	struct msg_req *req;
> 1e15129a77b419 Geetha sowjanya 2024-04-16   81  	int err, rep;
> 1e15129a77b419 Geetha sowjanya 2024-04-16   82
> 1e15129a77b419 Geetha sowjanya 2024-04-16   83  	mutex_lock(&priv-
> >mbox.lock);
> 1e15129a77b419 Geetha sowjanya 2024-04-16   84  	req =3D
> otx2_mbox_alloc_msg_get_rep_cnt(&priv->mbox);
> 1e15129a77b419 Geetha sowjanya 2024-04-16   85  	if (!req) {
> 1e15129a77b419 Geetha sowjanya 2024-04-16   86
> 	mutex_unlock(&priv->mbox.lock);
> 1e15129a77b419 Geetha sowjanya 2024-04-16   87  		return -
> ENOMEM;
> 1e15129a77b419 Geetha sowjanya 2024-04-16   88  	}
> 1e15129a77b419 Geetha sowjanya 2024-04-16   89  	err =3D
> otx2_sync_mbox_msg(&priv->mbox);
> 1e15129a77b419 Geetha sowjanya 2024-04-16   90  	if (err)
> 1e15129a77b419 Geetha sowjanya 2024-04-16   91  		goto exit;
> 1e15129a77b419 Geetha sowjanya 2024-04-16   92
> 1e15129a77b419 Geetha sowjanya 2024-04-16   93  	msghdr =3D
> otx2_mbox_get_rsp(&priv->mbox.mbox, 0, &req->hdr);
> 1e15129a77b419 Geetha sowjanya 2024-04-16   94  	if (IS_ERR(msghdr)) {
> 1e15129a77b419 Geetha sowjanya 2024-04-16  @95  		err =3D
> PTR_ERR(rsp);
>                                                                          =
     ^^^ s/rsp/msghdr/
>=20
> 1e15129a77b419 Geetha sowjanya 2024-04-16   96  		goto exit;
> 1e15129a77b419 Geetha sowjanya 2024-04-16   97  	}
> 1e15129a77b419 Geetha sowjanya 2024-04-16   98
> 1e15129a77b419 Geetha sowjanya 2024-04-16   99  	rsp =3D (struct
> get_rep_cnt_rsp *)msghdr;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  100  	priv->hw.tx_queues =3D
> rsp->rep_cnt;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  101  	priv->hw.rx_queues =3D
> rsp->rep_cnt;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  102  	priv->rep_cnt =3D rsp-
> >rep_cnt;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  103  	for (rep =3D 0; rep <
> priv->rep_cnt; rep++)
> 1e15129a77b419 Geetha sowjanya 2024-04-16  104  		priv-
> >rep_pf_map[rep] =3D rsp->rep_pf_map[rep];
> 1e15129a77b419 Geetha sowjanya 2024-04-16  105
> 1e15129a77b419 Geetha sowjanya 2024-04-16  106  exit:
> 1e15129a77b419 Geetha sowjanya 2024-04-16  107  	mutex_unlock(&priv-
> >mbox.lock);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  108  	return err;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  109  }
> 1e15129a77b419 Geetha sowjanya 2024-04-16  110
> 1e15129a77b419 Geetha sowjanya 2024-04-16  111  static int
> rvu_rep_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> 1e15129a77b419 Geetha sowjanya 2024-04-16  112  {
> 1e15129a77b419 Geetha sowjanya 2024-04-16  113  	struct device *dev =3D
> &pdev->dev;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  114  	struct otx2_nic *priv;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  115  	struct otx2_hw *hw;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  116  	int err;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  117
> 1e15129a77b419 Geetha sowjanya 2024-04-16  118  	err =3D
> pcim_enable_device(pdev);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  119  	if (err) {
> 1e15129a77b419 Geetha sowjanya 2024-04-16  120  		dev_err(dev,
> "Failed to enable PCI device\n");
> 1e15129a77b419 Geetha sowjanya 2024-04-16  121  		return err;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  122  	}
> 1e15129a77b419 Geetha sowjanya 2024-04-16  123
> 1e15129a77b419 Geetha sowjanya 2024-04-16  124  	err =3D
> pci_request_regions(pdev, DRV_NAME);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  125  	if (err) {
> 1e15129a77b419 Geetha sowjanya 2024-04-16  126  		dev_err(dev,
> "PCI request regions failed 0x%x\n", err);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  127  		return err;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  128  	}
> 1e15129a77b419 Geetha sowjanya 2024-04-16  129
> 1e15129a77b419 Geetha sowjanya 2024-04-16  130  	err =3D
> dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48));
> 1e15129a77b419 Geetha sowjanya 2024-04-16  131  	if (err) {
> 1e15129a77b419 Geetha sowjanya 2024-04-16  132  		dev_err(dev,
> "DMA mask config failed, abort\n");
> 1e15129a77b419 Geetha sowjanya 2024-04-16  133  		goto
> err_release_regions;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  134  	}
> 1e15129a77b419 Geetha sowjanya 2024-04-16  135
> 1e15129a77b419 Geetha sowjanya 2024-04-16  136
> 	pci_set_master(pdev);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  137
> 1e15129a77b419 Geetha sowjanya 2024-04-16  138  	priv =3D
> devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  139  	if (!priv)
> 1e15129a77b419 Geetha sowjanya 2024-04-16 @140  		return -
> ENOMEM;
>=20
> goto err_release_regions.
>=20
> 1e15129a77b419 Geetha sowjanya 2024-04-16  141  	pci_set_drvdata(pdev,
> priv);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  142  	priv->pdev =3D pdev;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  143  	priv->dev =3D dev;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  144  	priv->flags |=3D
> OTX2_FLAG_INTF_DOWN;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  145  	priv->flags |=3D
> OTX2_FLAG_REP_MODE_ENABLED;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  146
> 1e15129a77b419 Geetha sowjanya 2024-04-16  147  	hw =3D &priv->hw;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  148  	hw->pdev =3D pdev;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  149  	hw->max_queues =3D
> OTX2_MAX_CQ_CNT;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  150  	hw->rbuf_len =3D
> OTX2_DEFAULT_RBUF_LEN;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  151  	hw->xqe_size =3D 128;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  152
> 1e15129a77b419 Geetha sowjanya 2024-04-16  153  	err =3D
> otx2_init_rsrc(pdev, priv);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  154  	if (err)
> 1e15129a77b419 Geetha sowjanya 2024-04-16  155  		goto
> err_release_regions;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  156
> 1e15129a77b419 Geetha sowjanya 2024-04-16  157  	err =3D
> rvu_get_rep_cnt(priv);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  158  	if (err)
> 1e15129a77b419 Geetha sowjanya 2024-04-16  159  		goto
> err_detach_rsrc;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  160
> 1e15129a77b419 Geetha sowjanya 2024-04-16  161  	err =3D
> rvu_rep_rsrc_init(priv);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  162  	if (err)
> 1e15129a77b419 Geetha sowjanya 2024-04-16  163  		goto
> err_detach_rsrc;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  164
> 1e15129a77b419 Geetha sowjanya 2024-04-16  165  	return 0;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  166
> 1e15129a77b419 Geetha sowjanya 2024-04-16  167  err_detach_rsrc:
> 1e15129a77b419 Geetha sowjanya 2024-04-16  168  	if (priv->hw.lmt_info)
> 1e15129a77b419 Geetha sowjanya 2024-04-16  169
> 	free_percpu(priv->hw.lmt_info);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  170  	if
> (test_bit(CN10K_LMTST, &priv->hw.cap_flag))
> 1e15129a77b419 Geetha sowjanya 2024-04-16  171
> 	qmem_free(priv->dev, priv->dync_lmt);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  172
> 	otx2_detach_resources(&priv->mbox);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  173
> 	otx2_disable_mbox_intr(priv);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  174
> 	otx2_pfaf_mbox_destroy(priv);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  175
> 	pci_free_irq_vectors(pdev);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  176  err_release_regions:
> 1e15129a77b419 Geetha sowjanya 2024-04-16  177  	pci_set_drvdata(pdev,
> NULL);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  178
> 	pci_release_regions(pdev);
> 1e15129a77b419 Geetha sowjanya 2024-04-16  179  	return err;
> 1e15129a77b419 Geetha sowjanya 2024-04-16  180  }
>=20
> --
> 0-DAY CI Kernel Test Service
> https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__github.com_intel_l=
kp-
> 2Dtests_wiki&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DUiEt_nUeYFctu7JV
> LXVlXDhTmq_EAfooaZEYInfGuEQ&m=3Dpcjq_-
> V9lD5zAfvLDvrlTSM6DYTEg3uJVXYiddlZa89uqDZsmg4dN-
> MbQRGQK6ji&s=3DbeFB4KCroPb-eEJRShM4cz1uR-BfmmzYTAhp7-xEqqc&e=3D