Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp655009lqb; Wed, 17 Apr 2024 07:19:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV2MztfKhSy/9bQBSTwPFgpVEvjr9LGqxm0PaZcSTXTI1AQJptlSLukDXwpQnnuIeQ7y4dpYAKW1s6W571XzUPjKCbl52UOMrR4d/QJrg== X-Google-Smtp-Source: AGHT+IGYn8FU9ig/GdHWixAPs0Mho9mVxsrnpoeAeXhxiUuYaRSekxcUuVkgA9ePhhhHdIPcVWPT X-Received: by 2002:a17:902:d38d:b0:1e4:6253:75db with SMTP id e13-20020a170902d38d00b001e4625375dbmr13312918pld.17.1713363544652; Wed, 17 Apr 2024 07:19:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713363544; cv=pass; d=google.com; s=arc-20160816; b=gBiU4aZTgBOpeMCN9sHyc0cNOQ+VUYL4GrDyCAz9WALLwhA/LbAXwLP/+QKQaRd8+/ pAUCTrSBvJ9hTM5G0Hz+nnmMvc56BlnWF4WSBnXKdr/WLJ28bHIJgJN2IhfzjnE9jGp6 RtO370hyuee79e8koJ2PlWuAWb54+ZHaxNk73Ca1iHHepije3i3HASkFJGvENNvvwP0Y PJdBF6IvLY5gGzFTJIkbAMBm6qHSV8C8AyvFkLXYgBnkdGLIJxxp8nRw9J+BoK/RCtp+ AGYmPSeqaqq5QQmnK+xTDiCcrGOrfEadzYioiKaZoOTbRk403WosQriJFHV2C9qkyshe I8lQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:date:references:in-reply-to:subject:cc:to :from:dkim-signature; bh=fUYDgK3JFqhWfl1oU8rfuz06ImISe6EFIa+Ljdw6iLA=; fh=sUIUDSRLPnoDTcyC+NG/apWxqpmg9gT5rxu7A6nGf6U=; b=wnMNcuo1R47ziPXR59PVbgiO3fXVKSuE2NtZ1cVhpFau8cs+9My/NfIZvAFe7/7FJ7 PMqJIDzzBPjdaUgSeRKo9suTKTE2noIep62QGHSv7GQiQQBeKamnZgQK06x9TKpw/Ohp 3k2qKyiCpQl37uzPqm9lMwetbBU2lf/+rmxJ/4Y/G+b6eQBK7OR/OFmMhj5tp2el3nY5 m/jfgmeeMC1L/20Jh1NX1LD1xe0SUIYE+LEBvPVi8XDdRgaCZAq+hTSjuE94BB/5hC88 lGff9S7uMwv43BPcAaSNPhcPFlQXAuYR2VV3J1tUc37EKHrsbYcBDiULD/Lu9PeTc8s3 t55g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fUGdD89K; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-148666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148666-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e11-20020a170903240b00b001e414040567si11630095plo.125.2024.04.17.07.19.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 07:19:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fUGdD89K; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-148666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148666-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3DB66281C08 for ; Wed, 17 Apr 2024 14:19:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC21D6CDB7; Wed, 17 Apr 2024 14:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fUGdD89K" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1318B13F42E for ; Wed, 17 Apr 2024 14:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713363538; cv=none; b=VG4drJWUzDahb+PaGUwkJFymdwcz7XnQR4w7mD3FoukkFYp3ZU7Gykq1bQAqANweEOSNmVlINsqVrYWhsG0I1WjYzFbVuTmYLUk7415WL7sx4fEcLL2YwTDbGeMi54eut5JTY3yVBmkDwTRvWj2NYDJXuVAj82+1Ea1ix60KEDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713363538; c=relaxed/simple; bh=MZQGj06BJDdrslsKZJAiXK55Co8ES6uGoSaBdr5+6bI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=NU/7Jve5gjDoopVIWoNv5/0H7pMsAVkTa7k78mMLVbXKUVfDVnB/BUGrfIY6HJK7mbZFCyUN8nu4Y6xmqnFpf2/4zXw5a8reNSKUppXM8S/vt8mICst73TPGkBlo9vXQAa/6h46nTaMfwI6+8KcT1xzOU+18uPNTkud3aN4TySk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fUGdD89K; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 671E1C072AA; Wed, 17 Apr 2024 14:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713363537; bh=MZQGj06BJDdrslsKZJAiXK55Co8ES6uGoSaBdr5+6bI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fUGdD89Km7HiRVPvV9ilyfxfT8MehO5cgauI6yIvifsb9UztQiV8UtJ02vrG/pf1U HLmT27aX6TVjTtmQ7AoppChmzdNpXqM32hsyuVe2bGt/LdeZkx8D36VOIMPQNpcasg LjN7njybBqoCwTeuatDo/aDuh1HteTmV4u/64a2LjWiRjU3L85AsERHFWsLVgFujUB ibSmUTAZ7b88htsH6jY7ogxq4wFK8RmBFIM4G0rU833BLHTjmPK46AaZgBETKGfFJY /bCDVk5Mp2uZ2BNBfZGsOBQ8j9SuxoB2byM9LYsISds8dhqVG9qxlqrgCM2CvPEv6c aFVPfjj202BAA== From: Pratyush Yadav To: Michael Walle Cc: Tudor Ambarus , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v1 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info() In-Reply-To: <20240412134405.381832-6-mwalle@kernel.org> (Michael Walle's message of "Fri, 12 Apr 2024 15:44:04 +0200") References: <20240412134405.381832-1-mwalle@kernel.org> <20240412134405.381832-6-mwalle@kernel.org> Date: Wed, 17 Apr 2024 16:18:55 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi, On Fri, Apr 12 2024, Michael Walle wrote: > Rework spi_nor_get_flash_info() to make it look more straight forward > and esp. don't return early. The latter is a preparation to check for > deprecated flashes. Looks much nicer now! Though I did spend around 15 minutes wondering if it can be made even simpler, but I can't come up with anything better. Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav