Received-SPF: pass (google.com: domain of linux-kernel+bounces-148630-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 17 Apr 2024 14:50:58 +0100
From: Gary Guo <gary@garyguo.net>
To: <dev@raxyte.com>
Cc: <ojeda@kernel.org>, <alex.gaynor@gmail.com>, <wedsonaf@gmail.com>,
 <boqun.feng@gmail.com>, <bjorn3_gh@protonmail.com>,
 <benno.lossin@proton.me>, <a.hindborg@samsung.com>, <aliceryhl@google.com>,
 <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: update `dbg!()` to format column number
Message-ID: <20240417145058.7bad0df9@eugeo>
In-Reply-To: <eba70259-9b10-4bf7-ac4f-d7accf6b8891@smtp-relay.sendinblue.com>
References: <eba70259-9b10-4bf7-ac4f-d7accf6b8891@smtp-relay.sendinblue.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?f393RCY4WmdOJk4CkgA35qIRm4rNgRBhEGLpuKOMB58pZxk2Sz9HVH3FHi2n?=
 =?us-ascii?Q?SdVx2gKAiQ7eZNIbILoyoRcB7LfPSK+m3TD2mgyufOfwHqmeoW/nlq+SGgxC?=
 =?us-ascii?Q?bMFvONN/9MxJ2/qsuuZj+eizia3BcXnF43ePjsP3kxrwSafmCbH32Quhmjhu?=
 =?us-ascii?Q?sVvZDV5Aev57M+XQRxQS6Yzn+6mm/+DREvz488rb95d39oXa7bLdXsbmoFbJ?=
 =?us-ascii?Q?7Y+IhIm0nOfuSAJrVQMMEzAMFAU816knZWcQt5fBv+tZAHKAOvTgVubKYckx?=
 =?us-ascii?Q?UKoQMu1LB22agP2pVp6FK554B3ixxzHjd9oEKyxK2xH0magYueeY8+cdhgfi?=
 =?us-ascii?Q?boft+ACEyGVf1vcf6e95zL6CbDwtnbzk+vZVXLTeeqfZcT5y3FWrZG9UaN+k?=
 =?us-ascii?Q?g/WzIyOl2m4dWqUzCpo2ayMJsHtLN01qKBg2ioseZSY5zKf50bcpDIe233O5?=
 =?us-ascii?Q?zS1oK7VpQLyV5fot6+sv75zm/Q6gx/nuXVNmOFKcA2D1/m+LR/6Hi+V1jYSe?=
 =?us-ascii?Q?7uAHpKLF47F8tleNCM8LEjZRo6lD0T5bIj+ywbNP5TvzeEjRWbRPT+N2uwxW?=
 =?us-ascii?Q?A7rdyYRCueZn7WjJrCo+ZVJsML+yJgvC+w9vFaWfhmadMMQoVg2YdbDweoEH?=
 =?us-ascii?Q?cV9be/jrfs23BXfNXWqVKPqexpgp7THDarQ1bLQpNDYC4iZX/Dal/glGsysM?=
 =?us-ascii?Q?drti4+g9KaOTLlQ9Pl1DER+MBcc65v119iN9NV8UF+5SAAVWHp3RgzVPWqej?=
 =?us-ascii?Q?NvTo0qlZ6SZq6im6fSyZnZnscAhddt5mAzrTtFyLHr4ZsLQMDRMyqzYw04Ev?=
 =?us-ascii?Q?yvl3xeoq18Ncdc+2uc2ECbiqJlKotlsLoco2aqowJdmZr63w+RBkOrb82ycI?=
 =?us-ascii?Q?rR6v2s/DxH7ewIAyyFITgH/64aEqmf2K0WPk/0B6dXOzb7di7pFZUlYPgl4K?=
 =?us-ascii?Q?/jdXxBpjYqEuBQzfFxWWkI4a7zbypW8qHj5LKe3+cUt/hnpiLbo9Lhh4bn1E?=
 =?us-ascii?Q?qpkKrOZ/Nj+47pZTHZvRDKW2DMobeipFc0i/n5zOpa6Qt60oCWOYNC8uBDik?=
 =?us-ascii?Q?CFUZykWUqPv7haVQonntpGhCiCFaBX7dc2b+OLG4rHPtWjzmrinw9okvfAiY?=
 =?us-ascii?Q?YutEbJuPoRqKq16yq+nq8aTEDrHz8fwZZpEvxRLaE5s4q6DGHq+AshymwjkP?=
 =?us-ascii?Q?g5m3Y8Jf4xBirY/dee+tRqzsoezcEZBU353jWZKzUuE5Ww4U8qxMQKD086m2?=
 =?us-ascii?Q?K+YcvdjZOdRrhx/X7L88bYfbMp4Rae/pGFC5f165IEhI47LVBLLtVXtV5ihx?=
 =?us-ascii?Q?qD7IE0SP36rxcUYSUFYMtgTXqjfLSx4cO6aap4P1BKwuhVuLz/Wc+XIwLoLq?=
 =?us-ascii?Q?60k2GjLHMAn8YkQ+yxLDP4PtSjeP4mR72BuazFP4INvox0/d4381zh55B8jL?=
 =?us-ascii?Q?jeBdGH92tMxJX8H9RH9th9qNzHgB0K1jjwNLTm4XLuUOpAs6mSZwnWLz2/WA?=
 =?us-ascii?Q?JPKagBYFVMgClMn5lqKc5HFrJbkSwkssbEA2wCs+SVjjM8FzzL2onxG1aI4Z?=
 =?us-ascii?Q?hKS6pwG5pm4NEabL3B6siyUfTxNIuXlxZ6F4Nny5?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 63ca5621-39d9-493f-68db-08dc5ee56a46
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 13:51:00.4799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jjc+PUNs5J/4gIArR00qxu7MREOC3Zvej5Ba5H7bnBPgoWrUiLWvhmePU9AOSSV2IcWnvTb1vA0BOs6tulEJFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB3507

On Sun, 14 Apr 2024 18:49:28 +0530
<dev@raxyte.com> wrote:

> In Rust 1.76.0, the `dbg!()` macro was updated to also format the column
> number. The reason cited was usage of a few characters worth of
> horizontal space while allowing direct jumps to the source location. [1]
> 
> Link: https://github.com/rust-lang/rust/pull/114962 [1]
> Link: https://github.com/Rust-for-Linux/linux/issues/1065
> 
> Signed-off-by: Raghav Narang <dev@raxyte.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  Branch rust-next 
> 
>  rust/kernel/std_vendor.rs | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/rust/kernel/std_vendor.rs b/rust/kernel/std_vendor.rs
> index 388d6a514..39679a960 100644
> --- a/rust/kernel/std_vendor.rs
> +++ b/rust/kernel/std_vendor.rs
> @@ -146,15 +146,16 @@ macro_rules! dbg {
>      // `$val` expression could be a block (`{ .. }`), in which case the `pr_info!`
>      // will be malformed.
>      () => {
> -        $crate::pr_info!("[{}:{}]\n", ::core::file!(), ::core::line!())
> +        $crate::pr_info!("[{}:{}:{}]\n", ::core::file!(), ::core::line!(), ::core::column!())
>      };
>      ($val:expr $(,)?) => {
>          // Use of `match` here is intentional because it affects the lifetimes
>          // of temporaries - https://stackoverflow.com/a/48732525/1063961
>          match $val {
>              tmp => {
> -                $crate::pr_info!("[{}:{}] {} = {:#?}\n",
> -                    ::core::file!(), ::core::line!(), ::core::stringify!($val), &tmp);
> +                $crate::pr_info!("[{}:{}:{}] {} = {:#?}\n",
> +                    ::core::file!(), ::core::line!(), ::core::column!(),
> +                    ::core::stringify!($val), &tmp);
>                  tmp
>              }
>          }
> 
> base-commit: 8db31d3f3bd5dbc8cf3a22bba04b4b4add7f984e