Received-SPF: pass (google.com: domain of linux-kernel+bounces-148683-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240321114201.359381-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20240321114201.359381-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 17 Apr 2024 16:38:14 +0200
Message-ID: <CAMuHMdVvARk6i_aU6B7yPFfAGwaK5Yh=idYP9iuEAHoP9PvjOg@mail.gmail.com>
Subject: Re: [PATCH] reset: reset-rzg2l-usbphy-ctrl: Ensure reset line is
 asserted in error path
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>, Biju Das <biju.das.jz@bp.renesas.com>, 
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Prabhakar,

On Thu, Mar 21, 2024 at 12:43=E2=80=AFPM Prabhakar <prabhakar.csengg@gmail.=
com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> In the event of failure during devm_reset_controller_register(), ensure
> that the reset line is asserted back.
>
> Fixes: bee08559701fb ("reset: renesas: Add RZ/G2L usbphy control driver")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> @@ -132,8 +132,10 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_d=
evice *pdev)
>         priv->rcdev.dev =3D dev;
>
>         error =3D devm_reset_controller_register(dev, &priv->rcdev);
> -       if (error)
> +       if (error) {
> +               reset_control_assert(priv->rstc);
>                 return error;
> +       }
>
>         spin_lock_init(&priv->lock);
>         dev_set_drvdata(dev, priv);

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Alternatively, you could register a cleanup handler with
devm_add_action_or_reset(), like many drivers already do.
Or better, turn devm_aspeed_peci_reset_control_deassert() into a
generic helper, and convert all drivers[1] to use that.

That would just leave us with undoing pm_runtime_enable(), which can
be automated using devm_pm_runtime_enable() instead.

[1] git grep -w devm.*reset_control_assert

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds