Received-SPF: pass (google.com: domain of linux-kernel+bounces-148686-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 17 Apr 2024 10:40:00 -0400
From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: peng.fan@nxp.com, vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, imx@lists.linux.dev, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dmaengine: fsl-edma: clean up unused
 "fsl,imx8qm-adma" compatible string
Message-ID: <Zh/fQFdxHHxC5iXF@lizhi-Precision-Tower-5810>
References: <20240417032642.3178669-1-joy.zou@nxp.com>
 <20240417032642.3178669-2-joy.zou@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417032642.3178669-2-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IcowwsSUcM+VULdgiOobRwaZt/BKbJdkA2N7clUb+rHjNJr/KQb/O9rBj+r6?=
 =?us-ascii?Q?IJZ03pa38qBPiKcLxhLgwGHEdwUELKXt/96ttqQP9Khu8ZQdnM3kgco3qOhz?=
 =?us-ascii?Q?InAb7e+lR7MkeBMYxwOrtzCZ7vHNpwkDDOJoBuS+pBZrru30Ya4VDO/TSIBs?=
 =?us-ascii?Q?Dy9JoRv6CbwxHtGCfin0QxcUZx2FNsW1YpHTPdpRi7s++LiZ554R/kMAwrt3?=
 =?us-ascii?Q?Jh8kpElqxzIuj9R5D/rZ9rMkj5uz4nQd1MpBMmV5twNFDaakJWtRjnloQ39J?=
 =?us-ascii?Q?qLuiXZp5CdmrFBWfHfwsqYTgX2YQz7y/6oeZ7wYZMse6VXNxXcSz1rgCjOSi?=
 =?us-ascii?Q?WwfRyc3dbthK+tAcXE73OQHrcubGIUvi+X0oiuqjoWNKXpTCBu7e689jxge0?=
 =?us-ascii?Q?nQ4oe9kHbDkcciLmHwvgsUpTZEr5SrAzljZVyYNfOaLsmN+lSWlsAFw/zzne?=
 =?us-ascii?Q?Kd9Rzp9ida0Y/GixUXPSO5y3vLFiHl/J4645mRahqZbZBqqGgiDxh2veEMMJ?=
 =?us-ascii?Q?bktzsIHXS21kAJ7qb0ZGwdtJn+f/U8t+zfzFooAalrgvKaAY7ZgWiKiQVCSg?=
 =?us-ascii?Q?5+1rM3eHbSBv05txSdpWjPgpb/BvZaWSFS25IrR5vCv+v1be+Q3DzYcqmHpH?=
 =?us-ascii?Q?yMrmAgy6i5fWFZZCAPRIRIAmNh2m/pd6WM+sF/cz/mW5KvoD8CtpOx1ODNV2?=
 =?us-ascii?Q?zi3+VMbE+MJq/hWaQHtR45I53H5P/ifvrFiAcYaFefGbYV93oLNtDJlFwDsA?=
 =?us-ascii?Q?QACHIv77kDmKQfTIJ8stuOTIy5hZ4M5Jq6CYcXySDNziqK5qwq2Y7f3GxCjD?=
 =?us-ascii?Q?+5bQLWXPuTxDCWed5QKU5G5vHUz5DQRKakQRp7+yQ1xli9/vEbW5OygZPZ1e?=
 =?us-ascii?Q?rTnQfYSs5IolSlRMXbW4yWgASZCJQcCSMUQcOMwvvvO2meSkz/6J3C9MLnnO?=
 =?us-ascii?Q?UG1gU9TjB6spG1ACEf7ofTB1LJl8G4wivxCVKBNgBt/Pm7PpxG3y3hyodAU6?=
 =?us-ascii?Q?UfzaEpIawdGoFHxGkBODbAwp+aEfWkMifKSPAxWRiYYTWRGKLaM9+dX4FV8x?=
 =?us-ascii?Q?ul7omwtIXx2/BWZDsS8rH3rKs1sMW+WwCkhU4ukPbpi4ZQ993B16zxg5uxfy?=
 =?us-ascii?Q?+3nPfLoq66Flyjpf0JdEKPJ/RL2/9dZeLPRCFBCeF8+QKbINadh9wy+FxG6h?=
 =?us-ascii?Q?tOhWHf6ILpG/6rgRiKv1n4Os+8jz3EvQasySxqjHwdJ0Q3BYnn3inalTJUDu?=
 =?us-ascii?Q?tpboWkbscHw51olsUkBnCRLtZQ/T8z0K0c5kkzS8DWQpYIgZucEmAK0RtipG?=
 =?us-ascii?Q?zW2cATeR7zpJJIiMivyTtZqr1s1YQz+q7ditUbcastIYYYi5bppvZxU6CVVf?=
 =?us-ascii?Q?Yh1CfVKvbE+7PYnSbjRM8NWSOjwAto21bn1npneTW13mTIaYdFAGrZ1uIno+?=
 =?us-ascii?Q?YFHcnfzZkazi9mZrWrGnL6XT57XHW5mOnpFzMmh4VzoYpjgsceCMFRUKoeQm?=
 =?us-ascii?Q?jtjcIdtgXXcNqzqLfSiFpq+nvNCSm2zOa7XNC+ZzKjPGHhUIsxYuLms5LnPW?=
 =?us-ascii?Q?wCGy/X2Fq0tmsMbgk+t8MP99gm75zHrPgB4ZBnsO?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aef69817-66f0-4d22-42b8-08dc5eec4771
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 14:40:08.5170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: THCmRw7y9BjabcSxHU/Tbf07CDrxBZikVxTiG9VbrvoFMfos/zWGuDtXKtkQdTrJhEMlMtt9eQp064X4Lvsi1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7374

On Wed, Apr 17, 2024 at 11:26:41AM +0800, Joy Zou wrote:
> The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
> So remove the workaround safely.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
> Changes for v4:
> 1.change the subject to keep consistent with the patchset.
> 
> Changes for v2:
> 1. Change the subject.
> ---
>  drivers/dma/fsl-edma-common.c | 16 ++++------------
>  drivers/dma/fsl-edma-main.c   |  8 --------
>  2 files changed, 4 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index f9144b015439..ed93e01282d5 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct fsl_edma_chan *fsl_chan)
>  
>  	flags = fsl_edma_drvflags(fsl_chan);
>  	val = edma_readl_chreg(fsl_chan, ch_sbr);
> -	/* Remote/local swapped wrongly on iMX8 QM Audio edma */
> -	if (flags & FSL_EDMA_DRV_QUIRK_SWAPPED) {

You forget remove FSL_EDMA_DRV_QUIRK_SWAPPED in fsl-edma-common.h

Frank

> -		if (!fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	} else {
> -		if (fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	}
> +	if (fsl_chan->is_rxchan)
> +		val |= EDMA_V3_CH_SBR_RD;
> +	else
> +		val |= EDMA_V3_CH_SBR_WR;
>  
>  	if (fsl_chan->is_remote)
>  		val &= ~(EDMA_V3_CH_SBR_RD | EDMA_V3_CH_SBR_WR);
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 755a3dc3b0a7..b06fa147d6ba 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -349,13 +349,6 @@ static struct fsl_edma_drvdata imx8qm_data = {
>  	.setup_irq = fsl_edma3_irq_init,
>  };
>  
> -static struct fsl_edma_drvdata imx8qm_audio_data = {
> -	.flags = FSL_EDMA_DRV_QUIRK_SWAPPED | FSL_EDMA_DRV_HAS_PD | FSL_EDMA_DRV_EDMA3,
> -	.chreg_space_sz = 0x10000,
> -	.chreg_off = 0x10000,
> -	.setup_irq = fsl_edma3_irq_init,
> -};
> -
>  static struct fsl_edma_drvdata imx8ulp_data = {
>  	.flags = FSL_EDMA_DRV_HAS_CHMUX | FSL_EDMA_DRV_HAS_CHCLK | FSL_EDMA_DRV_HAS_DMACLK |
>  		 FSL_EDMA_DRV_EDMA3,
> @@ -397,7 +390,6 @@ static const struct of_device_id fsl_edma_dt_ids[] = {
>  	{ .compatible = "fsl,ls1028a-edma", .data = &ls1028a_data},
>  	{ .compatible = "fsl,imx7ulp-edma", .data = &imx7ulp_data},
>  	{ .compatible = "fsl,imx8qm-edma", .data = &imx8qm_data},
> -	{ .compatible = "fsl,imx8qm-adma", .data = &imx8qm_audio_data},
>  	{ .compatible = "fsl,imx8ulp-edma", .data = &imx8ulp_data},
>  	{ .compatible = "fsl,imx93-edma3", .data = &imx93_data3},
>  	{ .compatible = "fsl,imx93-edma4", .data = &imx93_data4},
> -- 
> 2.37.1
>