Received-SPF: pass (google.com: domain of linux-kernel+bounces-148676-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 17 Apr 2024 17:28:18 +0300
From: Andy Shevchenko <andy@kernel.org>
To: Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: keescook@chromium.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	skhan@linuxfoundation.org
Subject: Re: [PATCH] string: Implement KUnit test for str*cmp functions
Message-ID: <Zh_cgnMOFHuP-lKu@smile.fi.intel.com>
References: <20240417135415.614284-1-ivan.orlov0322@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417135415.614284-1-ivan.orlov0322@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Apr 17, 2024 at 02:54:15PM +0100, Ivan Orlov wrote:
> Currently, str*cmp functions (strcmp, strncmp, strcasecmp and
> strncasecmp) are not covered with tests. Implement the test which
> covers them all.
> 
> The strcmp test suite consist of 8 test cases:
> 
> 1) strcmp test
> 2) strcmp test on long strings (2048 chars)
> 3) strncmp test
> 4) strncmp test on long strings (2048 chars)
> 5) strcasecmp test
> 6) strcasecmp test on long strings
> 7) strncasecmp test
> 8) strncasecmp test on long strings
> 
> The test aims at covering as many edge cases as possible, including
> the tests on empty strings, situations when the different symbol is
> placed at the end of one of the strings, etc.

..

>  lib/strcmp_kunit.c | 170 +++++++++++++++++++++++++++++++++++++++++++++

Why is not part of the existing string_kunit.c?

-- 
With Best Regards,
Andy Shevchenko