Received-SPF: pass (google.com: domain of linux-kernel+bounces-148711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 17 Apr 2024 15:43:15 +0100
From: Dave Martin <Dave.Martin@arm.com>
To: "Moger, Babu" <babu.moger@amd.com>
Cc: James Morse <james.morse@arm.com>, x86@kernel.org,
	linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, shameerali.kolothum.thodi@huawei.com,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	carl@os.amperecomputing.com, lcherian@marvell.com,
	bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
	baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
	dfustini@baylibre.com, amitsinght@marvell.com,
	David Hildenbrand <david@redhat.com>,
	Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH v1 31/31] x86/resctrl: Move the resctrl filesystem code
 to /fs/resctrl
Message-ID: <Zh/gA29yEpbinEPh@e133380.arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-32-james.morse@arm.com>
 <99ac181d-d93c-4b11-84aa-48953d9eb5a3@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <99ac181d-d93c-4b11-84aa-48953d9eb5a3@amd.com>

Hi,

On Mon, Apr 15, 2024 at 03:44:48PM -0500, Moger, Babu wrote:
> James/Dave,
> This is a huge change. Can this be broken into multiple patches?
> It will be a major task in case we need to bisect to pinpoint any issues
> later.
> Thanks
> Babu

[...]

I guess this might be possible, though when moving groups of static
functions around that refer to each other it might be more trouble than
it is worth.

I'll need to discuss with James.

Either way, I think this patch will need to rebuilt when spinning v2 of
this series.  I've been rebasing it by hand, which is not exactly
foolproof!

It ought to be possible to break this up into one patch per affected .c
file at least, if people feel that it is worthwhile.

Cheers
---Dave