Received-SPF: pass (google.com: domain of linux-kernel+bounces-148722-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <10085ec8-0109-444c-bce4-d0b0ef1a4164@gmail.com>
Date: Wed, 17 Apr 2024 15:46:44 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] string: Implement KUnit test for str*cmp functions
To: Andy Shevchenko <andy@kernel.org>
Cc: keescook@chromium.org, akpm@linux-foundation.org,
 linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
 skhan@linuxfoundation.org
References: <20240417135415.614284-1-ivan.orlov0322@gmail.com>
 <Zh_cgnMOFHuP-lKu@smile.fi.intel.com>
Content-Language: en-US
From: Ivan Orlov <ivan.orlov0322@gmail.com>
In-Reply-To: <Zh_cgnMOFHuP-lKu@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/17/24 15:28, Andy Shevchenko wrote:
> On Wed, Apr 17, 2024 at 02:54:15PM +0100, Ivan Orlov wrote:
>> Currently, str*cmp functions (strcmp, strncmp, strcasecmp and
>> strncasecmp) are not covered with tests. Implement the test which
>> covers them all.
>>
>> The strcmp test suite consist of 8 test cases:
>>
>> 1) strcmp test
>> 2) strcmp test on long strings (2048 chars)
>> 3) strncmp test
>> 4) strncmp test on long strings (2048 chars)
>> 5) strcasecmp test
>> 6) strcasecmp test on long strings
>> 7) strncasecmp test
>> 8) strncasecmp test on long strings
>>
>> The test aims at covering as many edge cases as possible, including
>> the tests on empty strings, situations when the different symbol is
>> placed at the end of one of the strings, etc.
> 
> ...
> 
>>   lib/strcmp_kunit.c | 170 +++++++++++++++++++++++++++++++++++++++++++++
> 
> Why is not part of the existing string_kunit.c?
> 

There are already 2 other KUnit tests in `lib/` covering different 
groups of string functions separately (lib/strscpy_kunit.c, 
lib/strcat_kunit.c), so this patch just follows this pattern. I believe 
it makes sense: the tests are separated to cover one specific group of 
string functions with a similar purpose

---
Kind regards,
Ivan Orlov