Received-SPF: pass (google.com: domain of linux-kernel+bounces-148753-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 17 Apr 2024 16:06:36 +0100
From: Gary Guo <gary@garyguo.net>
To: Benno Lossin <benno.lossin@proton.me>
Cc: Boqun Feng <boqun.feng@gmail.com>, Miguel Ojeda <ojeda@kernel.org>, Alex
 Gaynor <alex.gaynor@gmail.com>, Wedson Almeida Filho <wedsonaf@gmail.com>,
 =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>, Andreas Hindborg
 <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>, Martin
 Rodriguez Reboredo <yakoyoku@gmail.com>, rust-for-linux@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: init: change the generated name of guard
 variables
Message-ID: <20240417160636.0e649b68@eugeo>
In-Reply-To: <ef1400ae-ba9e-4656-98db-a882ac720c1e@proton.me>
References: <20240403194321.88716-1-benno.lossin@proton.me>
	<Zg3IHZfYVEOh7nc4@boqun-archlinux>
	<ef1400ae-ba9e-4656-98db-a882ac720c1e@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?QeGGWxZjcqea65UM6rny2FrIwGi2n2IOFW4BGS5BcO2Y94oTKid2IZuj6svx?=
 =?us-ascii?Q?0miMTfwbDL8WUylgdsXrTFvgSpdb9FLxVZG3oPiUYLImxL2CQYqozEwcg7QZ?=
 =?us-ascii?Q?AXy1qYh0xfZyoI3t1QqG1awUloVtBgdcoGh9z6KnkspD1ljTdoqi+ym/wLqA?=
 =?us-ascii?Q?qHF8yQvNoAGRWl8HI7FmNSwCSqvv6YPWAahObnr6swT10FWPsJ1LwwTXVmC3?=
 =?us-ascii?Q?E5cPlbCPCMxdVHFd700L7bB8j3FS/KVY5ybkoQt6L8iy9tjF9YwM7F2t4XEf?=
 =?us-ascii?Q?dmRNckqfGIVJSDf4Vu716bFwYo72ezR4xkmw+5X7eB6LuWpIBQcgV5DXMLdR?=
 =?us-ascii?Q?Wqq9k/OUcCEQcpE0Ml4IkQul6AChFgFDqEG10WpNDq2oyyjUc0gWw6/gMwmx?=
 =?us-ascii?Q?fMqt4SPZNiHF+8TJkBOiPy8XlxQAPvOKlqB9KJyQxoQ+N5BqPdX9nEfRmMbI?=
 =?us-ascii?Q?R2hU8wT4hKbYbB55Tb2Y2Pv4xNOcYmail90/MjCjYDXXnksgg9YtxRwuBwue?=
 =?us-ascii?Q?cZoo58t1hNd0DE66hTlwEOyQTXVDJWsAe4zxBNO6jyWalBt2rtsQ3Aqw7KGX?=
 =?us-ascii?Q?ArOjgrrsWVkR8mc+fY6mDzLGvGvQpOcNLeTRQGkdH16+0xw7y+zZomUqTPVD?=
 =?us-ascii?Q?w1nzV8pZgU1uu8EgOjuVilMSwlnVIzyzGR46OAIfIoanlImyHpo5YbTOsR4h?=
 =?us-ascii?Q?BRv48O0zHoJRpkD7IChrilHxX3EaGtFF/4RYY7t4Dau7W7R2Ym5H/vroODTV?=
 =?us-ascii?Q?sTUQ7YLS1uNbqKLf+SQMBu7FWdtYYPZyI/LJC03Nmu82Mk22dCPUNQp1AyPi?=
 =?us-ascii?Q?rullP3XweBlxGRpLVsmVhk85WZMOk8pZatwuFp4th1frFQKB3OS3PqzNK9r8?=
 =?us-ascii?Q?ImG9uRwqcafO9ps+SLUaM9ehNhZ1SOD9tdbImRgBvHPpr03wicqe/B54egQk?=
 =?us-ascii?Q?bab+6I1eMApsxFeLW9DpMvhh9AggzBeRySE676Wpdqbc4G7lDdV/viQ4GCt8?=
 =?us-ascii?Q?bYv584CypPS/mz8Fz56JGoPzFLSBRt2Xq0ZpYqnmUqgZtWYdXXB9oZSOtPfm?=
 =?us-ascii?Q?zFdMKl15WWfbxRzvzE+bJ2R0xn0xexm0T4Yyor2W/grs6jRhn7S6wN9zOJI8?=
 =?us-ascii?Q?e+FVJvOpzYCH8l5rmJmRp22mlms4G9e0eNeb+D7KVGe71UlbXsLIh723iFWe?=
 =?us-ascii?Q?hnrlzA87yEY/MKrncFoew6cNBzt0Lc/TzQUCdhfCm0CNwNuHYyMcOfN22+3b?=
 =?us-ascii?Q?p1f0c2om55Zl83hblKnjZorX+mApLpAle9/OAklka6n2dpuFe2drPT31sWwW?=
 =?us-ascii?Q?muDrfi49rFSAcYDCYTYqpQ+qVd8B0qo/E/HKvhBKZ1JJ7QF75Y/CPQpe87rD?=
 =?us-ascii?Q?3/4YRbHguQtaBKtZ6FpXBoqJT0QfpMriLniQwBj+SLB5IzDC/6/zQNSj80Ge?=
 =?us-ascii?Q?FjykyaGQ25Ed+jggX/RuPPdHl8X0Kh2ieRqMX8An0yXvco8DWng/DS8F1WWF?=
 =?us-ascii?Q?N+mPWMIzhMtq779VUbk/FuMnavgopZRlXbAERkANhwObPisAOwJOSOa6UIIJ?=
 =?us-ascii?Q?25gEzhAgs8Iwq7Q1BSx0QoHa/CHRDYwBU6dQQsCu?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 3afc39a4-b374-4e57-f9c0-08dc5eeffb51
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 15:06:38.7837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MNKY6V3XsPDtZheX48fR/tkJk7rtt/Ayrn54Y3FK9kfUP++Hf1G+gzWgCr+yEEQKtKvhSGteOfewIYB17yEJBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB1992

On Wed, 03 Apr 2024 22:09:49 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> On 03.04.24 23:20, Boqun Feng wrote:
> > On Wed, Apr 03, 2024 at 07:43:37PM +0000, Benno Lossin wrote:  
> >> The initializers created by the `[try_][pin_]init!` macros utilize the
> >> guard pattern to drop already initialized fields, when initialization
> >> fails mid-way. These guards are generated to have the same name as the
> >> field that they handle. To prevent namespacing issues when the field  
> > 
> > Do you have an example of this kind of issues?  
> 
> https://lore.kernel.org/rust-for-linux/1e8a2a1f-abbf-44ba-8344-705a9cbb1627@proton.me/
> 

Here's the simplified example:

```
macro_rules! f {
    () => {
        let a = 1;
        let _: u32 = a;
    }
}

const a: u64 = 1;

fn main() {
    f!();
}
```

The `a` in `f` have a different hygiene so normally it is scoped to the
macro expansion and wouldn't escape. Interestingly a constant is still
preferred despite the hygiene so constants escaped into the macro,
leading to the error.

Would your change regress error message when `pin_init!` is used
wrongly? Personally I would say this kind of error is niche enough
(given the casing of constants and variables differ) that we probably
don't really need to care. So if error message would be affected then
we'd better off not making the change.

Best,
Gary