Received-SPF: pass (google.com: domain of linux-kernel+bounces-148763-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 17 Apr 2024 15:08:57 +0000
To: Nathan Chancellor <nathan@kernel.org>
From: Pratham Patel <prathampatel@thefossguy.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, Jonathan Corbet <corbet@lwn.net>, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, thefirst1322@gmail.com
Subject: Re: [PATCH 0/2] Enable building of the devel RPM package from Kbuild
Message-ID: <D0MHQUIYGONC.3LTT2WN2885D7@thefossguy.com>
In-Reply-To: <20240417144859.GA1471879@dev-arch.thelio-3990X>
References: <20240417043654.60662-1-prathampatel@thefossguy.com> <20240417144859.GA1471879@dev-arch.thelio-3990X>
Feedback-ID: 104309535:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed Apr 17, 2024 at 8:18 PM IST, Nathan Chancellor wrote:
> On Wed, Apr 17, 2024 at 04:37:32AM +0000, Pratham Patel wrote:
> > This addresses a minor nit where I want a `-devel` RPM package to be
> > built when I build a binary RPM package with either `binrpm-pkg`
> > or `rpm-pkg` target(s).
> >
> > Pratham Patel (2):
> >   kbuild: allow toggling the `with_devel` RPM macro
> >   docs: kbuild: document KBUILD_RPM_WITH_DEVEL
> >
> >  Documentation/kbuild/kbuild.rst | 6 ++++++
> >  scripts/Makefile.package        | 5 ++++-
> >  2 files changed, 10 insertions(+), 1 deletion(-)
> >
> > --
> > 2.42.0
> >
>
> Hmmm, when I execute
>
>   $ make -skj"$(nproc)" ARCH=3Dx86_64 O=3Dbuild mrproper defconfig binrpm=
-pkg
>
> I end up with
>
>   $ ls -1 build/rpmbuild/RPMS/x86_64
>   kernel-6.9.0_rc4_00031_g96fca68c4fbf-1.x86_64.rpm
>   kernel-devel-6.9.0_rc4_00031_g96fca68c4fbf-1.x86_64.rpm
>   kernel-headers-6.9.0_rc4_00031_g96fca68c4fbf-1.x86_64.rpm
>
> so it seems like this is already happening?
>
> Cheers,
> Nathan

Ah sorry, that was a typo. I meant to say the following:
"This addresses a minor nit where I **don't** want a `-devel` RPM
package to be built when I build a binary RPM package with either
`binrpm-pkg` or `rpm-pkg` target(s)."

That is because on ARM systems where I just need to quickly test the
upstream defconfig, I don't really need the `-devel` package.

Also, I see that in a hurry, I did the opposite of what I wanted in the
patches. This went unnoticed since I had KBUILD_RPM_WITH_DEVEL=3D0 for me
during testing. Sorry about that!

I'll send a v2 fixing this stupid mistake.

 -- Pratham Patel