Received-SPF: pass (google.com: domain of linux-kernel+bounces-148764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <af0d21eb-c31c-4a3d-99ac-45abf3bdaabd@zytor.com>
Date: Wed, 17 Apr 2024 08:09:19 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/1] x86/fred: Fix INT80 emulation for FRED
Content-Language: en-US
To: Xin Li <xin@zytor.com>, Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, luto@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org
References: <20240417063001.3773507-1-xin@zytor.com>
 <20240417093813.GBZh-YhSQCXgy3OxFI@fat_crate.local>
 <e8180be8-b108-4047-ab49-2cfc532a2b52@zytor.com>
From: "H. Peter Anvin" <hpa@zytor.com>
In-Reply-To: <e8180be8-b108-4047-ab49-2cfc532a2b52@zytor.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 4/17/24 08:06, Xin Li wrote:
> On 4/17/2024 2:38 AM, Borislav Petkov wrote:
>> On Tue, Apr 16, 2024 at 11:30:01PM -0700, Xin Li (Intel) wrote:
>>> 3) The FRED kernel entry handler does *NOT* dispatch INT instructions,
>>>     which is of event type EVENT_TYPE_SWINT, so compared with
>>>     do_int80_emulation(), there is no need to do any user mode check.
>>
>> What does that mean?
>>
>> An event handler doesn't dispatch INT insns?
>>
>> /me is confused.
>>
> 
> Maybe better to say?
> 
> The FRED kernel entry handler fred_entry_from_kernel() calls 
> fred_bad_type() if an event is of type EVENT_TYPE_SWINT because Kernel 
> does not use INT insns! So if the kernel is handling an INT insn, it can 
> only be from a user level application.
> 

(Note: if we at some point in the future we may end up adding INT calls 
from the kernel, at least on FRED it would *still* not share the same 
code paths and so int $0x80 would not get dispatched.)

	-hpa