Received-SPF: pass (google.com: domain of linux-kernel+bounces-148725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 17 Apr 2024 15:49:43 +0100
From: Lee Jones <lee@kernel.org>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>,
	linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [regression] stm32mp1xx based targets stopped entering suspend
 if pwm-leds exist
Message-ID: <20240417144943.GA2399047@google.com>
References: <5da6cf8a-4250-42f6-8b39-13bff7fcdd9c@leemhuis.info>
 <2vbwacjy25z5vekylle3ehwi3be4urm6bssrbg6bxobtdlekt4@mazicwtgf4qb>
 <256e3d3c-d43f-4bd6-9a7b-50fc870e75e4@leemhuis.info>
 <20240416121519.GS2399047@google.com>
 <dqibafuvizvltkblfizxvgrl3744lpxbwgdjid5ekxsju7gmxm@fys22ievmgz5>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dqibafuvizvltkblfizxvgrl3744lpxbwgdjid5ekxsju7gmxm@fys22ievmgz5>

On Tue, 16 Apr 2024, Uwe Kleine-König wrote:

> Hey Lee,
> 
> On Tue, Apr 16, 2024 at 01:15:19PM +0100, Lee Jones wrote:
> > On Tue, 16 Apr 2024, Linux regression tracking (Thorsten Leemhuis) wrote:
> > 
> > > On 06.03.24 09:18, Uwe Kleine-König wrote:
> > > > On Wed, Mar 06, 2024 at 08:05:15AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> > > > > [...]
> > > 
> > > Jakob confirmed it helped in the bugzilla ticket. But the patch since
> > > then didn't make any progress afaics -- or did it and I just missed it
> > > in my search?
> > 
> > [...] 
> > 
> > > > ---->8----
> > > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > Subject: [PATCH] leds: pwm: Disable PWM when going to suspend
> > > > 
> > > > On stm32mp1xx based machines (and others) a PWM consumer has to disable
> > > > the PWM because an enabled PWM refuses to suspend. So check the
> > > > LED_SUSPENDED flag and depending on that set the .enabled property.
> > > > 
> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218559
> > > > Fixes: 76fe464c8e64 ("leds: pwm: Don't disable the PWM when the LED should be off")
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > ---
> > > > [...]
> > > > ---->8----
> > 
> > Did you submit this?  I don't see it in LORE or in my inbox.
> 
> Yeah sure, apply it using:
> 
> 	curl -s https://lore.kernel.org/all/2vbwacjy25z5vekylle3ehwi3be4urm6bssrbg6bxobtdlekt4@mazicwtgf4qb/raw | git am --scissors -s

Nice try!

> :-)
> 
> If you don't consider that suitable, I can create a patch that is easier
> to pick up.

Yes, please submit it properly.

-- 
Lee Jones [李琼斯]