Received-SPF: pass (google.com: domain of linux-kernel+bounces-148768-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9f6d22cb-2170-4b80-912a-cfee18381b43@gmail.com>
Date: Wed, 17 Apr 2024 16:12:45 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] string: Implement KUnit test for str*cmp functions
To: Andy Shevchenko <andy@kernel.org>
Cc: keescook@chromium.org, akpm@linux-foundation.org,
 linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
 skhan@linuxfoundation.org
References: <20240417135415.614284-1-ivan.orlov0322@gmail.com>
 <Zh_cgnMOFHuP-lKu@smile.fi.intel.com>
 <10085ec8-0109-444c-bce4-d0b0ef1a4164@gmail.com>
 <Zh_ibi_Y6xogktg-@smile.fi.intel.com>
Content-Language: en-US
From: Ivan Orlov <ivan.orlov0322@gmail.com>
In-Reply-To: <Zh_ibi_Y6xogktg-@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/17/24 15:53, Andy Shevchenko wrote:
>> There are already 2 other KUnit tests in `lib/` covering different groups of
>> string functions separately (lib/strscpy_kunit.c, lib/strcat_kunit.c), so
>> this patch just follows this pattern. I believe it makes sense: the tests
>> are separated to cover one specific group of string functions with a similar
>> purpose
> 
> We have handful of the string functions, are you going to have a file per
> function? Isn't it way too many?
> 
> P.S>
> Having those does not prove it's a correct approach. I would rather expect
> somebody to incorporate those into string_kunit.c.
> 

Makes sense. Also, probably having all of them in `string_kunit.c` would 
fit better into the KUnit test style guidelines.

I'll merge this strcmp test into `string_kunit.c` in V2 of this patch, 
thank you for the review.

-- 
Kind regards,
Ivan Orlov