Received-SPF: pass (google.com: domain of linux-kernel+bounces-148732-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 17 Apr 2024 09:52:38 -0500
From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: djakov@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com,
	broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org,
	henryc.chen@mediatek.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com,
	wenst@chromium.org, amergnat@baylibre.com
Subject: Re: [PATCH v2 1/7] dt-bindings: regulator: Add bindings for MediaTek
 DVFSRC Regulators
Message-ID: <20240417145238.GA2348962-robh@kernel.org>
References: <20240417091442.170505-1-angelogioacchino.delregno@collabora.com>
 <20240417091442.170505-2-angelogioacchino.delregno@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417091442.170505-2-angelogioacchino.delregno@collabora.com>

On Wed, Apr 17, 2024 at 11:14:36AM +0200, AngeloGioacchino Del Regno wrote:
> The Dynamic Voltage and Frequency Scaling Resource Collector Regulators
> are controlled with votes to the DVFSRC hardware.
> 
> This adds support for the regulators found in MT6873, MT8183, MT8192
> and MT8195 SoCs.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../mediatek,mt6873-dvfsrc-regulator.yaml     | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6873-dvfsrc-regulator.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6873-dvfsrc-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6873-dvfsrc-regulator.yaml
> new file mode 100644
> index 000000000000..446f1dab4d2e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6873-dvfsrc-regulator.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mediatek,mt6873-dvfsrc-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek DVFSRC-controlled Regulators
> +
> +description:
> +  The Dynamic Voltage and Frequency Scaling Resource Collector Regulators
> +  are controlled with votes to the DVFSRC hardware.
> +
> +maintainers:
> +  - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mediatek,mt6873-dvfsrc-regulator
> +      - mediatek,mt8183-dvfsrc-regulator
> +      - mediatek,mt8192-dvfsrc-regulator
> +      - mediatek,mt8195-dvfsrc-regulator
> +
> +  reg:
> +    maxItems: 1
> +
> +  dvfsrc-vcore:
> +    description: DVFSRC-controlled SoC Vcore regulator
> +    $ref: regulator.yaml#

       unevaluatedProperties: false

> +
> +  dvfsrc-vscp:
> +    description: DVFSRC-controlled System Control Processor regulator
> +    $ref: regulator.yaml#

ditto

> +
> +required:
> +  - compatible

'reg' is never optional. And how is no regulators at all valid?

> +
> +additionalProperties: false
> +
> +examples:
> +  - |

Drop the example here. Just one complete example in the MFD doc.

> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        system-controller@10012000 {
> +            compatible = "mediatek,mt8195-dvfsrc";
> +            reg = <0 0x10012000 0 0x1000>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            regulators@0 {
> +                compatible = "mediatek,mt8195-dvfsrc-regulator";
> +                reg = <0>;

What does 'reg' value represent here? 0 and 1 seem pretty much made up.

> +
> +                dvfsrc_vcore: dvfsrc-vcore {
> +                        regulator-name = "dvfsrc-vcore";
> +                        regulator-min-microvolt = <550000>;
> +                        regulator-max-microvolt = <750000>;
> +                        regulator-always-on;
> +                };
> +
> +                dvfsrc_vscp: dvfsrc-vscp {
> +                        regulator-name = "dvfsrc-vscp";
> +                        regulator-min-microvolt = <550000>;
> +                        regulator-max-microvolt = <750000>;
> +                        regulator-always-on;
> +                };
> +            };
> +        };
> +    };
> -- 
> 2.44.0
>