Received-SPF: pass (google.com: domain of linux-kernel+bounces-148751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Saurav Kashyap <skashyap@marvell.com>
To: John Meneghini <jmeneghi@redhat.com>
CC: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "guazhang@redhat.com" <guazhang@redhat.com>,
        Nilesh Javali
	<njavali@marvell.com>
Subject: RE: [EXTERNAL] [PATCH] scsi: qedf: make qedf_execute_tmf
 non-preemptible
Thread-Topic: [EXTERNAL] [PATCH] scsi: qedf: make qedf_execute_tmf
 non-preemptible
Thread-Index: AQHahdgWB/HLzJQ5MEq/5VYjn6Cy9bFspa4A
Date: Wed, 17 Apr 2024 15:06:00 +0000
Message-ID: 
 <DM4PR18MB5220429DAFE75922C54173ABD20F2@DM4PR18MB5220.namprd18.prod.outlook.com>
References: <20240403150155.412954-1-jmeneghi@redhat.com>
In-Reply-To: <20240403150155.412954-1-jmeneghi@redhat.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?8ObQI7CZDwJMqKIl8s5PJmnDcf1zN0c69kP2ToMgIOmQn+mpHWaanIXy5S5w?=
 =?us-ascii?Q?jgcEB0z6aEZjTjlCWUue1XGv5PijLTcpykfU1EGwZFt5rHM1SuSNJeggn+Bz?=
 =?us-ascii?Q?punknoyJqL0y2pLiCyZKojKRjmSZPG0iI3321ArXc3vQLxruMMEoRI0z97Zm?=
 =?us-ascii?Q?7Sogag0kpWSgHZ0rJQC8AQSZ4iHVFB8nyO+pBWpbacwa+mkIjgjtiRIoh1yY?=
 =?us-ascii?Q?GyyMIuzfgy22O4qIRjFEvZDOxpHUjrVENp0Iio2RC1VZ8i1mICxU0qoFgglj?=
 =?us-ascii?Q?Xxy5pusUEB3slvmaBKJP28wvEcF64SRVgao5WbABGb6tpbdQ9IBU7bfwam9f?=
 =?us-ascii?Q?PLk0lOjeUAZLLWhtfIGw1DkFwBoAwPr2vLp9ZRARSEqlndisnfTMUo1jNOpA?=
 =?us-ascii?Q?5K4/0GrJzfeygrrMnK2Cj1N9d8yvv7C2QcP08o2cLLzjCJWT5PjvfiISzhi2?=
 =?us-ascii?Q?XUHwqhdfDNhufoN5kUGvgFKZjTsCJ0ofOFrGLXKE3iYSwxWBNddS91p2ghCA?=
 =?us-ascii?Q?OajVrHX0pf8iPoGBx4tCGduy3brO7TAFYeeZvgXCi8jOX8Wc8KydtHXytB0a?=
 =?us-ascii?Q?TpK0dMgwNMIx1zo6mxoNcsGhd2xQ6Zv/SzkgPaarPboiKrKkRA1zvqbv2uG7?=
 =?us-ascii?Q?8/xwREVR7Snm8BOTcA3v1A42907e2/rI5XxdTcqljkqhWlIqsFyUOTpdz2lg?=
 =?us-ascii?Q?OygWuGGLE0diZ3RldaLdmnx+TG9qYNF2Qj6vdqdZYzHVxeABghiOy30cuhqa?=
 =?us-ascii?Q?4ou60mqvVg/gf6CmjHkZPPiQ/G2bJvBWCynTPDfmWc5Rzv1PfDYjytV9AYcd?=
 =?us-ascii?Q?A30wpqBSggt03wwRp0K8K4oe7oLkWYo7dyZRpdZkumXW8fHj2/7mLuklWhwX?=
 =?us-ascii?Q?8nrDthteZ9FmFf/JRc8T8gaVHJo8BYH9k52dy5Orn5rijydgADE4ulqCJ8M6?=
 =?us-ascii?Q?19rQUJXogmKLu1fCCj0jeNECfjxv4EhTLPmr9i+p2iLi7LL3LgDMS2vXrFjI?=
 =?us-ascii?Q?KgceN36ArVoDNUHr0Opvsa2iZ6dbXPUamMWbHU8EtTvzwFBQtr5Ij9T7ay6b?=
 =?us-ascii?Q?SmiIhoJ+CF0mdoxxdDSXjEkdGTp+g6IerD8g/ZoAiL3BZz6/lRlOykOnsMez?=
 =?us-ascii?Q?Pkfw1HxuqLppT9BovqcI6lNX+0VTLWsuaZBmPTTG24+zzlz0ewv7SSnb1eSH?=
 =?us-ascii?Q?fpjm3taGEP4yLW5WbkFNwOnY+F3crxHDJ9bU6VakMb1upeT/3I5Am9KAHb4i?=
 =?us-ascii?Q?lBHAgSiL391mQFenm7CQsqw0A7j0IuC4XI+WDE8rktg6837DOrauq6jfQpuI?=
 =?us-ascii?Q?8861ZEg4UTMSVS67QzemHq7AF1/FW6DYKCFfN8AiX2wrOClMRdUM3oAzGgEb?=
 =?us-ascii?Q?Nkn7AKyQnVqzUcdE/b92PQuNMZPP9WXdrx8jhg2V+m+53JQEtsb/og1FbuHn?=
 =?us-ascii?Q?8npaIG/mCe9aimvr2QhTr6b1CJvKaWzZh5jdK947AOgGt5lLF4i5Mgn2waZi?=
 =?us-ascii?Q?z33I8pwZDA9G3Vdaqr9dgQYwC8Be3PZMMFesAGH4MCfZM2x4fV2j4KqP4JiQ?=
 =?us-ascii?Q?oeubbaVW8+K0WqEmlnpsremjpjnfGGsbAySKiuWK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR18MB5220.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97946dc0-ca00-4139-9dcf-08dc5eefe4d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2024 15:06:00.9056
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aOQR0wKNyCoYMBRnr9SerrgBK16G5nawoUtca5SGTkGml/lnpG9XrZmHT/jTFRI2VqccVDan+TcEG50qr+lTBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB5617
X-Proofpoint-GUID: WD_GRf6SNvObuaT0EeSLqZ0j0pmcfKek
X-Proofpoint-ORIG-GUID: C3lUm_EY8qPeFj792-MiwcJyZUw2kcol
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-17_12,2024-04-16_01,2023-05-22_02

Acked-by: Saurav Kashyap <skashyap@marvell.com>

> -----Original Message-----
> From: John Meneghini <jmeneghi@redhat.com>
> Sent: Wednesday, April 3, 2024 8:32 PM
> To: Saurav Kashyap <skashyap@marvell.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; GR-QLogic-S=
torage-
> Upstream <GR-QLogic-Storage-Upstream@marvell.com>;
> martin.petersen@oracle.com; guazhang@redhat.com; Nilesh Javali
> <njavali@marvell.com>
> Subject: [EXTERNAL] [PATCH] scsi: qedf: make qedf_execute_tmf non-
> preemptible
>=20
> Prioritize security for external emails: Confirm sender and content safet=
y before
> clicking links or opening attachments
>=20
> ----------------------------------------------------------------------
> Stop calling smp_processor_id from preemptible code in qedf_execute_tmf.
> This results in BUGON when running an RT kernel.
>=20
> [ 659.343280] BUG: using smp_processor_id() in preemptible [00000000] cod=
e:
> sg_reset/3646
> [ 659.343282] caller is qedf_execute_tmf+0x8b/0x360 [qedf]
>=20
> Tested-by: Guangwu Zhang <guazhang@redhat.com>
> Cc: Saurav Kashyap <skashyap@marvell.com>
> Cc: Nilesh Javali <njavali@marvell.com>
> Signed-off-by: John Meneghini <jmeneghi@redhat.com>
> ---
>  drivers/scsi/qedf/qedf_io.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
> index bf921caaf6ae..054a51713d55 100644
> --- a/drivers/scsi/qedf/qedf_io.c
> +++ b/drivers/scsi/qedf/qedf_io.c
> @@ -2324,9 +2324,6 @@ static int qedf_execute_tmf(struct qedf_rport
> *fcport, u64 tm_lun,
>  	io_req->fcport =3D fcport;
>  	io_req->cmd_type =3D QEDF_TASK_MGMT_CMD;
>=20
> -	/* Record which cpu this request is associated with */
> -	io_req->cpu =3D smp_processor_id();
> -
>  	/* Set TM flags */
>  	io_req->io_req_flags =3D QEDF_READ;
>  	io_req->data_xfer_len =3D 0;
> @@ -2349,6 +2346,9 @@ static int qedf_execute_tmf(struct qedf_rport
> *fcport, u64 tm_lun,
>=20
>  	spin_lock_irqsave(&fcport->rport_lock, flags);
>=20
> +	/* Record which cpu this request is associated with */
> +	io_req->cpu =3D smp_processor_id();
> +
>  	sqe_idx =3D qedf_get_sqe_idx(fcport);
>  	sqe =3D &fcport->sq[sqe_idx];
>  	memset(sqe, 0, sizeof(struct fcoe_wqe));
> --
> 2.39.3
>=20