Received-SPF: pass (google.com: domain of linux-kernel+bounces-148804-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 17 Apr 2024 18:30:59 +0300
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Zeng Heng <zengheng4@huawei.com>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
	xiexiuqi@huawei.com, linux-gpio@vger.kernel.org,
	weiyongjun1@huawei.com, dan.carpenter@linaro.org,
	liwei391@huawei.com
Subject: Re: [PATCH] pinctrl: devicetree: fix refcount leak in
 pinctrl_dt_to_map()
Message-ID: <Zh_rM04PspfXxlv_@smile.fi.intel.com>
References: <20240415105328.3651441-1-zengheng4@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240415105328.3651441-1-zengheng4@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Mon, Apr 15, 2024 at 06:53:28PM +0800, Zeng Heng wrote:
> If we fail to allocate propname buffer, we need to drop the reference
> count we just took. Because the pinctrl_dt_free_maps() includes the
> droping operation, here we call it directly.

..

>  	for (state = 0; ; state++) {
>  		/* Retrieve the pinctrl-* property */
>  		propname = kasprintf(GFP_KERNEL, "pinctrl-%d", state);
> -		if (!propname)
> -			return -ENOMEM;
> +		if (!propname) {
> +			ret = -ENOMEM;
> +			goto err;
> +		}
>  		prop = of_find_property(np, propname, &size);
>  		kfree(propname);
>  		if (!prop) {
>  			if (state == 0) {
> -				of_node_put(np);
> -				return -ENODEV;
> +				ret = -ENODEV;
> +				goto err;

Has it been tested? How on earth is this a correct change?

We iterate over state numbers until we have properties available. This chunk is
_successful_ exit path, we may not free parsed maps! Am I wrong?

>  			}
>  			break;
>  		}

-- 
With Best Regards,
Andy Shevchenko