Received-SPF: pass (google.com: domain of linux-kernel+bounces-148835-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 17 Apr 2024 18:38:46 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Zeng Heng <zengheng4@huawei.com>, linus.walleij@linaro.org,
	linux-kernel@vger.kernel.org, xiexiuqi@huawei.com,
	linux-gpio@vger.kernel.org, weiyongjun1@huawei.com,
	liwei391@huawei.com
Subject: Re: [PATCH] pinctrl: devicetree: fix refcount leak in
 pinctrl_dt_to_map()
Message-ID: <d80e09d8-5f35-4865-9fe8-195b86527972@moroto.mountain>
References: <20240415105328.3651441-1-zengheng4@huawei.com>
 <Zh_rM04PspfXxlv_@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zh_rM04PspfXxlv_@smile.fi.intel.com>

On Wed, Apr 17, 2024 at 06:30:59PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 15, 2024 at 06:53:28PM +0800, Zeng Heng wrote:
> > If we fail to allocate propname buffer, we need to drop the reference
> > count we just took. Because the pinctrl_dt_free_maps() includes the
> > droping operation, here we call it directly.
> 
> ...
> 
> >  	for (state = 0; ; state++) {
> >  		/* Retrieve the pinctrl-* property */
> >  		propname = kasprintf(GFP_KERNEL, "pinctrl-%d", state);
> > -		if (!propname)
> > -			return -ENOMEM;
> > +		if (!propname) {
> > +			ret = -ENOMEM;
> > +			goto err;
> > +		}
> >  		prop = of_find_property(np, propname, &size);
> >  		kfree(propname);
> >  		if (!prop) {
> >  			if (state == 0) {
> > -				of_node_put(np);
> > -				return -ENODEV;
> > +				ret = -ENODEV;
> > +				goto err;
> 
> Has it been tested? How on earth is this a correct change?
> 
> We iterate over state numbers until we have properties available. This chunk is
> _successful_ exit path, we may not free parsed maps! Am I wrong?

In this path state == 0 so we haven't had a successful iteration yet.

regards,
dan carpenter