Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp723375lqb; Wed, 17 Apr 2024 08:59:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWeLXQ7NUVR6DvLPh7uAtq8U0Je4rxIBW2tdHaByZuqE9+GLh1CJt95THHxSnRtWefbqBa6AGAxlO4dcF0Ew+uEGW9ku1OATvHgiUmACw== X-Google-Smtp-Source: AGHT+IH0EI4CPymPabJWjxEGXUhg6mt17TKvwvJp4ETYV1rCpccaNug2Cc7ud1379lbXz/xBNUCH X-Received: by 2002:ad4:5006:0:b0:691:e21:736c with SMTP id s6-20020ad45006000000b006910e21736cmr15310725qvo.30.1713369577008; Wed, 17 Apr 2024 08:59:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713369576; cv=pass; d=google.com; s=arc-20160816; b=Q4lGzNix1PkANpS9hIt/2u023AogF4smBeMcNOLYPOjoEd3tgvQ8pSPMUNqohwXuj9 nNDTgXgb7uZPXN8Dn9Uwn7YF9Wmsj8R1tTYRAG6bAV2yDTyuxS01nFDHrNGz08U7/Iom yogub6YeYCMfleaJkW3bx7ovhVkzufzNaSbqU8Y/g+WV+klT3XN8iqyLkMz8cNunxEjh SChzxc7ZVZtliq1p7eDtH+4LXKdOOd2XVqz94yQxD8d0hwvYGjWMCymM8iRd+GDHF5/y /MAEgMcwiB/NGlJYHUMIFKnV5a6DdTgpzRTwGUxhR7FZZjUgQKA7gAPOU5YQ16+MjoIa HIqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=47ijCOLBfY/+uBxGULIl3+EdVhDa9SfQa8hgf+yuEFQ=; fh=JuLDFRaIZ5qT1ofDZduWqTVlumgTZvHS8unClDo7AH4=; b=HgI82YmitXxCab158v2Y6tgbD/LOaVBRKtCiKutJYvXyxrJwOkApmxNFTds9lYYY/d rwaVxo/AtbOoQYQyM1Vg9gvnB8wfzt/5gpyE8gsfMxFtn7Rtkr4FYnpHqFO4itCk7EI8 UNdDfCqyNwtm0heGWG2vWfi9+i82BtD6Rko3oj+sg8W/wKGDqperJ4ZFq07LObkSP9x1 0wT6QZGUztYpdGMeDx5VSimZrgbRtaGJJLefp3Huw5AJNRlBjltc2MW1QhYsuF6ylnST sZNnTBirsSU4WMtClEKLjXfnUMWYC3XFJ7OOkHzoPbBns1YKQinQ/nRIpIxRuMqQrv9x q2GA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-148868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148868-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t3-20020a0cef43000000b00699438ef744si14954895qvs.178.2024.04.17.08.59.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 08:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-148868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148868-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B5E381C223AB for ; Wed, 17 Apr 2024 15:59:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2EE6148834; Wed, 17 Apr 2024 15:59:20 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEDB14830C; Wed, 17 Apr 2024 15:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713369560; cv=none; b=BKgbpkgOL8HxXcVRTxHyi9Kl5EMJlZfLAE/eVcWzSRxLgpVJ4GLVXjcq0yk0dU37yO2yAcFmseuew+g9Qe2Mx+i+r96OBIbIKH4L+8TY/gmQoozC5yC6u4oVNcRDtF++oZUjkllZ/5ESbcILfwQ2XsjSu64kyqYm6bDXrDU72eE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713369560; c=relaxed/simple; bh=g8B/qc2nj/2LNEeHjA90kGiWc8nVUDO/Ixkq3MFkruQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fL+H5eC6j9DGVfxAQ0gWSyqhsYE5/gJLIe4U4Euox/EMTSpVCrHjXFPQ4g5sy4nNgFVcS2i0DKu5nOq8mZgcKb/dPBJXI5HZHtHJ8EZF0s6/utfHNh+W4ugev95CYPb0A+TuJHbx8W9CaujaEKiF4IDoHQtJMZEQo4Z7pwmHe4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 12D6068CFE; Wed, 17 Apr 2024 17:59:14 +0200 (CEST) Date: Wed, 17 Apr 2024 17:59:13 +0200 From: Christoph Hellwig To: Lennart Poettering Cc: Christoph Hellwig , Keith Busch , Linux regressions mailing list , linux-block@vger.kernel.org, LKML , Jens Axboe Subject: Re: API break, sysfs "capability" file Message-ID: <20240417155913.GA6447@lst.de> References: <54e3c969-3ee8-40d8-91d9-9b9402001d27@leemhuis.info> <20240409141531.GB21514@lst.de> <20240417151350.GB2167@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Apr 17, 2024 at 05:48:16PM +0200, Lennart Poettering wrote: > Block devices with part scanning off are quite common after all, > i.e. "losetup" creates them by default like that, and partition block > devices themselves have no part scanning on and so on, hence we have > to be ablet to operate sanely with them. Maybe and ioctl to turn on partition scanning if it is currently disabled or return an error otherwise would be the better thing? It would do the right thing for the most common loop case, and with a bit more work could do the right thing for those that more or less disable it graciously (ubiblock, drbd, zram) and would just fail for those who are so grotty old code and slow devices that we never want to do a partition scan (basically old floppy drivers and the Nintendo N64 cartridge driver)