Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp725992lqb; Wed, 17 Apr 2024 09:02:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWQjB/ZtnLVnwnevenkfcU/JdzKvKiRQK6dZKKOUtaMKJRGHNBcqAK3DP0OYnYNVwyx/P6S5gmCfZPTj8OAL4KQdBsl9P5LI+xnjrUqNA== X-Google-Smtp-Source: AGHT+IF9w32wT8NG0A6du134INsOZ5rpJFGKaefnqn6r+pD06Fj0774r9au4PMsGkOenbA0yhePg X-Received: by 2002:a50:a6c4:0:b0:56d:f54a:8765 with SMTP id f4-20020a50a6c4000000b0056df54a8765mr42293edc.23.1713369756936; Wed, 17 Apr 2024 09:02:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713369756; cv=pass; d=google.com; s=arc-20160816; b=isW+2/SH2cJQPaDSVRp48c1V3urPy31lc3k79a14wKy9pYch6FN5bWIqMhjGRHDSE5 +a9h+yK1nUylW7sABaKqNlpjzLdKk8PwO4mb+7g6R6YQ/gL+3hicX/u2DNrU8O9/ua+/ EstliSBAQwbO0W4jQnDGdvCaTUppRAtttc9vaorB8SR+lrmRw+5qAYM3S/LF4nHFFEwo tiwIHjKkSEr5ZwzPJshHDiwUQA2gP8L/MGwu0PdfOWTGJmLQ0rlxeSb8qIGker33IpgH 9CMTQhIczElgBKLPY7fZM5D5qz4qm3Vc3G0I8cw5jAN0oOK3C7V67mP27hpMw0S5Z+Ny dXqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=duSnyQyetpjvea1V2JUBvZV2pmtAi3YKQvIeqHM/O1w=; fh=ryuWwRtNZDBPHZzQ4KTO2cWv5azVFiWZ6VbAa7YcRug=; b=AijFEF6U7uStxHo7j7F6XyYc4/9l4IgLQGvtJhbyYNl2VGE480/UALHtHNvftH1g+K +wtM1Ij1upbDtG/fhhEvMjcI3Fnr5QTjVeG4HjVSElgHlN6o9m0ZuGxHjKWCxNpZPqX3 mUlkEwLfXxUtHGrFW401RGbH9gpnyKp7C5uijmbfCwetel/Dw5vI9OOcS9JIAcTdRnbF xfIu3XTQf8p4kWIVmwiT2B5dhJHegBd5plKCXp6xfgOwPXw98OtkHevxmg5U0zwAQFMx tSgZPOQxZwmRmzbRDEqJ0dEWVXq3CUFigcaTxcMMaevrAIWnLg9hERAnz8TtSyFgV7ip 7hqw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vswq+Ear; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-148871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 25-20020a508e19000000b0056e69cc6b20si6951028edw.267.2024.04.17.09.02.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 09:02:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vswq+Ear; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-148871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 01BF41F22614 for ; Wed, 17 Apr 2024 16:02:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 94B4C1487FF; Wed, 17 Apr 2024 16:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Vswq+Ear" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADBA5148301; Wed, 17 Apr 2024 16:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713369744; cv=none; b=ZBZNwHUbG4JM9M5zbkS8g4w54XDlVZuVhAh3I84kiePOy+LqsLhelUsStuGTMfrJtDdxjWIOFQKdeRp6jkWm3/98ZGK8Y4XHvW31rRhVbWNBdiiGKrhuFUB/P+wr4Ssgr5dWRZuQHt41xFllpJMP0mlNdCPceQZPJ2fMcIQ4x5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713369744; c=relaxed/simple; bh=N0gaK269VcLUzgnmQkKvReoRtlvSOBGBtufEW9856v8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WabV/jyqgz13ECaNEoq8VjHyba5oBR2DLIGuVzCaloBmGgJf+Shdce+uvzNY0ojwYsOZgTEMGhctaUaDMeZRf/SeU6AcNENG4EzqYzuWxFRPM9uw74/S0ci0HBEO3me8E2wN71M0MK6QGqoTn1cetSbW0p7pd6rvIyqx2+yjEPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Vswq+Ear; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFCFCC072AA; Wed, 17 Apr 2024 16:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713369744; bh=N0gaK269VcLUzgnmQkKvReoRtlvSOBGBtufEW9856v8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Vswq+Ear/MtlBUrDm5iAR3C8HvUZeTLGtrwEOqLXZDdFVqSRjkissURJdm5HyxvIQ Utsde5/FF9IS0xhn36xOtBwOWhbL6iHlunEDeYWVsPaNI6AMKpB91hlrBKUy4ZijYi Gk9qDrPHuJxw94YbZlCk8letmSGCJqhSfl23mcJGy5g74NHXfd9YEfwEmjs43kW9/c SBRfX9NY8M5cdZkRlwR6HLSJq5NIBHk/yh9rDP7HmwF3zLDvKNjIPUpnY8mneaFYH2 +xICRi1PzypdmFw3cZ4gazHB5CFHKM6VZUuacLfKDAXFoJJIRFTUGXnizdN2Kh0OHE Mysp8ph/uroBw== Message-ID: <1fe62eb1-8ad5-4ced-9349-258cee9de663@kernel.org> Date: Wed, 17 Apr 2024 18:02:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] virt: vmgenid: add support for devicetree bindings To: "Jason A. Donenfeld" , sudanl@amazon.com, Krzysztof Kozlowski Cc: tytso@mit.edu, olivia@selenic.com, herbert@gondor.apana.org.au, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, graf@amazon.de, xmarcalx@amazon.co.uk, dwmw@amazon.co.uk, Alexander Graf , Babis Chalios References: <20240417104046.27253-1-bchalios@amazon.es> <20240417104046.27253-6-bchalios@amazon.es> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/04/2024 17:16, Jason A. Donenfeld wrote: >> +static irqreturn_t >> +vmgenid_of_irq_handler(int __always_unused irq, void *dev) >> +{ >> + vmgenid_notify(dev); >> + >> + return IRQ_HANDLED; >> +} > > Is there a reason the of code isn't conditional on CONFIG_OF? I'm not > super familiar with these drivers, but this seems like it would be a > thing to do, and then we could do `depends on OF || ACPI` in the > Kconfig. > Usually we do not recommend hiding code behind !CONFIG_OF because this limits possible usage on ACPI systems via PRP0001. Not sure if it is applicable here, because there is already ACPI matching. I would suggest choose whatever makes code simpler... Or just mark some pieces with __maybe_unused if they are really not used? That would avoid ifdeffery. Best regards, Krzysztof