Received-SPF: pass (google.com: domain of linux-kernel+bounces-148889-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 17 Apr 2024 17:14:05 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Kairui Song <kasong@tencent.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	"Huang, Ying" <ying.huang@intel.com>, Chris Li <chrisl@kernel.org>,
	Barry Song <v-songbaohua@oppo.com>,
	Ryan Roberts <ryan.roberts@arm.com>, Neil Brown <neilb@suse.de>,
	Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>,
	David Hildenbrand <david@redhat.com>,
	Yosry Ahmed <yosryahmed@google.com>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Ryusuke Konishi <konishi.ryusuke@gmail.com>,
	linux-nilfs@vger.kernel.org
Subject: Re: [PATCH 2/8] nilfs2: drop usage of page_index
Message-ID: <Zh_1TdrwJcBeALIG@casper.infradead.org>
References: <20240417160842.76665-1-ryncsn@gmail.com>
 <20240417160842.76665-3-ryncsn@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417160842.76665-3-ryncsn@gmail.com>

On Thu, Apr 18, 2024 at 12:08:36AM +0800, Kairui Song wrote:
> +++ b/fs/nilfs2/bmap.c
> @@ -453,8 +453,7 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap,
>  	struct buffer_head *pbh;
>  	__u64 key;
>  
> -	key = page_index(bh->b_page) << (PAGE_SHIFT -
> -					 bmap->b_inode->i_blkbits);
> +	key = bh->b_page->index << (PAGE_SHIFT - bmap->b_inode->i_blkbits);

I'd prefer this were

	key = bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_blkbits);

(pages only have a ->index field for historical reasons; I'm trying to
get rid of it)