Received-SPF: pass (google.com: domain of linux-kernel+bounces-148919-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 17 Apr 2024 22:05:34 +0530
From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: <andersson@kernel.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
        <konrad.dybcio@linaro.org>, <djakov@kernel.org>,
        <quic_anusha@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v8 2/7] clk: qcom: cbf-msm8996: Specify master and slave
 id
Message-ID: <Zh/6Vj2cl+WP4T34@hu-varada-blr.qualcomm.com>
References: <20240417105605.836705-1-quic_varada@quicinc.com>
 <20240417105605.836705-3-quic_varada@quicinc.com>
 <CAA8EJpqaXU=H6Nhz2_WTYHS1A0bi1QrMdp7Y+s6HUELioCzbeg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAA8EJpqaXU=H6Nhz2_WTYHS1A0bi1QrMdp7Y+s6HUELioCzbeg@mail.gmail.com>

On Wed, Apr 17, 2024 at 02:26:36PM +0300, Dmitry Baryshkov wrote:
> On Wed, 17 Apr 2024 at 13:56, Varadarajan Narayanan
> <quic_varada@quicinc.com> wrote:
> >
> > The icc-clk driver has been changed to take master and slave id
> > from the caller instead of auto-generating them. Update
> > clk-cbf-8996 accordingly.
>
> This should be squashed into the previous patch. Otherwise the driver
> is broken between two commits.

Ok. Will squash and post a new one.

Thanks
Varada
>
> >
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> >  drivers/clk/qcom/clk-cbf-8996.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/qcom/clk-cbf-8996.c b/drivers/clk/qcom/clk-cbf-8996.c
> > index fe24b4abeab4..a077d4403967 100644
> > --- a/drivers/clk/qcom/clk-cbf-8996.c
> > +++ b/drivers/clk/qcom/clk-cbf-8996.c
> > @@ -237,7 +237,12 @@ static int qcom_msm8996_cbf_icc_register(struct platform_device *pdev, struct cl
> >         struct device *dev = &pdev->dev;
> >         struct clk *clk = devm_clk_hw_get_clk(dev, cbf_hw, "cbf");
> >         const struct icc_clk_data data[] = {
> > -               { .clk = clk, .name = "cbf", },
> > +               {
> > +                       .clk = clk,
> > +                       .name = "cbf",
> > +                       .master_id = MASTER_CBF_M4M,
> > +                       .slave_id = SLAVE_CBF_M4M,
> > +               },
> >         };
> >         struct icc_provider *provider;
> >
> > --
> > 2.34.1
> >
>
>
> --
> With best wishes
> Dmitry