Received-SPF: pass (google.com: domain of linux-kernel+bounces-148986-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 17 Apr 2024 22:51:09 +0530
From: Vinod Koul <vkoul@kernel.org>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: Michal Simek <michal.simek@amd.com>, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: zynqmp_dma: rework tasklet to threaded
 interrupt handler
Message-ID: <ZiAFBaZLbQ8yj-dn@matsya>
References: <20240226-zynqmp-dma-tasklet-irqthread-v1-1-2d154d6238fd@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240226-zynqmp-dma-tasklet-irqthread-v1-1-2d154d6238fd@pengutronix.de>

On 26-02-24, 23:17, Michael Grzeschik wrote:
> Since the tasklets are being scheduled with low priority the actual work
> will be delayed for unseen time. Also this is a driver that probably
> other drivers depend on its work to be done early. So we move the
> actual work from an tasklet to an threaded interrupt handler and
> therefor increase the priority for the scheduler.

The tasklet have higer priority than threaded handler! So this should
worsen the performance.

Btw there is work to move away from tasklet by Allen, so this is no
longer valid now

> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
>  drivers/dma/xilinx/zynqmp_dma.c | 36 +++++++++++-------------------------
>  1 file changed, 11 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index f31631bef961a..09173ef6d24bc 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -204,7 +204,6 @@ struct zynqmp_dma_desc_sw {
>   * @dev: The dma device
>   * @irq: Channel IRQ
>   * @is_dmacoherent: Tells whether dma operations are coherent or not
> - * @tasklet: Cleanup work after irq
>   * @idle : Channel status;
>   * @desc_size: Size of the low level descriptor
>   * @err: Channel has errors
> @@ -228,7 +227,6 @@ struct zynqmp_dma_chan {
>  	struct device *dev;
>  	int irq;
>  	bool is_dmacoherent;
> -	struct tasklet_struct tasklet;
>  	bool idle;
>  	size_t desc_size;
>  	bool err;
> @@ -724,8 +722,7 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data)
>  
>  	writel(isr, chan->regs + ZYNQMP_DMA_ISR);
>  	if (status & ZYNQMP_DMA_INT_DONE) {
> -		tasklet_schedule(&chan->tasklet);
> -		ret = IRQ_HANDLED;
> +		ret = IRQ_WAKE_THREAD;
>  	}
>  
>  	if (status & ZYNQMP_DMA_DONE)
> @@ -733,9 +730,8 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data)
>  
>  	if (status & ZYNQMP_DMA_INT_ERR) {
>  		chan->err = true;
> -		tasklet_schedule(&chan->tasklet);
>  		dev_err(chan->dev, "Channel %p has errors\n", chan);
> -		ret = IRQ_HANDLED;
> +		ret = IRQ_WAKE_THREAD;
>  	}
>  
>  	if (status & ZYNQMP_DMA_INT_OVRFL) {
> @@ -748,19 +744,20 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data)
>  }
>  
>  /**
> - * zynqmp_dma_do_tasklet - Schedule completion tasklet
> + * zynqmp_dma_irq_thread - Interrupt thread function
>   * @t: Pointer to the ZynqMP DMA channel structure
>   */
> -static void zynqmp_dma_do_tasklet(struct tasklet_struct *t)
> +static irqreturn_t zynqmp_dma_irq_thread(int irq, void *data)
>  {
> -	struct zynqmp_dma_chan *chan = from_tasklet(chan, t, tasklet);
> +	struct zynqmp_dma_chan *chan = (struct zynqmp_dma_chan *)data;
>  	u32 count;
>  	unsigned long irqflags;
>  
>  	if (chan->err) {
>  		zynqmp_dma_reset(chan);
>  		chan->err = false;
> -		return;
> +
> +		return IRQ_HANDLED;
>  	}
>  
>  	spin_lock_irqsave(&chan->lock, irqflags);
> @@ -778,6 +775,8 @@ static void zynqmp_dma_do_tasklet(struct tasklet_struct *t)
>  		zynqmp_dma_start_transfer(chan);
>  		spin_unlock_irqrestore(&chan->lock, irqflags);
>  	}
> +
> +	return IRQ_HANDLED;
>  }
>  
>  /**
> @@ -796,17 +795,6 @@ static int zynqmp_dma_device_terminate_all(struct dma_chan *dchan)
>  	return 0;
>  }
>  
> -/**
> - * zynqmp_dma_synchronize - Synchronizes the termination of a transfers to the current context.
> - * @dchan: DMA channel pointer
> - */
> -static void zynqmp_dma_synchronize(struct dma_chan *dchan)
> -{
> -	struct zynqmp_dma_chan *chan = to_chan(dchan);
> -
> -	tasklet_kill(&chan->tasklet);
> -}
> -
>  /**
>   * zynqmp_dma_prep_memcpy - prepare descriptors for memcpy transaction
>   * @dchan: DMA channel
> @@ -876,7 +864,6 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_chan *chan)
>  
>  	if (chan->irq)
>  		devm_free_irq(chan->zdev->dev, chan->irq, chan);
> -	tasklet_kill(&chan->tasklet);
>  	list_del(&chan->common.device_node);
>  }
>  
> @@ -921,7 +908,6 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev,
>  
>  	chan->is_dmacoherent =  of_property_read_bool(node, "dma-coherent");
>  	zdev->chan = chan;
> -	tasklet_setup(&chan->tasklet, zynqmp_dma_do_tasklet);
>  	spin_lock_init(&chan->lock);
>  	INIT_LIST_HEAD(&chan->active_list);
>  	INIT_LIST_HEAD(&chan->pending_list);
> @@ -936,7 +922,8 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev,
>  	chan->irq = platform_get_irq(pdev, 0);
>  	if (chan->irq < 0)
>  		return -ENXIO;
> -	err = devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0,
> +	err = devm_request_threaded_irq(&pdev->dev, chan->irq,
> +			       zynqmp_dma_irq_handler, zynqmp_dma_irq_thread, 0,
>  			       "zynqmp-dma", chan);
>  	if (err)
>  		return err;
> @@ -1071,7 +1058,6 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>  	p = &zdev->common;
>  	p->device_prep_dma_memcpy = zynqmp_dma_prep_memcpy;
>  	p->device_terminate_all = zynqmp_dma_device_terminate_all;
> -	p->device_synchronize = zynqmp_dma_synchronize;
>  	p->device_issue_pending = zynqmp_dma_issue_pending;
>  	p->device_alloc_chan_resources = zynqmp_dma_alloc_chan_resources;
>  	p->device_free_chan_resources = zynqmp_dma_free_chan_resources;
> 
> ---
> base-commit: d206a76d7d2726f3b096037f2079ce0bd3ba329b
> change-id: 20240226-zynqmp-dma-tasklet-irqthread-1540cfe2a1c2
> 
> Best regards,
> -- 
> Michael Grzeschik <m.grzeschik@pengutronix.de>

-- 
~Vinod