Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756220AbYAYGfi (ORCPT ); Fri, 25 Jan 2008 01:35:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753253AbYAYGf2 (ORCPT ); Fri, 25 Jan 2008 01:35:28 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:53104 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbYAYGf1 (ORCPT ); Fri, 25 Jan 2008 01:35:27 -0500 From: Junio C Hamano To: Mathieu Segaud Subject: Re: [PATCH] Convert ext4_ioctl to an unlocked_ioctl References: <1201007375-27914-1-git-send-email-mathieu.segaud@regala.cx> <1201007375-27914-2-git-send-email-mathieu.segaud@regala.cx> cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sct@redhat.com, Mathieu Segaud Date: Thu, 24 Jan 2008 22:35:16 -0800 In-Reply-To: <1201007375-27914-2-git-send-email-mathieu.segaud@regala.cx> (Mathieu Segaud's message of "Tue, 22 Jan 2008 14:09:34 +0100") Message-ID: <7vir1i76qj.fsf@gitster.siamese.dyndns.org> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 30 Mathieu Segaud writes: > Signed-off-by: Mathieu Segaud > --- > fs/ext4/dir.c | 2 +- > fs/ext4/file.c | 2 +- > fs/ext4/ioctl.c | 161 ++++++++++++++++++++++++++++++++--------------- > include/linux/ext4_fs.h | 3 +- > 4 files changed, 112 insertions(+), 56 deletions(-) > > diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c > index f612bef..8f6677a 100644 > --- a/fs/ext4/dir.c > +++ b/fs/ext4/dir.c > @@ -42,7 +42,7 @@ const struct file_operations ext4_dir_operations = { > .llseek = generic_file_llseek, > .read = generic_read_dir, > .readdir = ext4_readdir, /* we take BKL. needed?*/ > - .ioctl = ext4_ioctl, /* BKL held */ > + .unlocked_ioctl = ext4_ioctl, /* BKL held */ Wasn't the purpose of this whole exercise to eventually allow them to be outside BKL? IOW, don't you want to drop this comment for the .unlocked_ioctl member of this struct? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/