Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp791753lqb; Wed, 17 Apr 2024 10:45:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVQ7pgka2hjkJVK8wC53qjfLXU9lqkZBeXdghndkCekMrilt5CjBCu+LLdbuU4O/jAwHmbpMV/lw3lbVOqc0/WyLRIRoHfItct8afA8bQ== X-Google-Smtp-Source: AGHT+IHD/oL03HqbOzoKtI5RoJMT43bdNBeGjEmffp1jtjeEQOKyEoQmcBZ91RHEhNK7X8jV3+rF X-Received: by 2002:a05:6a20:7f9d:b0:1a7:a353:939e with SMTP id d29-20020a056a207f9d00b001a7a353939emr400540pzj.56.1713375915572; Wed, 17 Apr 2024 10:45:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713375915; cv=pass; d=google.com; s=arc-20160816; b=kQlOC1xMNgAa4x9TtKFmmLDbRg7uk5SPoycwSGLITYb3GFzXEEcdnKFNiHchHxH1Gi M0uGLxk6goc1R1QTwtoGNwaVNJcmKiFYkYA4HqjJJOXWrXGAjaskWD4PKOw18VCKCnQL FJ68Pn/AA4aJascEZM4HTA+ulX31LqWn3zwJZW0QenUbWdMcf7t9akzcDwC57lXa0sGt +rF3BpCf4EtXjEAzgkUgusczCRBalZC0HwlXDmmHwkQx4UGQAP6NJzJyY+NH2nTbDtEm E20/WUuM21txb82npowD89LUawsX14O8rhSOaabFVyEQwKyQ6rsxO8kZbafxLSHODOMj gYYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=toEBTn8aaSZLzUtIz/kYknL89fCkK0qhGmev/yRoGDU=; fh=657XdiZqujU5QNvGWRroc7QAcPYNK3ko6oneZRcQO4o=; b=0olbKAQ0tzIe19JZ2fHaWfMsQPFeQkZpaGFv3Th/G2cKnHasvkNV23NlA6HtFcKHKH igg5E5mmEnDQiMMgeqcDL1ESTg4CH195ufMfwf0AJnYv8Rx3wuJqOrcMHGVCSTHY5Dhj 28A0pwGxhE5y+Knx6VSATUDxvOzq169aEUFUvLPMd6SNT520k43438x9F/FM21tl/NxM 9mP+HcukjJwjS9PCxGNDJTYo43kwOE+jURc+AeOSMr2kGUOG7cN6WyN8NajG8DMmCzCK bSI7hbgn+XvPOqhfPALZWD+bLjHdrlAUqRReGRqW3NynfdAGtKEs0ubEvOzFXhZet6j9 7eTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RnRu13Cx; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-148989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148989-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s10-20020a63f04a000000b005b8ebaa2937si11746852pgj.47.2024.04.17.10.45.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 10:45:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RnRu13Cx; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-148989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148989-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6D03DB215B2 for ; Wed, 17 Apr 2024 17:25:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AFADF17167A; Wed, 17 Apr 2024 17:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RnRu13Cx" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82EEF13C8E9 for ; Wed, 17 Apr 2024 17:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713374736; cv=none; b=uoSv9F5Uoa5wQhQiKsdIZp25KE0lY65CFXLvnvhnmN0gtjVV4sdoLHy7GlyJ9cUBu6ZBzhq1Nn35gX5KKrmgazA8IY080agEuE2VchzRAXG5o+od1kWR36tO+B9HUW+/EV1CRLu2MTp7Pj5whHc8hvHBrhyh1u6j/Mp42obtrm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713374736; c=relaxed/simple; bh=e7Q4tzzD5T1qboSq/qS8wfRObZ8HqxfKgatjrFZzMHI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aDMMG3l7sgLpnjAg4/Vu8sLQDSkedVwEOPDl9cAm4ver2xmHTvY1d297U2MtqZ4FndAhsMkCrHU5g5GlSDVsUsjuqhCQQOJ4kQLdrkngsuo5ceqSev4GPlIn/s/Ok6ojrxIqbIg4aWaesl7gg7qF0jlroJICMwxOJGzcTDVAsWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RnRu13Cx; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713374735; x=1744910735; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=e7Q4tzzD5T1qboSq/qS8wfRObZ8HqxfKgatjrFZzMHI=; b=RnRu13CxJydsooRcAaIU0zQ1Sf8Jtlyp4xvNkU1YJZlc0FsNu5Q0JLXK zIpMCAOT4rShcoIdRyc5JgMt2fNteXiaiSo+P2Semr+eVab+WlLkzwz53 b0IagXFfKP4fTBYFQIC9XlJHOaD9cTYF4mGZ+MVHXRck8IxJMsRGVml62 DrBsjdXfGgP4CL6DKflTT5RIjmUEt0siV+thWws1aaa0Wtl+AD50ytgza 1VqSZlxSXQHX3lSK9KZ2qQ4HkHeNFW5niTFc2icHlm//5fHcX2RO5Vubl d6CQd5dU9csvMcZVSRKMocq8bwPkhb80YNC1iAM4s/JlfcPj8TLEqc6pb Q==; X-CSE-ConnectionGUID: 2Ek73tr3QpujlEtCjNubuQ== X-CSE-MsgGUID: 4niexhLtQWmBur5moyRY1g== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="34279682" X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="34279682" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 10:25:34 -0700 X-CSE-ConnectionGUID: nobW79SzTMqsIUH77frd8Q== X-CSE-MsgGUID: 9ya+JCG+REWrNrPx4JeZQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="22738911" Received: from kevinlic-mobl1.amr.corp.intel.com (HELO [10.209.38.146]) ([10.209.38.146]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 10:25:34 -0700 Message-ID: <399bbc9d-ae75-4754-8ce9-af563df15a38@intel.com> Date: Wed, 17 Apr 2024 10:25:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/2] x86/mm: Don't disable PCID if the kernel is running on a hypervisor To: Pawan Gupta , Sean Christopherson Cc: Xi Ruoyao , Dave Hansen , Michael Kelley , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Andrew Cooper References: <20240413044129.52812-1-xry111@xry111.site> <20240413044129.52812-2-xry111@xry111.site> <20240417172222.f4h2csf4xkffccqn@desk> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240417172222.f4h2csf4xkffccqn@desk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/17/24 10:22, Pawan Gupta wrote: >>> static const struct x86_cpu_id invlpg_miss_ids[] = { >>> + /* Only bare-metal is affected. PCIDs in guests are OK. */ >>> + { >>> + .vendor = X86_VENDOR_INTEL, >>> + .family = 6, >>> + .model = INTEL_FAM6_ANY, >>> + .feature = X86_FEATURE_HYPERVISOR, >> Isn't this inverted? x86_match_cpu() will return NULL if the CPU doesn't have >> HYPERVISOR. We want it to return NULL if the CPU *does* have HYPERVISOR. > I think the implementation is correct, x86_match_cpu() will not return > NULL if the CPU doesn't have HYPERVISOR feature *and* matches one of the > CPUs below. It will only return NULL if none of the entries match. I think I gave a crappy suggestion here. Let's just do the X86_FEATURE_HYPERVISOR explicitly in the code instead of trying to cram it into the invlpg_miss_ids[] check. It's way easier to understand with an explicit code check.