Received-SPF: pass (google.com: domain of linux-kernel+bounces-149001-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 17 Apr 2024 10:36:59 -0700
From: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
To: Jarred White <jarredwhite@linux.microsoft.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Easwar Hariharan <eahariha@linux.microsoft.com>, "open list:ACPI" <linux-acpi@vger.kernel.org>, 
	open list <linux-kernel@vger.kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] ACPI: CPPC: Fix bit_offset shift in MASK_VAL macro
Message-ID: <soawdod6cpcc73wrc35bvnah5toubf2cv4x7c3e6p53xtvllrs@6dtpn2v5t3di>
References: <20240409052310.3162495-1-jarredwhite@linux.microsoft.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20240409052310.3162495-1-jarredwhite@linux.microsoft.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?sknGvFRqWMNWVgZSPIL6ryZ9l8mk4IR765YvXeF2pBMPasUQ/Um0G/U2kt2X?=
 =?us-ascii?Q?wLk6xWEwwL2Rug1yYJwfOxU/8AzJQfyUiCgACXPm6zqQWjuyVnuRjWAYWgLH?=
 =?us-ascii?Q?UwrKADkuWLg/x0jZA+711r2emGJjDq7O0nwkhdMEN+HE44+v1JLsrmvqYF8O?=
 =?us-ascii?Q?1fXS4cbCWsWDAIAE8XgjC693yl9IbtghirAZqwldtwjDwEnJRKOOID/umn7i?=
 =?us-ascii?Q?zqPk7k6gOYHaOuLksJFdmZPdaJvnA9CGmFc5fhKgC823fz40lBZRlzLU1zmu?=
 =?us-ascii?Q?rcMpIl3LiBJpciey8SDFYrhEfuyEYbKrS4206l7FzZvdvYe1s2MCmRFiLWl9?=
 =?us-ascii?Q?FzX/iyZH57gDEKXhZzGXrV8/DIlkpdE469S298oGwv0ijhHg9I4eTzXALrBu?=
 =?us-ascii?Q?VhwJmPI5XS7+mFkf21Lu1/hGJK9pwuSPesFS4AjJB9YpsOQhzJtB9CyzNJ/H?=
 =?us-ascii?Q?QPWqNdt/fbS7L64tI7/4Uxhl4kV5CZnCyrGAHLnmT7ygevHXewNgo5luT765?=
 =?us-ascii?Q?nmDPdWt4ypzMiBzY4DrEdnP3VGBreyAEVn16GisXw7Kp1+Abb7yCoCr85nID?=
 =?us-ascii?Q?YrWzM7XGxrqL8l3IqGcZYEi5dXrkYOnGFSToRpMGbsr1Pa+rtpbRV6FY8Rws?=
 =?us-ascii?Q?gZgKmp3Kh2BfPrRGrfn5mvC/jlRNiNDn8wvtLVQpDj4ZFLLDeB9erIKT5mDX?=
 =?us-ascii?Q?9/InRpjDra+lU+0NiTx0IK/CInpuwoYI+EuBpEfhU6vjipSmMvS2xEm//dAc?=
 =?us-ascii?Q?kVApaWHWgAZmen/JjYTa8WauHNETYjmw5m/5Yly7TjTOU9Aczadfo4hoExS+?=
 =?us-ascii?Q?YYxhziv1uTxJFA36GGSD05Lz9FHRUvjuZpuSlNsULJfJxZdMwJNJSsi3qcCa?=
 =?us-ascii?Q?8EO73vNx1NmgGezwBGGumKvEidxkOz/02GMWBbcIJoGRmTYZEbX7PaJJJEx4?=
 =?us-ascii?Q?KQYJjN2SYKxsUT72MSACFDPsodDr4NLP50niZgFkaXBeg+pG4/Wq8omNDh7v?=
 =?us-ascii?Q?ubcjazibiV7zwooH173U4lxow0SqpZO8sl7/xBGAdE6Kw638SbU5N5asTkZS?=
 =?us-ascii?Q?1v44GjKoVWOE9wbjogWxHW2m57nOIltSEv9EfWSIZfoA7OoFu3FQTr/EMpFX?=
 =?us-ascii?Q?OCvugl0RZqGkMPbKtEGX+6TFnhYFPhe8O60WEhAAZ95paCYQAzBfFvjenr4u?=
 =?us-ascii?Q?cUSWReIF81hbACgzQF8aC+3z/hrH8FL+RzaBmFXnkpxQ4iprUnpxUs0bSIgO?=
 =?us-ascii?Q?dJvLhrZr9ahQUeUXRvEVBsZZs/cbQvNeR8bt2ME3KWJCiiv+8nFgU6Xuw8bM?=
 =?us-ascii?Q?k4f/e/hCTO8E6gPA4rO23d1YajP5twlBBpQY6W3LkLAZ6Iy7ouX06xWUL9xI?=
 =?us-ascii?Q?x7noS1gxsJMs1l5u207zUuARlvpcSHDpBJ8WGCgI2nY4yZ4WsHl+qvfOTGGd?=
 =?us-ascii?Q?EWemukfMW/Tn4n0K77iQnNk7N2RRnsQsaqOHjsNMj5iIwbdLFHtHvaHLL6ie?=
 =?us-ascii?Q?WneDiKadh7vgDJs8heLkl8y8Yr+Rx7e5Ql9o2JgAKQch78QYfIerrZIOkPsA?=
 =?us-ascii?Q?+lpoftziWbBjllWX/Jaautt0UiyvHSsXRB18gCZoUeWl+sj9jWqjuxn7PdeQ?=
 =?us-ascii?Q?PESTfIIQLOknV7kszM14rpI=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 759274e5-3049-495c-9752-08dc5f04ff14
X-MS-Exchange-CrossTenant-AuthSource: MW4PR01MB6498.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 17:37:04.5650
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SPFCSdnouax2LiXzW/0IsebW04FpR2YB0eouN3jg3amO+PMENHTeWV2/QYHdpDJJAb84Tli51pd6v6kCYZP4od6s8w0BhsU6WtD1aQl2ljLQDB0tcKIIJruU78eoIfoJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR01MB8672

Looks good to me.

Reviewed-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>

On Mon, Apr 08, 2024 at 10:23:09PM -0700, Jarred White wrote:
>Commit 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for
>system memory accesses") neglected to properly wrap the bit_offset shift
>when it comes to applying the mask. This may cause incorrect values to be
>read and may cause the cpufreq module not be loaded.
>
>[   11.059751] cpu_capacity: CPU0 missing/invalid highest performance.
>[   11.066005] cpu_capacity: partial information: fallback to 1024 for all CPUs
>
>Also, corrected the bitmask generation in GENMASK (extra bit being added).
>
>Fixes: 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for system memory accesses")
>Signed-off-by: Jarred White <jarredwhite@linux.microsoft.com>
>CC: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
>CC: stable@vger.kernel.org #5.15+
>---
> drivers/acpi/cppc_acpi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>index 4bfbe55553f4..00a30ca35e78 100644
>--- a/drivers/acpi/cppc_acpi.c
>+++ b/drivers/acpi/cppc_acpi.c
>@@ -170,8 +170,8 @@ show_cppc_data(cppc_get_perf_ctrs, cppc_perf_fb_ctrs, wraparound_time);
> #define GET_BIT_WIDTH(reg) ((reg)->access_width ? (8 << ((reg)->access_width - 1)) : (reg)->bit_width)
>
> /* Shift and apply the mask for CPC reads/writes */
>-#define MASK_VAL(reg, val) ((val) >> ((reg)->bit_offset & 			\
>-					GENMASK(((reg)->bit_width), 0)))
>+#define MASK_VAL(reg, val) (((val) >> (reg)->bit_offset) & 			\
>+					GENMASK(((reg)->bit_width) - 1, 0))
>
> static ssize_t show_feedback_ctrs(struct kobject *kobj,
> 		struct kobj_attribute *attr, char *buf)
>-- 
>2.33.8
>