Received-SPF: pass (google.com: domain of linux-kernel+bounces-149054-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 17 Apr 2024 14:29:50 -0400
From: Frank Li <Frank.li@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes
Message-ID: <ZiAVHosJAtrK6LRf@lizhi-Precision-Tower-5810>
References: <20240415-dts_8qm_audio-v1-0-2976c35a0c52@nxp.com>
 <20240415-dts_8qm_audio-v1-2-2976c35a0c52@nxp.com>
 <20240416065026.GA4165@francesco-nb>
 <Zh/yZ2HyF+G8bty7@lizhi-Precision-Tower-5810>
 <20240417172031.GA4100@francesco-nb>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417172031.GA4100@francesco-nb>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?xFmQvex55OiUdnpgmI6nUCJdb+dzgY6g1U75JC4ny0xUH5bJECwEDFZfTpGX?=
 =?us-ascii?Q?cXfpe0prLPiExYpIGvh8mle5IjkP1icZlwHYnfUu+srh527zDmw8u+6VnHHJ?=
 =?us-ascii?Q?srUkT+WxxmtyItlTzxbPZj/0oosboXEqOOpzoetMa2cPwIfvTnLUNE8pEaiI?=
 =?us-ascii?Q?DQkv1F0dvP6JSZwtWYo7mtNPzzhdoTfKRj7tMvsOpAwPN3UJrIl3fFuVMSJN?=
 =?us-ascii?Q?VkjxjJjlt1Pae8YGx46pLXgav6RaOuSu38cmKUkll/MlfjUNDGJadYBlLIK/?=
 =?us-ascii?Q?MzvZzGi2Zw945GGuTL7U9IkqdBJx0qg5aiFev5+pnC7Qg++kevJbZN/Hxhxu?=
 =?us-ascii?Q?3LSWjIWZH4EuCLRpiKrkfttw+z+1VKKpUozM1Wo3DDuKowaF1Hz3PYbTFBYi?=
 =?us-ascii?Q?4ncS2Esubjee/TYQbiTBLMcht2SSwi0CmhrpT/hbg4ZRf7IolsY4wcB0GwEC?=
 =?us-ascii?Q?yNBzeckb7V32MHezKQwsKeBaA/0BS8bzAUPCHqU66BQ15m8QQlR40RUE/WZK?=
 =?us-ascii?Q?NZilvxC9sbJ4puM0CEJgzrMzz8n7RvVwabuja/r5WRcmVj8ojFczPZB2Q/vj?=
 =?us-ascii?Q?T/85BdOSOge5kaJouOTuHln8Uiura94bq7I2moZgAoWiAVgyA3cU6wEk42So?=
 =?us-ascii?Q?1/jZewCPdcQGWoDI+8RR4LCxj3GGlwns85bw7GG/ENT37GnTFsnQjnLNO/nN?=
 =?us-ascii?Q?suTUddcsxX19r4rWTCl+AMVgfYdprjPJWOZ6xMKB4POIX9Ctqt5i/bJiDLzw?=
 =?us-ascii?Q?dPepDJcDhB7VbwsONWCb7/+JgNNjxqITeanljnJ3G8ZJHvhwcq6v6Vfyj1Ox?=
 =?us-ascii?Q?cTIyqEMw6qwfx8kDbYXtI+KaWfzOdJ45pjNsKuXW7owWUQzSY0G1ZPlwgXRm?=
 =?us-ascii?Q?ScrQkQcLo9gyWiO/pd2z/OIApSK2ARNcS2ovK3VKY5Fo4Fomjt0+fPKKwxgr?=
 =?us-ascii?Q?XoraObxQUJMdD+Pvdhs1ePOYCszvQwMnNETOHDf3AlBiWIlKh+EYKbu+ckYz?=
 =?us-ascii?Q?5sOTUnOk07o5UNSjegKa7kVUnQ8MGF0MLeoNq2j52B3g6/IDZ+NULs8RTKHh?=
 =?us-ascii?Q?sO5ZSMFgfy3aEZtfQu+ITf8U2Oda3n5aXG+BTyzYDkevheaW26Y+7JjDO0Ck?=
 =?us-ascii?Q?Zl2dylfyefgpp0ogzdtJA3FM9B+dD60McGPloChzk40phQy+zISrT+lpRAuZ?=
 =?us-ascii?Q?dnvFJIatBuUJWISiX3Cs+Ic2VfjWqU/s6GEtoNBAPwy29+8EUHxFtUhsNCds?=
 =?us-ascii?Q?GY4gx6KKSkEPSOW5VeLz4UOYEKU5sVy/z2MiUMW1vp93/dUJUfBEI3fwglmb?=
 =?us-ascii?Q?Bg6/N5WVPrLOBIjPWjYKgVyokTPrLNySupAr+GY08APhTl94mP8Jvv+QSvuC?=
 =?us-ascii?Q?58QOzJNTWw/SMCxBWTJgwacm4gGh+A+jcGSLaL9FYjystDHQtwGQ4uEQFnMW?=
 =?us-ascii?Q?ObLlgnNGZzMtEEiTfs8iiUBVqp8f1hEHOSc/RwriytG04+B5S3NXuZcU1iPO?=
 =?us-ascii?Q?fynnebVmRY/RmslmN+BFydqdNqcPqV/e9W9eUULrSh8St5gjApohoKMwmJuE?=
 =?us-ascii?Q?a0INvOLEeVQrAiHGXG/2XLA4FBIuPwMdMM7VJwKB?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5a5328-e7a5-4c5c-b985-08dc5f0c6287
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 18:29:57.9399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T4oBnx7xc47IFp0oen0T1Xb8l/0qBXXlK0Pq97S465vkLErHlKM+U8ek5LUZz7irNzSV4vTZnqpwR/Ix91FtFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6805

On Wed, Apr 17, 2024 at 07:20:31PM +0200, Francesco Dolcini wrote:
> Hello Frank,
> 
> On Wed, Apr 17, 2024 at 12:01:43PM -0400, Frank Li wrote:
> > On Tue, Apr 16, 2024 at 08:50:26AM +0200, Francesco Dolcini wrote:
> > > On Mon, Apr 15, 2024 at 03:46:38PM -0400, Frank Li wrote:
> > > > Add i.MX8QM audio related nodes and update eDMA[0,1]'s information.
> > > > 
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi | 473 +++++++++++++++++++++
> > > >  arch/arm64/boot/dts/freescale/imx8qm.dtsi          |  86 ++++
> > > >  2 files changed, 559 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> > > > new file mode 100644
> > > > index 0000000000000..ed5a1b4af1d76
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> 
> ...
> 
> > > > +/delete-node/ &acm;
> > > > +/delete-node/ &sai4;
> > > > +/delete-node/ &sai5;
> > > > +/delete-node/ &sai4_lpcg;
> > > > +/delete-node/ &sai5_lpcg;
> > > 
> > > Can you explain these delete-node ? This is something that I would
> > > expect when a dtsi is previously included, not in this case.
> > 
> > We want to avoid some property inherent from parent dtsi file because it is
> > big difference with common one.
> > 
> > This node will be rewrite totally in this files.
> 
> imx8qm-ss-audio.dtsi does not include any file. From where these
> inherited properties are coming from? Which file is the "parent dtsi" ?

imx8qm-ss-audio.dtsi are not supposed to be included directly. imx8qm.dtsi
is supposed to be included by other board dts file.

in imx8qm.dtsi

 	/* sorted in register address */
+	#include "imx8-ss-audio.dtsi"
 	#include "imx8-ss-vpu.dtsi"
 	#include "imx8-ss-img.dtsi"
 	#include "imx8-ss-dma.dtsi"
@@ -473,3 +558,4 @@ drc_crit0: trip1 {
 #include "imx8qm-ss-dma.dtsi"
 #include "imx8qm-ss-conn.dtsi"
 #include "imx8qm-ss-lsio.dtsi"
+#include "imx8qm-ss-audio.dtsi"

"imx8qm-ss-audio" will overwrite some common audio node in
"imx8-ss-audio.dtsi"

acm, and sai4/5 are defined in imx8-ss-audio.dtsi for common part for all
imx8qm\imx8qxp\imx8dxl.

Frank

> 
> Thanks,
> Francesco
>