Received-SPF: pass (google.com: domain of linux-kernel+bounces-149090-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <0000000000009db84e0615a73698@google.com> <20240409164627.b4803e09c81c01ccb6f55601@linux-foundation.org>
 <CAAa6QmQ-fSNHu0VWQod+Cz89zOtQ9Ayet_2OEQsrp2zeCfos3A@mail.gmail.com> <CAAa6QmS6Kw_E5wfabE1Sg8WHUXYYWsUo9e2KQNo-OiQVRDk-Ag@mail.gmail.com>
In-Reply-To: <CAAa6QmS6Kw_E5wfabE1Sg8WHUXYYWsUo9e2KQNo-OiQVRDk-Ag@mail.gmail.com>
From: "Zach O'Keefe" <zokeefe@google.com>
Date: Wed, 17 Apr 2024 11:56:09 -0700
Message-ID: <CAAa6QmSu+Z6riu=asD3L0MFXXgPm1fCUgO549CcTdQrK=xUkkg@mail.gmail.com>
Subject: Re: [syzbot] [mm?] general protection fault in hpage_collapse_scan_file
To: Andrew Morton <akpm@linux-foundation.org>
Cc: syzbot <syzbot+57adb2a4b9d206521bc2@syzkaller.appspotmail.com>, 
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
	syzkaller-bugs@googlegroups.com, Matthew Wilcox <willy@infradead.org>, 
	Hugh Dickins <hughd@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 4:07=E2=80=AFPM Zach O'Keefe <zokeefe@google.com> w=
rote:
>
> On Tue, Apr 9, 2024 at 5:32=E2=80=AFPM Zach O'Keefe <zokeefe@google.com> =
wrote:
> >
> > On Tue, Apr 9, 2024 at 4:46=E2=80=AFPM Andrew Morton <akpm@linux-founda=
tion.org> wrote:
> > >
> > > On Tue, 09 Apr 2024 03:16:20 -0700 syzbot <syzbot+57adb2a4b9d206521bc=
2@syzkaller.appspotmail.com> wrote:
> > >
> > > > Hello,
> > > >
> > > > syzbot found the following issue on:
> > > >
> > > > HEAD commit:    8568bb2ccc27 Add linux-next specific files for 2024=
0405
> > > > git tree:       linux-next
> > > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=3D152f480=
5180000
> > > > kernel config:  https://syzkaller.appspot.com/x/.config?x=3D48ca5ac=
f8d2eb3bc
> > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D57adb2a4b=
9d206521bc2
> > > > compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils f=
or Debian) 2.40
> > > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D12682=
58d180000
> > > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D1256598=
d180000
> > >
> > > Help.  From a quick look this seems to be claiming that collapse_file=
()
> > > got to
> > >
> > >         VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
> > >
> > > with folio=3D=3DNULL, but the code look solid regarding this.
> > >
> > > Given that we have a reproducer, can we expect the bot to perform a
> > > bisection for us?
> > >
> >
> > I often don't see a successful automatic bisect, even with
> > reproducers. Hit or miss. I will take a closer look tomorrow -- the
> > reproducer doesn't look to be doing anything crazy.
>
> I've only been able to reproduce this using the disk image provided by sy=
zbot.
>
> What is happening is we are calling MADV_COLLAPSE on an empty mapping
> -- which actually reaches collapse_file() -> filemap_lock_folio()
> after page_cache_sync_readahead() attempt. This of course fails
> correctly, and I can see right before GPF that the returned pointer is
> 0xfffffffffffffffe, which is correctly ERR_PTR(-ENOENT). This should
> be causing us to take the if (IS_ERR(folio)) {..} path .. but we
> don't, and I don't know why. I haven't yet attempted to repro this
> against other images. Will continue looking, but wanted to provide
> some type of update -- even if it is a disappointing one -- so as to
> not appear like I've disappeared.

Ugh. Was looking at the wrong source. Thanks hughd@ for mentioning
that IS_ERR(folio) changed recently, else I'd have spent more time on
it. Fixed by https://lore.kernel.org/all/ZhIWX8K0E2tSyMSr@casper.infradead.=
org/

> Thanks,
> Zach
>
> > Thanks,
> > Zach