Received-SPF: pass (google.com: domain of linux-kernel+bounces-149177-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
 Chen-Yu Tsai <wens@csie.org>, Samuel Holland <samuel@sholland.org>,
 John Watts <contact@jookia.org>
Cc: linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
 kernel test robot <lkp@intel.com>, John Watts <contact@jookia.org>
Subject:
 Re: [PATCH] ASoC: sunxi: sun4i-i2s: Fix pcm_formats type specification
Date: Wed, 17 Apr 2024 22:27:36 +0200
Message-ID: <1928580.taCxCBeP46@jernej-laptop>
In-Reply-To: <20240417-sunxi_s32_fix-v1-1-d82e451565c0@jookia.org>
References: <20240417-sunxi_s32_fix-v1-1-d82e451565c0@jookia.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"

Dne sreda, 17. april 2024 ob 07:14:43 GMT +2 je John Watts napisal(a):
> pcm_formats should be a u64 as it is a SNDRV_PCM_FMTBIT_* not a
> SNDRV_PCM_FORMAT_*.
> 
> Also fix a small grammar error while we're here.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404170103.ySYwieqi-lkp@intel.com/
> Signed-off-by: John Watts <contact@jookia.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
> This is a quick fix for a type error found by the kernel test robot.
> ---
>  sound/soc/sunxi/sun4i-i2s.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
> index 59830f2a0d30..5f8d979585b6 100644
> --- a/sound/soc/sunxi/sun4i-i2s.c
> +++ b/sound/soc/sunxi/sun4i-i2s.c
> @@ -156,7 +156,7 @@ struct sun4i_i2s;
>  /**
>   * struct sun4i_i2s_quirks - Differences between SoC variants.
>   * @has_reset: SoC needs reset deasserted.
> - * @pcm_formats: available PCM formats
> + * @pcm_formats: available PCM formats.
>   * @reg_offset_txdata: offset of the tx fifo.
>   * @sun4i_i2s_regmap: regmap config to use.
>   * @field_clkdiv_mclk_en: regmap field to enable mclk output.
> @@ -176,7 +176,7 @@ struct sun4i_i2s;
>   */
>  struct sun4i_i2s_quirks {
>  	bool				has_reset;
> -	snd_pcm_format_t		pcm_formats;
> +	u64				pcm_formats;
>  	unsigned int			reg_offset_txdata;	/* TX FIFO */
>  	const struct regmap_config	*sun4i_i2s_regmap;
>  
> 
> ---
> base-commit: 66e4190e92ce0e4a50b2f6be0e5f5b2e47e072f4
> change-id: 20240417-sunxi_s32_fix-ef5354b40fb4
> 
> Best regards,
>