Received-SPF: pass (google.com: domain of linux-kernel+bounces-147690-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 17 Apr 2024 00:29:06 +0200
From: Christian Heusel <christian@heusel.eu>
To: Nhat Pham <nphamcs@gmail.com>
Cc: Seth Jennings <sjenning@redhat.com>, Dan Streetman <ddstreet@ieee.org>, 
	Vitaly Wool <vitaly.wool@konsulko.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, David Runge <dave@sleepmap.de>, 
	"Richard W.M. Jones" <rjones@redhat.com>, Mark W <instruform@gmail.com>, regressions@lists.linux.dev, 
	Johannes Weiner <hannes@cmpxchg.org>, Yosry Ahmed <yosryahmed@google.com>, 
	Chengming Zhou <chengming.zhou@linux.dev>
Subject: Re: [REGRESSION] Null pointer dereference while shrinking zswap
Message-ID: <u4tzik2yfdn4eqtb2xc7ssmqsfozjblduu4znwuhlptivcfhza@wkvjsi73dtqt>
References: <3iccc6vjl5gminut3lvpl4va2lbnsgku5ei2d7ylftoofy3n2v@gcfdvtsq6dx2>
 <CAKEwX=MZ3jTVpN4g-qrhTn2b0i0C6_M=8BtKt9KEPyFHb+4W2w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="5czpi4g6eex7fcrz"
Content-Disposition: inline
In-Reply-To: <CAKEwX=MZ3jTVpN4g-qrhTn2b0i0C6_M=8BtKt9KEPyFHb+4W2w@mail.gmail.com>
UI-OutboundReport: notjunk:1;M01:P0:JTJsWm0H3nw=;IIKW3gMDzvjWMZIDGn60yl7s01D
 I14nwLf8N7tGNLzIdX0A1JO0saZSf9wo0TDOH2ObsXKMmg4ycreuaajIwWD3EXXkFRhC6RY4U
 EA7obFuyu4qd4pfPeT7iN3CZY3KfLTDgljXI1qIWEq3QW8+rRpdaPq1wF4VE2HVp9/BOSX6RK
 3lIMYMZOX2E39ZlA1/PKhGWXvP4STHjigazOraT7B63NHgP005XprzjIa7eJg+iCynj+kdFA7
 dPI9ANlCYVnrZck7iQ9BbxdRuL/t/hiR2qu7FNxmTxmtqhgXcE9zHE3XCfcBmke7Gte+Zx3/Y
 uvrBY1SAviLT1I+ZavRSrEz5rGQqHw6j9D7/ZJStLkMPgcr+7tcIu/rxeT8aNJQ23fenvqAjP
 NWZMoAFjtT2plfoVYiAHJwQnwCXYVJOSclqbYpjCcwc+U5Aux1FuCMbNAOD6j25nlJ0kbXxkf
 BgmD7/r6DbJ4pmVe7jiGEFM+yTNEuo52gZQrH6QY1WJlG33IMHXM8BjGo/yjuxmzT+TJYpE0Y
 +zi4+4o5TcuE7RvFwZKLbBnlvXXEq4+3YnuayOgCJNw/7IsgyVM0IolFGxF6haSwn/UvrCh4I
 j4LX2LpgGqU0tGYxtWX5JNfdx41x/m+S4bh4t6VSj0U66Dju3eBf3WQgGfUUR2C+eAgT/Z2l/
 UNeW/pBx5duKBgR24I2J1dlV3ij+XS6aIYrv/aq1uKynHDCGJQTyw8LeF/W7tz461RQB4QfZr
 0ZK2VV+Xg2G3eZA/Bod807sqdkyosJAup3oqSd10e9wi6nnwjlZTHY=


--5czpi4g6eex7fcrz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On 24/04/16 03:14PM, Nhat Pham wrote:
> Is this one of the kernel versions that was broken? That looks a bit
> odd, as zswap shrinker landed on 6.8...

Yes that is the build at commit b5ba474f3f51 ("zswap: shrink zswap pool
based on memory pressure") which is one of the kernel versions that is
broken, although the version string seems a bit confusing. This is due
to the build script invoking "make -s kernelrelease" which gives the
following:

  $ git checkout b5ba474f3f51
  [...]
  $ make -s kernelrelease
  6.7.0-rc4-00158-gb5ba474f3f51

The commit is contained in v6.8+ only as you say, so its just confusing
in the version string:

  $ git tag --contains b5ba474f3f51 | grep -v next
  v6.8
  v6.8-rc1
  v6.8-rc2
  v6.8-rc3
  v6.8-rc4
  v6.8-rc5
  v6.8-rc6
  v6.8-rc7
  v6.9-rc1
  v6.9-rc2
  v6.9-rc3
  v6.9-rc4

Please see my initial report for the detailed bisection results and the
link there to the bisection log.

Cheers and thanks for looking into this!
Christian

--5czpi4g6eex7fcrz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb3ea3iR6a4oPcswTwEfU8yi1JYUFAmYe+7IACgkQwEfU8yi1
JYWS8RAAgarbioWmeY1qe9WCWZ+xmvQgbhyrqN5NNM2/hlM/Wv1K5bcdpNC0VZM8
YNnmmc8vQuXupu47pMKpMGFwCr6v8ztGgBs2A1kr/8Q4ESTFx0owXrgsgWOqcUsm
PBVg/t8vwpHv1fWKM2Mf3/3tyJorggozCMluDArAsNyz5kFlMcsRVBkfVOVtqASW
OR2kXl7B55YavHMgM7IPfQO0/Dr4/67NzWt2TCJMm1Mi+0GnJAglKt6wQUf4567g
K2NPsuvbuwOGSKoEUQqfGYFadVtTac3RlDQ+4gw0HWR2Hs1/XBpdHOyLsOWhip9g
KomaPpcJr305uXZAzQCediwPzrULHnvAZ+5o8SzNGOSqz3GMo6YaUuRuf5TWE9Wl
Jp8yLkbOdIPDcQ7g+reEfwLXqyc4jMWzoeINImN7BbPcLq/oj8fqQXuVFoF4jajo
/Qpl8U14ZLwsk/6VxwOy0VPRf4wkfC0njZNR19auU4090Q3ZLS9oY3IwzULOH57o
6yrQFUv1Jpjk+lf6cddwiCK0LCdvS3/ugtMv2H1HUdmdeqqQ2mUFPDunW06WuUns
C69ojDexsqdATdr0dmC+7OK7qs+IQUzd6Izi8510CGhE8CzM7DGH3iNcNDU0VL4h
ED27FWmDBlJ0neF5uCSCyuCdPyVKCA+XQ6rQCtFescGuZC9cSTI=
=xoCM
-----END PGP SIGNATURE-----

--5czpi4g6eex7fcrz--