Received-SPF: pass (google.com: domain of linux-kernel+bounces-149213-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240417204012.215030-1-helgaas@kernel.org> <20240417204012.215030-2-helgaas@kernel.org>
In-Reply-To: <20240417204012.215030-2-helgaas@kernel.org>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 17 Apr 2024 23:47:27 +0300
Message-ID: <CAHp75Vd58Z1X05YMa_03eZi48h2kY9q+0v8ymscQ2-HdU33tHw@mail.gmail.com>
Subject: Re: [PATCH 1/1] x86/pci: Skip early E820 check for ECAM region
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Mateusz Kaduk <mateusz.kaduk@gmail.com>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, Tj <linux@iam.tj>, 
	Hans de Goede <hdegoede@redhat.com>, x86@kernel.org, linux-kernel@vger.kernel.org, 
	Bjorn Helgaas <bhelgaas@google.com>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 17, 2024 at 11:40=E2=80=AFPM Bjorn Helgaas <helgaas@kernel.org>=
 wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Arul, Mateusz, Imcarneiro91, and Aman reported a regression caused by
> 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map").  On the
> Lenovo Legion 9i laptop, that commit removes the area containing ECAM fro=
m
> E820, which means the early E820 validation started failing, which meant =
we
> didn't enable ECAM in the "early MCFG" path
>
> The lack of ECAM caused many ACPI methods to fail, resulting in the
> embedded controller, PS/2, audio, trackpad, and battery devices not being
> detected.  The _OSC method also failed, so Linux could not take control o=
f
> the PCIe hotplug, PME, and AER features:
>
>   # pci_mmcfg_early_init()
>
>   PCI: ECAM [mem 0xc0000000-0xce0fffff] (base 0xc0000000) for domain 0000=
 [bus 00-e0]
>   PCI: not using ECAM ([mem 0xc0000000-0xce0fffff] not reserved)
>
>   ACPI Error: AE_ERROR, Returned by Handler for [PCI_Config] (20230628/ev=
region-300)
>   ACPI: Interpreter enabled
>   ACPI: Ignoring error and continuing table load
>   ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PC00.RP01._SB.PC0=
0], AE_NOT_FOUND (20230628/dswload2-162)
>   ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20230628/psobject=
-220)
>   ACPI: Skipping parse of AML opcode: OpcodeName unavailable (0x0010)
>   ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PC00.RP01._SB.PC0=
0], AE_NOT_FOUND (20230628/dswload2-162)
>   ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20230628/psobject=
-220)
>   ...
>   ACPI Error: Aborting method \_SB.PC00._OSC due to previous error (AE_NO=
T_FOUND) (20230628/psparse-529)
>   acpi PNP0A08:00: _OSC: platform retains control of PCIe features (AE_NO=
T_FOUND)
>
>   # pci_mmcfg_late_init()
>
>   PCI: ECAM [mem 0xc0000000-0xce0fffff] (base 0xc0000000) for domain 0000=
 [bus 00-e0]
>   PCI: [Firmware Info]: ECAM [mem 0xc0000000-0xce0fffff] not reserved in =
ACPI motherboard resources
>   PCI: ECAM [mem 0xc0000000-0xce0fffff] is EfiMemoryMappedIO; assuming va=
lid
>   PCI: ECAM [mem 0xc0000000-0xce0fffff] reserved to work around lack of A=
CPI motherboard _CRS
>
> Per PCI Firmware r3.3, sec 4.1.2, ECAM space must be reserved by a PNP0C0=
2
> resource, but it need not be mentioned in E820, so we shouldn't look at
> E820 to validate the ECAM space described by MCFG.
>
> 946f2ee5c731 ("[PATCH] i386/x86-64: Check that MCFG points to an e820
> reserved area") added a sanity check of E820 to work around buggy MCFG
> tables, but that over-aggressive validation causes failures like this one=
.
>
> Keep the E820 validation check only for older BIOSes (pre-2016) so the
> buggy 2006-era machines don't break.  Skip the early E820 check for 2016
> and newer BIOSes.

> Fixes: 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map")
> Reported-by: Mateusz Kaduk <mateusz.kaduk@gmail.com>

> Reported-by: Arul <...>
> Reported-by: Imcarneiro91 <...>
> Reported-by: Aman <...>

Isn't bugzilla public enough? You may take emails from there, no?

..

> +               /*
> +                * 946f2ee5c731 ("Check that MCFG points to an e820
> +                * reserved area") added this E820 check in 2006 to work
> +                * around BIOS defects.
> +                *
> +                * Per PCI Firmware r3.3, sec 4.1.2, ECAM space must be
> +                * reserved by a PNP0C02 resource, but it need not be
> +                * mentioned in E820.  Before the ACPI interpreter is
> +                * available, we can't check for PNP0C02 resources, so
> +                * there's no reliable way to verify the region in this
> +                * early check.  Keep it only for the old machines that
> +                * motivated 946f2ee5c731.
> +                */

> +               if (dmi_get_bios_year() < 2016 && raw_pci_ops)

I probably missed something, but where does 2016 come from?
(I've been following the bz discussion)

> +                       return is_mmconf_reserved(e820__mapped_all, cfg, =
dev,
> +                                                 "E820 entry");
> +
> +               return true;
> +       }

..

>         if (pci_mmcfg_running_state)
>                 return true;
>
> -       /* Don't try to do this check unless configuration
> -          type 1 is available. how about type 2 ?*/
> -       if (raw_pci_ops)
> -               return is_mmconf_reserved(e820__mapped_all, cfg, dev,
> -                                         "E820 entry");
> -
>         return false;

Not strictly related to this patch, but now it can simply

  return pci_mmcfg_running_state;


In any case, LGTM,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

--=20
With Best Regards,
Andy Shevchenko