Received-SPF: pass (google.com: domain of linux-kernel+bounces-149214-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240417141914.2905621-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240417141914.2905621-1-andriy.shevchenko@linux.intel.com>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Wed, 17 Apr 2024 22:48:42 +0200
Message-ID: <CAMRc=McqBBFEHksn70wraWy2Oh20Scur6KQzRvhuKr=ja-_sRw@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] gpiolib: swnode: Remove wrong header inclusion
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Linus Walleij <linus.walleij@linaro.org>, Charles Keepax <ckeepax@opensource.cirrus.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 17, 2024 at 4:19=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The flags in the software node properties are supposed to be
> the GPIO lookup flags, which are provided by gpio/machine.h,
> as the software nodes are the kernel internal thing and doesn't
> need to rely to any of ABIs.
>
> Fixes: e7f9ff5dc90c ("gpiolib: add support for software nodes")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/linux/gpio/property.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/gpio/property.h b/include/linux/gpio/property.=
h
> index 6c75c8bd44a0..1a14e239221f 100644
> --- a/include/linux/gpio/property.h
> +++ b/include/linux/gpio/property.h
> @@ -2,7 +2,6 @@
>  #ifndef __LINUX_GPIO_PROPERTY_H
>  #define __LINUX_GPIO_PROPERTY_H
>
> -#include <dt-bindings/gpio/gpio.h> /* for GPIO_* flags */
>  #include <linux/property.h>
>
>  #define PROPERTY_ENTRY_GPIO(_name_, _chip_node_, _idx_, _flags_) \
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>

Applied, thanks!

Bart