Received-SPF: pass (google.com: domain of linux-kernel+bounces-149284-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240413-tcp-ao-selftests-fixes-v1-0-f9c41c96949d@gmail.com>
 <20240416072809.3ae7c3d3@kernel.org> <CAJwJo6Yw4S1wCcimRVy=P8h0Ez0UDt-yw2jqSY-ph3TKsQVVGA@mail.gmail.com>
 <20240417134636.102f0120@kernel.org> <20240417142843.27a221f8@kernel.org>
In-Reply-To: <20240417142843.27a221f8@kernel.org>
From: Dmitry Safonov <0x7f454c46@gmail.com>
Date: Wed, 17 Apr 2024 23:30:29 +0100
Message-ID: <CAJwJo6agHEsWjhNzAstwU_+kQd4er3QsNZebkCOCDGBGh4SiMQ@mail.gmail.com>
Subject: Re: [PATCH net 0/4] selftests/net/tcp_ao: A bunch of fixes for TCP-AO selftests
To: Jakub Kicinski <kuba@kernel.org>
Cc: Dmitry Safonov via B4 Relay <devnull+0x7f454c46.gmail.com@kernel.org>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, netdev@vger.kernel.org, 
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Wed, 17 Apr 2024 at 22:28, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 17 Apr 2024 13:46:36 -0700 Jakub Kicinski wrote:
> > > I can spend some time on them after I verify that my fix for -stable
> > > is actually fixing an issue I think it fixes.
> > > Seems like your automation + my selftests are giving some fruits, hehe.
> >
> > Oh, very interesting, I don't recall these coming up before.
>
> Correction, these are old, and if I plug the branch names here:
> https://netdev.bots.linux.dev/contest.html
> there is a whole bunch of tests failing that day.

Hmm, yeah, I was looking at the history of selftests to see if there
is anything else interesting:

2024-04-11--15-00 - lockdep for hashinfo->ehash_locks vs tw->tw_timer

It seems that you actually reported that already here:
https://lore.kernel.org/all/20240411100536.224fa1e7@kernel.org/

2024-04-04--12-00 - lockdep for p->alloc_lock vs ul->lock
(rt6_uncached_list_flush_dev)
2024-04-04--09-00 - lockdep for p->alloc_lock vs ndev->lock
(addrconf_permanent_addr)
2024-04-04--03-00 - lockdep for p->alloc_lock vs ul->lock

Was reported as well:
https://lore.kernel.org/all/8576a80ac958812ac75b01299c2de3a6485f84a1.camel@redhat.com/

2024-03-06--00-00 - kernel BUG at net/core/skbuff.c:2813

Can't really track this down to any report/fix. Probably as it's month
old and hasn't happened since on these tests - something was borken on
that particular day.

> Keep in mind these run pre-commit so not all failures are flakes.

Thanks,
             Dmitry