Received-SPF: pass (google.com: domain of linux-kernel+bounces-149295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <80c56417-3d74-7d68-1228-9cd944567b4e@amd.com>
Date: Wed, 17 Apr 2024 17:52:18 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 17/17] x86/resctrl: Introduce interface to modify
 assignment states of the groups
Content-Language: en-US
To: Peter Newman <peternewman@google.com>, babu.moger@amd.com
Cc: corbet@lwn.net, fenghua.yu@intel.com, reinette.chatre@intel.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 paulmck@kernel.org, rdunlap@infradead.org, tj@kernel.org,
 peterz@infradead.org, yanjiewtw@gmail.com, kim.phillips@amd.com,
 lukas.bulwahn@gmail.com, seanjc@google.com, jmattson@google.com,
 leitao@debian.org, jpoimboe@kernel.org, rick.p.edgecombe@intel.com,
 kirill.shutemov@linux.intel.com, jithu.joseph@intel.com,
 kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com,
 james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <f7dac996d87b4144e4c786178a7fd3d218eaebe8.1711674410.git.babu.moger@amd.com>
 <CALPaoCihU+mat2A-wNtTm=qbpya8ZqhDURsfZfjuHitch0WrLA@mail.gmail.com>
 <9d59d38b-af1a-46d8-81c4-b426d47d4ed6@amd.com>
 <CALPaoCgFEybS5MhsPx4EaJmsfBe8Es_6QwWBXpoctdaNf0NcMQ@mail.gmail.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <CALPaoCgFEybS5MhsPx4EaJmsfBe8Es_6QwWBXpoctdaNf0NcMQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cE9FcEd5MDcrOUZyMGZta1VtTE9LRzduWTdyVjd6QkJGZGhPMWVna3F3akxB?=
 =?utf-8?B?R21UMmM5RExISmphckVHOXNockVtb3h6dVk5c0FUOWRycTd3bnRlOW5ZajFU?=
 =?utf-8?B?ZE11dU5KRWovS3lHWDJMeVNQenV6YXpRTFN1aXBobm9PM2FGVDZyK2ZBRGt0?=
 =?utf-8?B?cGZaRXNEZy9NNW9MVFNMSUVqbzJldUdRT0xqd3hPb3BuNnFreFFiY0U3Q1Zt?=
 =?utf-8?B?Y0VEbmxxeEN3ZWREcTM0bWljdXRSL092N0Y3c2diZkZvQUhUanJYdUtXTDdD?=
 =?utf-8?B?aXJmcVkwN29Zd2lLRWx3Y29rQUxxTU9HdDd2MzA3dXI3OVAxdzgxdUorYkIx?=
 =?utf-8?B?RHk3VGpram9KTDNlTEorRU84UHpKazRyMEZYQytVYzA2dXNpR3BKanlFd2Np?=
 =?utf-8?B?anNXclFLMFU3MmJBblkvTFh2WktPUzdxZFhVZzlOcThscWNnSUlqdk9HMjBZ?=
 =?utf-8?B?Y1dmRXM0TU5lclUvOUZLYkRzUWhRbWVLV2t1UkhtRHgrZUZIVHhBYS9Qcno3?=
 =?utf-8?B?bndQbm4yY0pQeUc2Z2lEcVBqL1lVNjAwNVlHWEhUQ0VzN3lLSVZCVW95Tk5z?=
 =?utf-8?B?Ri9NcFRDM1FQdTVaczF5RDZINDllOWp4K2grTmxBQTBRd1c4anVZZmppd041?=
 =?utf-8?B?R1k5cVNYU1lSQUZ0eEhnZmNtUDgrdkFiTzMyeDNSVU02MjJmUGRkNEczT0JM?=
 =?utf-8?B?Nzc3QUkyeE0wRDR4Zm94MDhVaWNBRFRBY0dLMXhQank5bU1jSVZtc3lxRzhQ?=
 =?utf-8?B?Y3ZPdWdUODlsNE1lYmpySFJ2ZllWTFFBZmF3SE5UMVg2NTg3Z0hRMTFNWWlW?=
 =?utf-8?B?eHJRNmIwTnNBTVZWa04yTjFuTlFwMi9lblFna0hiRVo1Z1dUNmkrK3l4N3Bs?=
 =?utf-8?B?bGsyTDdmeWt5MjRJVEFKZmFOVG5KTjlxeGsvcjRST1B1eEhzVERMSkgvWWlj?=
 =?utf-8?B?K2Jka3ROSStPVmJSelFoM0VhRUR6eDVTQTNqaUw0OThtQUJReWM3TzloUVg0?=
 =?utf-8?B?Wm1BVVVqWExJR1NtNm1JeGNmTjZqVXVrRVVIZWlSQUlxeng1Y1pVUmdxNkk1?=
 =?utf-8?B?bzhLeU5mN3BjLzM2Nmp5ZE1PT1lkbDd6QTJvR09TZ2VJSTJkT2g0R1VVdFhD?=
 =?utf-8?B?bjBmMzI0bGVEWjJQOUUvWnBWeVd2L3NibmE5aWw2dnViSEV5QTF2SURFdExK?=
 =?utf-8?B?UWJIUS9LSGRGSmd5bHFxRU1EZzZDSzhyVDF2WGE5WjAyR0gzOEVZMDB0bXJE?=
 =?utf-8?B?OXkvWkFkUlJqdG9Xd2J2azM1TitNS3JhQ1NJT3BJcm5FOEZnRnVFMlRVZ1NQ?=
 =?utf-8?B?UDZrbTQvNWwxRXAvUUtKRmFhenk5MGI5bWFydmpoN3VtVjBSTkMyd1d0MVRy?=
 =?utf-8?B?UGU4aldqMlRvTTJmRVZNUkZsTktEWjFnTStZRmtBSFd1VU5EcWF5Q1lWbkh3?=
 =?utf-8?B?QzI1ajF6blVXejZZaVFnMkVhS2tsQzdsanFjWWJyVDJRcEI3K2ZTRzZhcEZU?=
 =?utf-8?B?WkpzQjZueDRwb0ZMSE1kQmNnUFdLQjJkalFlN1pXeThnU2ZaNW96UXdXTDlI?=
 =?utf-8?B?azlnVGlEeUpSbW1HNjFBSDRWbU1qUDd6eFl3N2huT2V6S2JycHp0SXBPcGVP?=
 =?utf-8?B?NFhtRlhRalMrSzRJbktwc0ZrdHI4bVQrQ0padEYxalFPRWtRMjJnRUplM2VJ?=
 =?utf-8?B?VEYxbUtGYXVoQ25aTmhDVXhNV09LamcrdWhlSWU4L05LZWZDWFNwOHZOa0x5?=
 =?utf-8?B?bEhMckYycm1VdllDNFUxTHpDRmUyV2Q0bkZ6dUhUUkxlMlNSM0Jjc0pMa0JS?=
 =?utf-8?B?QnlLZUpSaG4wRTUyTTRpcXlQUnA0RnlNYzhnWlZBRUExTUFZR3J0T3o3enEv?=
 =?utf-8?B?MitFeks4ZlBFVGhldlFaRDJHbm9yd0VnSHNzajZmZTcvdGJSUi9LaDNBVjlB?=
 =?utf-8?B?OTFnNmFvU09uN2dPSFNhZUxCaEJlTmJiUmxSUCtvc3F0THo5SDR3Z1JlTWNj?=
 =?utf-8?B?NGpwcHAxT24yb2ZTZzVTcjNDalFXR1hNZTllVDBLZERYOFVkZThHUURGU2lj?=
 =?utf-8?B?M0tLVlg2VU15VTBpQXZ4UlBMSGg1dlQ0U1JSNHZsOUd0YlZDQjBBc3hWSmxi?=
 =?utf-8?Q?bDmoBrDUmpgPwAVZOOxYSboyh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52b85099-bf99-4bd6-ba0b-08dc5f310c9e
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 22:52:25.1015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 56eMDw3xolp9YNCDWp1iO7wvEYG5jfknghgPh6tNQ1D3LbCK7SxwzdYBUt7T5Rpf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8736

Hi Peter,

On 4/17/2024 3:56 PM, Peter Newman wrote:
> Hi Babu,
>
> On Wed, Apr 17, 2024 at 12:39 PM Moger, Babu <babu.moger@amd.com> wrote:
>> On 4/17/24 12:45, Peter Newman wrote:
>>> On Thu, Mar 28, 2024 at 6:10 PM Babu Moger <babu.moger@amd.com> wrote:
>>>> diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
>>>> index 2d96565501ab..64ec70637c66 100644
>>>> --- a/Documentation/arch/x86/resctrl.rst
>>>> +++ b/Documentation/arch/x86/resctrl.rst
>>>> @@ -328,6 +328,77 @@ with the following files:
>>>>           None of events are assigned on this mon group. This is a child
>>>>           monitor group of the non default control mon group.
>>>>
>>>> +       Assignment state can be updated by writing to this interface.
>>>> +
>>>> +       NOTE: Assignment on one domain applied on all the domains. User can
>>>> +       pass one valid domain and assignment will be updated on all the
>>>> +       available domains.
>>> How would different assignments to different domains work? If the
>>> allocations are global, then the allocated monitor ID is available to
>>> all domains whether they use it or not.
>> That is correct.
>> [A] Hardware counters(max 2 per group) are allocated at the group level.
>> So, those counters are available to all the domains on that group. I will
>> maintain a bitmap at the domain level. The bitmap will be set on the
>> domains where assignment is applied and IPIs are sent. IPIs will not be
>> sent to other domains.
> Unless the monitor allocation is scoped at the domain level, I don't
> see much point in implementing the per-domain parsing today, as the
> only benefit is avoiding IPIs to domains whose counters you don't plan
> to read.

In that case lets remove the domain specific assignments. We can avoid 
some code complexity.

thanks

Babu