Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp960283lqb; Wed, 17 Apr 2024 16:42:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXtWjCQMrfXjwfKI8a5u6lomZVg6bw6NEYWB4Bkn+pVWlMtn3kyzgv14JUiKILhayu9oj+J0G8LcFzgth8sYCWliFDXDYOM8Gdsg58JYQ== X-Google-Smtp-Source: AGHT+IGpqjc0vCRKXemzOikCjWhqIaTSbD/NWE+xyrleIdQtvqsbUUYm/bEHpp/yXKeSLO4nO/kp X-Received: by 2002:a05:6a00:4fcc:b0:6ea:c5cc:f4d with SMTP id le12-20020a056a004fcc00b006eac5cc0f4dmr1320518pfb.11.1713397342226; Wed, 17 Apr 2024 16:42:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713397342; cv=pass; d=google.com; s=arc-20160816; b=KuFPYvAeDPvAGG2rFsy2+nDiQggofPQA+mAAIQitqAgK1cw6tdigDRIGE3+FjFT0zj 9kDM/G3EVTv5CDCU3JjJvaogp/JMagdWVNTzRu15A9GCCn268AIPJ85t2jUTISHE/cAJ hwd66B/aK3RtTVAIwmwvfwGn7/xeH+Eq/9IOCHYovDtxKqVzE5B/mm3mZF/GoWW0Ead9 x2nzLdVNiwpElVJhqQ7b7Wti4Z0LqZmVqXF0cNScy912IZOV81qfZ2P21Cmq02dzRCP2 Tx6s6CyTZ6U6F3fRSs/Tonn3tWq/X5xxUKhMyLnXL3jCamwakPExxL9oUzrbLpf8G0RA iApw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=d/AzyoJNXW+kEe+3Im15qH+BP+LWLSajKmHbYzbPun0=; fh=go916bBtrZoxVfjdD82TcaiN1Di9H785jV1W9lh2Qgo=; b=OAWA4xD3mx59aX5UxR8IBwZJztkxD8rV3H+snRcS/ogHKG6LkzwP+Wk0JYHzT8fATv 4/zb9Qc12EJh0VSPwfOClql8LTb/nfrdIyoVSXTdBGn9uhZC/NODWai6Ja9+OovBHeTS ioTZrswUp/GlwBOQjnhifsrjUa3QYUjnGehluxFNTVw8sOni5JZ9hyktC57XJFf6z6vJ JGvEERqNghu2yNE/taaBCYuF1JUcfgCmGWyx1ITX1sFytjmcoE39mx2BkEalXDwRQv9F +TRNNv6P4Qc+JhVfDkdqivKUCSdwzam27xkSr7PBEVXbchBtFgtbl54fxBTrUDZsXrD8 nP3A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=JbP2WTgy; arc=pass (i=1 spf=pass spfdomain=codeconstruct.com.au dkim=pass dkdomain=codeconstruct.com.au dmarc=pass fromdomain=codeconstruct.com.au); spf=pass (google.com: domain of linux-kernel+bounces-149324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id c9-20020a634e09000000b005f3d2aa58d2si234990pgb.712.2024.04.17.16.42.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 16:42:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-149324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=JbP2WTgy; arc=pass (i=1 spf=pass spfdomain=codeconstruct.com.au dkim=pass dkdomain=codeconstruct.com.au dmarc=pass fromdomain=codeconstruct.com.au); spf=pass (google.com: domain of linux-kernel+bounces-149324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D04B6282B77 for ; Wed, 17 Apr 2024 23:42:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DD6E714884C; Wed, 17 Apr 2024 23:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="JbP2WTgy" Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF4B881748 for ; Wed, 17 Apr 2024 23:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713397319; cv=none; b=BJGmqG2RB4dd5PYDFycI9rZrtnCbu/JKXoJqfjw9oGKnDP8zrNJ5YBNte58DG6hhbqRYCResve3atQbfaSzfkFQwjrOvcaglKbqEfefPw/1/ELVbr1au2r2LNwczDsOWpYcssioCI2RRhH4dpGCPcYshVDXXDIfVD+TEj7+Tnko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713397319; c=relaxed/simple; bh=d/AzyoJNXW+kEe+3Im15qH+BP+LWLSajKmHbYzbPun0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=L2P5c/xg4UMnD58peNVAh/0Vk/u4CSLn8lx91ZggvNW+cnuOmOZ5culcC/O/B4PDHet81smFoWMxIK7CeCDGVH217XTuZHBR5vWsUa2LFrUZbPq1xn3Fb49BIgwtI3OQ2LI4u/Z/xMW/SgK7xJ519nAZj9WR2iwKl0r8XphNl8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=JbP2WTgy; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Received: from [192.168.68.112] (ppp14-2-127-66.adl-apt-pir-bras32.tpg.internode.on.net [14.2.127.66]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 5185E20157; Thu, 18 Apr 2024 07:41:52 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1713397315; bh=d/AzyoJNXW+kEe+3Im15qH+BP+LWLSajKmHbYzbPun0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=JbP2WTgygM6dBAHFoxSdQ6T212Uf4v+Ybq4wDbS0DSrHZeSt7LdobuhADZU0LIOuu hKJCcA+xcCQFvu9kiLAMB+u2aSjNCVCLl+/tYrIjdQNg/JfZ4oY8Z74kP1TVvrvdaE sP5pD5es95wkSXN7dX1UMQXOz7Sl65UwHMJVNpKdXpIqU0l0qVa4Szo+/Q74adprb+ bZYKBXWOpB6sIVnjGSfwEAv3DOcV5CbxUAsMTiF8r7Gj/3CVHpPSRJC8ObCp6cvTVJ l5RfLEroZqsEiE+dNjV2cUhX3vtTXJkQAwgyx2xjrMFuH+aCF9BNhMdwZ/r1mC11ZN K3jtG3p2kqiOQ== Message-ID: <7b0ef5c90138e8c1d1829de249a480709170141b.camel@codeconstruct.com.au> Subject: Re: [PATCH] peci: aspeed: Clear clock_divider value before setting it From: Andrew Jeffery To: Iwona Winiarska , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Cc: Billy Tsai Date: Thu, 18 Apr 2024 09:11:47 +0930 In-Reply-To: <20240417134849.5793-1-iwona.winiarska@intel.com> References: <20240417134849.5793-1-iwona.winiarska@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Iwona, On Wed, 2024-04-17 at 15:48 +0200, Iwona Winiarska wrote: > PECI clock divider is programmed on 10:8 bits of PECI Control register. > Before setting a new value, clear bits read from hardware. >=20 > Signed-off-by: Iwona Winiarska I think it would be best to add a Fixes: tag and Cc: stable in accordance with the stable tree rules. Are you happy to do so? Andrew