Received-SPF: pass (google.com: domain of linux-kernel+bounces-149350-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 18 Apr 2024 09:20:08 +0900
From: Byungchul Park <byungchul@sk.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel_team@skhynix.com, akpm@linux-foundation.org,
	ying.huang@intel.com, vernhao@tencent.com,
	mgorman@techsingularity.net, hughd@google.com, david@redhat.com,
	peterz@infradead.org, luto@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	rjgolo@gmail.com
Subject: Re: [PATCH v9 7/8] mm: add folio_put_mgen() to deliver migrc's
 generation number to pcp or buddy
Message-ID: <20240418002008.GA3592@system.software.com>
References: <20240417071847.29584-1-byungchul@sk.com>
 <20240417071847.29584-8-byungchul@sk.com>
 <Zh_xC76oTjrgutl_@casper.infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zh_xC76oTjrgutl_@casper.infradead.org>
User-Agent: Mutt/1.9.4 (2018-02-28)

On Wed, Apr 17, 2024 at 04:55:55PM +0100, Matthew Wilcox wrote:
> On Wed, Apr 17, 2024 at 04:18:46PM +0900, Byungchul Park wrote:
> > Introduced a new API, folio_put_mgen(), to deliver migrc's generation
> > number to pcp or buddy that will be used by migrc mechanism to track
> > need of tlb flush for each page residing in pcp or buddy.
> > 
> > migrc makes decision whether tlb flush is needed or not, based on a
> > generation number stored in the interesting page and the global
> > generation number, for that tlb flush required has been completed.
> > 
> > For now, the delivery works only for the following call path but not for
> > e.g. free_the_page(), __free_pages_ok() and free_unref_page_list() that
> > are not for releasing source folios during migration:
> > 
> >    folio_put_mgen()
> >       __folio_put_mgen()
> > 	__folio_put_small()
> > 	   free_unref_page()
> > 	      free_unref_page_commit()
> > 	      free_one_page()
> > 	         __free_one_page()
> 
> You're going to want to rebase this on mm-unstable.  __folio_put_small()
> went away in "mm: combine __folio_put_small, __folio_put_large and
> __folio_put"

I checked it. Indeed. Thanks for the information.

	Byungchul