Received-SPF: pass (google.com: domain of linux-kernel+bounces-149358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 18 Apr 2024 02:31:58 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
 "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "Li, Xiaoyao" <xiaoyao.li@intel.com>, "seanjc@google.com" <seanjc@google.com>,
 "binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
 "Yamahata, Isaku" <isaku.yamahata@intel.com>
Subject: Re: [PATCH v3 0/7] KVM: Guest Memory Pre-Population API
User-Agent: K-9 Mail for Android
In-Reply-To: <65cdc0edae65ae78856fbeef90e77f21e729cf06.camel@intel.com>
References: <20240417153450.3608097-1-pbonzini@redhat.com> <65cdc0edae65ae78856fbeef90e77f21e729cf06.camel@intel.com>
Message-ID: <8245609C-0086-4DF6-8D17-509165F4D87A@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable


Il 18 aprile 2024 02:01:03 CEST, "Edgecombe, Rick P" <rick=2Ep=2Eedgecombe=
@intel=2Ecom> ha scritto:
>On Wed, 2024-04-17 at 11:34 -0400, Paolo Bonzini wrote:
>>=20
>> Compared to Isaku's v2, I have reduced the scope as much as possible:
>>=20
>> - no vendor-specific hooks
>
>The TDX patches build on this, with the vendor callback looking like:
>
>"
>int tdx_pre_mmu_map_page(struct kvm_vcpu *vcpu,
>			 struct kvm_map_memory *mapping,
>			 u64 *error_code)
>{
>	struct kvm_tdx *kvm_tdx =3D to_kvm_tdx(vcpu->kvm);
>	struct kvm *kvm =3D vcpu->kvm;
>
>	if (!to_tdx(vcpu)->initialized)
>		return -EINVAL;
>
>	/* Shared-EPT case */
>	if (!(kvm_is_private_gpa(kvm, mapping->base_address)))
>		return 0;
>
>	/* Once TD is finalized, the initial guest memory is fixed=2E */
>	if (is_td_finalized(kvm_tdx))
>		return -EINVAL;

This is wrong, KVM_MAP_MEMORY should be idempotent=2E But anyway, you can =
post what you have on to of kvm-coco-queue (i=2Ee=2E, adding the hook in yo=
ur patches) and we will sort it out a piece at a time=2E

Paolo

>
>	*error_code =3D TDX_SEPT_PFERR;
>	return 0;
>}
>"
>
>kvm_is_private_gpa() check is already handled in this series=2E
>
>The initialized and finalized checks are nice guard rails for userspace, =
but
>shouldn't be strictly required=2E
>
>The TDX_SEPT_PFERR is (PFERR_WRITE_MASK | PFERR_PRIVATE_ACCESS)=2E The
>PFERR_WRITE_MASK doesn't seem to be required=2E Isaku, what was the inten=
tion?
>
>But, I think maybe we should add a hook back in the TDX series for the gu=
ard
>rails=2E

Paolo