Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp989093lqb; Wed, 17 Apr 2024 17:56:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXwCBwD2ys7ZVZAEjHmZcffoEzuPlspcvt0DbM1Tw/AHKG2XLjGhKpdP5fkJnmiV+gAfYnyDSbkfOPnmk6BzGUxyZAjU+ZCvZhHtQZRqQ== X-Google-Smtp-Source: AGHT+IE/nxFyioLDEYOpQxxZdT3zX5qJPwI+BB9iH4yIOzOdAQYhZEOoB1ox0CdNi8O/R0bKSqTq X-Received: by 2002:ac8:5f8f:0:b0:435:8c4b:5a0b with SMTP id j15-20020ac85f8f000000b004358c4b5a0bmr1426306qta.61.1713401792967; Wed, 17 Apr 2024 17:56:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713401792; cv=pass; d=google.com; s=arc-20160816; b=zkcfET1xAghiR8e8rRnyckRD8hPWmvrBEVlgUnWuuaaCooxL9T6ZfBeQxcn8slsfek v9o3psfEzzTT+sT967/KGajAFCc0ogrOGpyKtTCd2ZR5+nJyVYOMqGH9xrLoqPRPjf1Y 5Ak4XeBnHfELshTsMZlXkNcOGdnCA4rzTBrLPEWe/WVp4DNkDzoYJdQK6WsYiCf41N21 EwrLMWyX6pmG+DOxOKTTr2QcsCHQ5w1GtsBpW/9KUNBJUvzUKSuAqEbFYSpUlDmKgu2u aEwLm8iaw+1JaByf89maU9DKPjyqV2KuUBlD96RB7MtT39nNfV1e0oprlTWoSt8JhTWc YSAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=O/DF11cq/+FcWiaf093q/N5WwoX5nzvySQkNCHg7vgE=; fh=qKlQaUx295fUgCe0yEi5rHvYjRhDCqUJOfbOzpXPn8c=; b=LnAg00lMtle+pz8kUBk2M6YSLw4pEikn7Lt5weC4xY2em8wc4f+rJ3uRPl8PdVNP6B 6Cg++HmPfIemdOR7yKeOyrbTNlbN21sqV1PEPP8PpevfWZwvbi3IUlAyyq06/q6o0Ag/ TKazONA2ndtQAbIkC2BwIqjXZHHUKXlEWcupGTlmrMO2rmi0Q/FygTli1F2bNoIxEJbU rr84cGn7W6BMAB6c3Pu0fywWcZgbcPUL17eNLrZVgFhaKm3zsI+Nb9EBMKCXj0SGJG01 CaqOgF8ZR7PxPhgd1xH3wZNMCEA318xF9BQXDKicLhex7DuijUBG3ucjW2VZBpGDVE/O UPow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NEmUFUP1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-149372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149372-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id hg23-20020a05622a611700b0043663accfb4si411406qtb.426.2024.04.17.17.56.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 17:56:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-149372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NEmUFUP1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-149372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-149372-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AEDCB1C21719 for ; Thu, 18 Apr 2024 00:56:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D45FB7464; Thu, 18 Apr 2024 00:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NEmUFUP1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3822CA5; Thu, 18 Apr 2024 00:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713401783; cv=none; b=TOQdnq04Zl0RJw2oo+tE0pJ6lDadl9pDc38wjEoz5DZy5136wAP1OVcYKd9lXDH8yJUmc4YMH21B5s8DwzoOyQsjMAvYOwYS/XUUNs3Ap3QW2KDNrPqH1cZYDWcAldng1PlRZEB++ZQWcu4KM6+/qH4IuQSZXvS4rOb0dIz4Rw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713401783; c=relaxed/simple; bh=vL4BH11YiczMtA85AfUXDUCqO8U2VxAovNR9Q83/HtE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VMQKQ+Z8jUJUufwgbuWxnKjy6gtM9j+bbDGtQu3kVAUCtKaPtVg4qLJTsbaCaLa8tZqQqRYlkTfpEEf2cQM2DW5JXGqFLUZlbt78pWBp9cUd8+u2TjMvLAVn5VYnXGf2EqDMZnOFc5pJHtNEus/NGTuV8ple03PHhaO8OmiWx8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NEmUFUP1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 565D6C072AA; Thu, 18 Apr 2024 00:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713401782; bh=vL4BH11YiczMtA85AfUXDUCqO8U2VxAovNR9Q83/HtE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NEmUFUP1seirP89YaqGwC+l/pKXO5ht+Zx9+19+PYD8SuN6mDLD2EF5Y1OPfvZcOj LtL/07TI69eLBh7U5gMgGJ36/0QYR81nZUWAwxT7KrO7/p1qT45rtctc8MWKgsIx2Z isC2YLHaFsIk2Gutqq1erKWMf/67F9SJsK6MISot2PEKBtNceO2OCdNardYyoy2kh8 VxGlj7h3pOBMcOC0+OdTAYpl/EpDQAfalOD/fT1Kh1XullYd/TbIB+QxWsPnni6Xci pGwAzj7xDqTU2I/3F3gqHrYhxAtNSnTYP48AQzlTqUJFzlcctcysk6D0QoO/3j1znu MZdKhyO2Rafyg== Date: Wed, 17 Apr 2024 17:56:21 -0700 From: Jakub Kicinski To: Justin Chen Cc: Florian Fainelli , Simon Horman , Markus Elfring , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, LKML , "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [PATCH net] net: bcmasp: fix memory leak when bringing down if Message-ID: <20240417175621.780cb1f8@kernel.org> In-Reply-To: <1f3131a4-fa84-4d25-8c1a-ab0023aace23@broadcom.com> References: <20240412181631.3488324-1-justin.chen@broadcom.com> <6881c322-8fbb-422f-bdbb-392a83d0b326@web.de> <9afad2b3-38a5-470d-a66f-10aa2cba3bab@broadcom.com> <8ae97386-876f-45cf-9e82-af082d8ea338@web.de> <20240417161933.GA2320920@kernel.org> <3a5cb80e-7169-4e82-b10c-843ff1eb0fd3@broadcom.com> <1f3131a4-fa84-4d25-8c1a-ab0023aace23@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 17 Apr 2024 11:48:33 -0700 Justin Chen wrote: > I try my best to address feedback. After a bit of thought, I feel the > feedback given was not out of good faith. I would like to keep the patch > as-is unless someone else has feedback. That is if the maintainers are > ok with that. TBH the "if" in the subject gives me pause too, please respin.