Received-SPF: pass (google.com: domain of linux-kernel+bounces-149382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <bd0b9517-63d1-4a49-90fd-c68e66dd464a@huawei.com>
Date: Thu, 18 Apr 2024 09:09:45 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] bcachefs: Align the display format of
 `btrees/inodes/keys`
To: Youling Tang <youling.tang@linux.dev>, Kent Overstreet
	<kent.overstreet@linux.dev>
CC: <linux-bcachefs@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Youling
 Tang <tangyouling@kylinos.cn>
References: <20240418005055.45482-1-youling.tang@linux.dev>
Content-Language: en-US
From: Hongbo Li <lihongbo22@huawei.com>
In-Reply-To: <20240418005055.45482-1-youling.tang@linux.dev>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/4/18 8:50, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
> 
> Before patch:
> ```
>   #cat btrees/inodes/keys
>   u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0:   mode=40755
>     flags= (16300000)
>     bi_size=0
> ```
> 
> After patch:
> ```
>   #cat btrees/inodes/keys
>   u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0:
>     mode=40755
>     flags=(16300000)
>     bi_size=0
> ```
> 
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
> ---
> v2:
> - Adjust where to add new lines of code.
> - Remove flags ` ` by Hongbo suggestion.
> 
>   fs/bcachefs/inode.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/inode.c b/fs/bcachefs/inode.c
> index f0da2b0048cc..5c9ee41baa72 100644
> --- a/fs/bcachefs/inode.c
> +++ b/fs/bcachefs/inode.c
> @@ -534,12 +534,13 @@ int bch2_inode_v3_invalid(struct bch_fs *c, struct bkey_s_c k,
>   static void __bch2_inode_unpacked_to_text(struct printbuf *out,
>   					  struct bch_inode_unpacked *inode)
>   {
> +	prt_printf(out, "\n");
>   	printbuf_indent_add(out, 2);
>   	prt_printf(out, "mode=%o\n", inode->bi_mode);
>   
>   	prt_str(out, "flags=");
>   	prt_bitflags(out, bch2_inode_flag_strs, inode->bi_flags & ((1U << 20) - 1));
> -	prt_printf(out, " (%x)\n", inode->bi_flags);
> +	prt_printf(out, "(%x)\n", inode->bi_flags);
>   
>   	prt_printf(out, "journal_seq=%llu\n",	inode->bi_journal_seq);
>   	prt_printf(out, "bi_size=%llu\n",	inode->bi_size);

Reviewed-by: Hongbo Li <lihongbo22@huawei.com>

Thanks.
Hongbo Li