Received-SPF: pass (google.com: domain of linux-kernel+bounces-149448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-3-ryncsn@gmail.com>
 <Zh_1TdrwJcBeALIG@casper.infradead.org>
In-Reply-To: <Zh_1TdrwJcBeALIG@casper.infradead.org>
From: Kairui Song <ryncsn@gmail.com>
Date: Thu, 18 Apr 2024 10:42:43 +0800
Message-ID: <CAMgjq7A=B-jczrPnJn-4j_WX=wnNB42WpmGazkCZ0-QPBm-4AA@mail.gmail.com>
Subject: Re: [PATCH 2/8] nilfs2: drop usage of page_index
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, 
	"Huang, Ying" <ying.huang@intel.com>, Chris Li <chrisl@kernel.org>, 
	Barry Song <v-songbaohua@oppo.com>, Ryan Roberts <ryan.roberts@arm.com>, Neil Brown <neilb@suse.de>, 
	Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>, 
	David Hildenbrand <david@redhat.com>, Yosry Ahmed <yosryahmed@google.com>, linux-fsdevel@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Ryusuke Konishi <konishi.ryusuke@gmail.com>, 
	linux-nilfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2024 at 12:14=E2=80=AFAM Matthew Wilcox <willy@infradead.or=
g> wrote:
>
> On Thu, Apr 18, 2024 at 12:08:36AM +0800, Kairui Song wrote:
> > +++ b/fs/nilfs2/bmap.c
> > @@ -453,8 +453,7 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_bm=
ap *bmap,
> >       struct buffer_head *pbh;
> >       __u64 key;
> >
> > -     key =3D page_index(bh->b_page) << (PAGE_SHIFT -
> > -                                      bmap->b_inode->i_blkbits);
> > +     key =3D bh->b_page->index << (PAGE_SHIFT - bmap->b_inode->i_blkbi=
ts);
>
> I'd prefer this were
>
>         key =3D bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_blkb=
its);
>
> (pages only have a ->index field for historical reasons; I'm trying to
> get rid of it)
>

Good suggestion! For easier review I just copied the original logic
from page_index, I will update with folio conventions in V2.