Received-SPF: pass (google.com: domain of linux-kernel+bounces-149458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240416144926.599101-1-david@redhat.com> <CANiq72kACt+FfeYXJxfQpmGH=uPqkDA0oprfnebw52VSKyn7kQ@mail.gmail.com>
 <CAAhV-H5mt0GaaZ3s44CYb4aKqYeDYm+Q16hY__FdQ6xYJh+bgg@mail.gmail.com> <20240417135834.ddaa9c038a8a8af2bd9e39aa@linux-foundation.org>
In-Reply-To: <20240417135834.ddaa9c038a8a8af2bd9e39aa@linux-foundation.org>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Thu, 18 Apr 2024 11:03:18 +0800
Message-ID: <CAAhV-H4O6_9Ukgz-GrPcWTq3cAN2c1OkXQWRbUgMR2ZwUuQQHA@mail.gmail.com>
Subject: Re: [PATCH v1] LoongArch/tlb: fix "error: parameter 'ptep' set but
 not used" due to __tlb_remove_tlb_entry()
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>, David Hildenbrand <david@redhat.com>, 
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, 
	loongarch@lists.linux.dev, llvm@lists.linux.dev, 
	Arnd Bergmann <arnd@arndb.de>, WANG Xuerui <kernel@xen0n.name>, Nathan Chancellor <nathan@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Andrew,

On Thu, Apr 18, 2024 at 4:58=E2=80=AFAM Andrew Morton <akpm@linux-foundatio=
n.org> wrote:
>
> On Wed, 17 Apr 2024 11:18:27 +0800 Huacai Chen <chenhuacai@kernel.org> wr=
ote:
>
> > On Wed, Apr 17, 2024 at 3:25=E2=80=AFAM Miguel Ojeda
> > <miguel.ojeda.sandonis@gmail.com> wrote:
> > >
> > > On Tue, Apr 16, 2024 at 4:49=E2=80=AFPM David Hildenbrand <david@redh=
at.com> wrote:
> > > >
> > > > With LLVM=3D1 and W=3D1 we get:
> > >
> > > Hmm... I didn't need W=3D1 to trigger it (LLVM 18.1.2).
> > >
> > > > Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> > >
> > > Thanks, looks good to me -- built-tested:
> > >
> > > Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
> > > Tested-by: Miguel Ojeda <ojeda@kernel.org>
> > >
> >
> > Queued for loongarch-fixes, thanks.
> >
>
> (top-posting repaired so I can sensibly reply to this.  Please avoid
> top-posting!)
Sorry, I only top-posting with "Queued ...", "Applied ..." because I
saw others do like this. If this is also unacceptable, I will not do
it again.

>
> I'd rather carry this in mm.git with your ack please.  Otherwise mm.git
> won't compile without it and if I retain this patch we'll get
> duplicate-patch emails from Stephen and I won't be able to merge
> mm.git's mm-nonmm-stable tree into Linus until loongarch-fixes has
> merged.
loongarch-next always merges loongarch-fixes, so when I apply a patch
it will be in linux-next. Now this patch I have already applied to
loongarch-fixes and loongarch-next. In future, I will give an Acked-by
for you if needed.

Huacai

>
>