Received-SPF: pass (google.com: domain of linux-kernel+bounces-149464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240417095951.2635-1-yangtiezhu@loongson.cn> <20240417095951.2635-2-yangtiezhu@loongson.cn>
In-Reply-To: <20240417095951.2635-2-yangtiezhu@loongson.cn>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Thu, 18 Apr 2024 11:15:05 +0800
Message-ID: <CAAhV-H4WxQa26cQ7jtt-dj6WrAvpo5LuzF0QXVS9pv3FywSbQA@mail.gmail.com>
Subject: Re: [PATCH v4 1/3] LoongArch: Modify acpi_parse_processor() for non-SMP
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Thomas Gleixner <tglx@linutronix.de>, Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>, 
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, 
	loongson-kernel@lists.loongnix.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Tiezhu,

On Wed, Apr 17, 2024 at 6:00=E2=80=AFPM Tiezhu Yang <yangtiezhu@loongson.cn=
> wrote:
>
> When CONFIG_SMP is disabled, mapping won't be created for all cpus.
> CPUs more than num_possible_cpus will be ignored. This is preparation
> for later patch.
This patch makes no sense, don't "fix" anything unless it is broken.

Huacai

>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  arch/loongarch/kernel/acpi.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/acpi.c b/arch/loongarch/kernel/acpi.c
> index 5cf59c617126..ccfa90faf0ea 100644
> --- a/arch/loongarch/kernel/acpi.c
> +++ b/arch/loongarch/kernel/acpi.c
> @@ -98,8 +98,15 @@ acpi_parse_processor(union acpi_subtable_headers *head=
er, const unsigned long en
>                 return -EINVAL;
>
>         acpi_table_print_madt_entry(&header->common);
> +
> +       /*
> +        * When CONFIG_SMP is disabled, mapping won't be created for all =
cpus.
> +        * CPUs more than num_possible_cpus will be ignored.
> +        */
> +       if (processor->core_id >=3D 0 && processor->core_id < num_possibl=
e_cpus())
> +               acpi_core_pic[processor->core_id] =3D *processor;
> +
>  #ifdef CONFIG_SMP
> -       acpi_core_pic[processor->core_id] =3D *processor;
>         set_processor_mask(processor->core_id, processor->flags);
>  #endif
>
> --
> 2.42.0
>
>