Received-SPF: pass (google.com: domain of linux-kernel+bounces-149467-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b8cef0a5-b9fd-48a2-b23d-2bbcd793e2f8@intel.com>
Date: Wed, 17 Apr 2024 20:17:43 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()
To: Ye Bin <yebin10@huawei.com>, <alex.williamson@redhat.com>,
	<kevin.tian@intel.com>, <tglx@linutronix.de>, <brauner@kernel.org>,
	<kvm@vger.kernel.org>
CC: <linux-kernel@vger.kernel.org>
References: <20240415015029.3699844-1-yebin10@huawei.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240415015029.3699844-1-yebin10@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWRCZW8rMDM2U2FVQXVSdjlUTmtSM0pVYkRMaVRWZnZ0U1BHVDlxVjhHdmo2?=
 =?utf-8?B?UG9lYTBNWEFkVnpkUFlwa0JqR1lvQUtXSXRmSVE5OElkejlWU0RyZ2tySDRq?=
 =?utf-8?B?TDFSdHd6Y1pNOGZmZnlDQlY4MjZzdmdkNmpLbmF6ellKRFZtdlozNk4rMEdZ?=
 =?utf-8?B?cUMwOTJndElhVXBCc2paYnIxMnh0MFFKVWxIZmE2RWhpNW5hd2JYZDRIeko3?=
 =?utf-8?B?bElDUVFxZEtzcUNkZWQvVmc3V1BxVytBSmtOaU14eDF2S2p2dnlxRmRoZ294?=
 =?utf-8?B?UzQzbFRKNXZYWFVkbzU1aU9SOXoxS3lGR3M4ZmRvemh1RDNnRk4reFFhNzVT?=
 =?utf-8?B?N1piUTdFYzZiNU9XakRvaGdiY1NWT2YwUjNtcFVrUWJmQXNNRWdGdmpnaWF4?=
 =?utf-8?B?QlB3OGhBQTRaOXp6bTZHOWVoUHNIZm5rU2d3TXBNV1l6YXhSTnc2M3IwYngw?=
 =?utf-8?B?UWp6QTluWWNXYXYrQm56VmFJbWoxN1hRU1NKeVBYd2tnUUUxYnRGMXdhZ1M1?=
 =?utf-8?B?Wi9zc0JySm9MNktMdDZycEhmN0ZsbXUwYlF0TUVxWE1BVlJGNXN0VzBmN1du?=
 =?utf-8?B?cXZMVmFnTFVnSk5lZG9DVUhUaDMvdWRoRGdQMWFUd05YTVF0dVJVSDVNNnVX?=
 =?utf-8?B?YThFRW40eDMvZi8rejNkczZ6UEpESTI1VENDTDR4T0p5alJ2RHVzanNQUlRU?=
 =?utf-8?B?ZFpVK3VmVUZpUk1KdXc2Y0ZpNlFSaTZUaVJDSzRkaHZzL3FyYml5ODVwbFN5?=
 =?utf-8?B?WjlOc1J4MHhXY1Jtdk9ZcVFlZDdMdUVhQmZMQ05iQlMyUDNWaTF4Y3Vkbm9i?=
 =?utf-8?B?NlFwTlhPNG4xRnVHUUlkSVpXL3RsSStsUVc2dUhWcEljeHlmVE5tQ0luZy9B?=
 =?utf-8?B?K1VGaXMrbnI3SDQyVDMxS2hCODNBanMzM1FCTUk5a1N0N3J3amxGL2NORktm?=
 =?utf-8?B?Qkd4TnhJTTZ2QUx6eEorUWJ1bzk4UGpCMUNIcUU0clpyVjlOdGdHRXRqUHJL?=
 =?utf-8?B?ai81QUw2YlJjUzgyQjVsUUVCbzRTTDJhQndxS2ovamlxZ29rc0I3UEgzaFlp?=
 =?utf-8?B?Qk13L005L29qVzFYMUlxOE15RnZzQkNBcjRZd2ZybWZ5TGl5T3BLZUtVaXZw?=
 =?utf-8?B?cU9qQzRXVFdTTmpFRk9TOWhzaGYwQkx1TjlTZVExUW1kcFovb1R4M2cvNlE4?=
 =?utf-8?B?c05HdjVGSVByeEk4Vk9UMys1dGZ2QzhhdktqZ0RyR3I0SmRTTkkxRUMwN2tl?=
 =?utf-8?B?VkNYYzFzTjF5dXhFaDFmVTJnNTdhR0hoUTgyVkVJWm5sZDFBQ1FtUjgvbGxK?=
 =?utf-8?B?MHVjVDhYQ1kvcWVrdm9IMmUrdjdpUTJ5THlFSzROS1N1TjNmYkVlcFNqRjVY?=
 =?utf-8?B?WFJ0MFRtVDdkMG1MM0JObHdVWG5MTlk2OGg0TFRBek9LcU94VWFzRFFpcmZL?=
 =?utf-8?B?ekExVU1ndklTRndsWnNvSXJYNWh3cDFVSFJmZktuOHQvZ2w5ckw2eUZHUmsw?=
 =?utf-8?B?bTByMHZVM25kTjA2OFJnMWtISkxvVzJWUDF4MGRxNkJ0ekNqcGM2WkxyVkxJ?=
 =?utf-8?B?azlUbXIvalZ0Y1NuUDlvYWppbEZyczhxc09IVVQvd1ZpSVhhcWpuV3E4WFhy?=
 =?utf-8?B?L2NvMWJzMTBlZy9UZ29YYUhoeG1PQjdncjArVWZ6eW11VTRaQUowRnpJUGFB?=
 =?utf-8?B?Mk1NY0EySE1XSXY5Y3ZIbEhBaEtpcnNWaC80eDFjY3NrQzZaOXpDdy9DN1hn?=
 =?utf-8?B?cndNRkJ2aXhUVm5zdHloYm5pMHE0WmdFSlZmaE56Rkg0VWlEcG03NStGdzYr?=
 =?utf-8?B?TFcwSEhyaDA1Z0tjRHU5YVhoV0hSd2I5ZGhvNVl6KzdiN0ZFOHk2SUdrZkJZ?=
 =?utf-8?B?d2l6OUIwK2Z6NFRVS09rellQNklibGxQdWhBMVdSeVM1bnpWM3RuOHdzTkVj?=
 =?utf-8?B?NVRjOTcwVFRJYjBYQVQ3YlliN1daeWxqa3FRdkNSTnlaZk1zamNDbkxjL0Y2?=
 =?utf-8?B?L3NmY3IyQWU1emVRWmlEMkVzK1I2bFFHdXk2a0tWU2dCT1JSZTkyK1dOT1VZ?=
 =?utf-8?B?MndrZnBVb0t2R0V1QmxDKzNsNkhDWW91c2tBcWgwMWJCcTRaOXphL00xTXRs?=
 =?utf-8?B?N01UV1k4RmJWMnhhMEFJcU9RU2pNSEw2eWlpMWViNDBZOWI3QnFsbDFJZk82?=
 =?utf-8?B?MFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: db2ab49f-3521-4192-395d-08dc5f561e1b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 03:17:45.7881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EhrEt7uhMv+kZNRNB3/t3bZnkP19bzq6E9FFr9M3ssFShz38K9wKcR7Dygb1yswjatJstviAB0wMYWnyWA2iXoZne1dVuvAUFKcdmmFBAt0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5300
X-OriginatorOrg: intel.com


On 4/14/2024 6:50 PM, Ye Bin wrote:
> If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
> 
> Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---

Thank you for catching this.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette