Received-SPF: pass (google.com: domain of linux-kernel+bounces-149498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240416215942.150202-1-maheshb@google.com> <20240417182445.019fb351@kernel.org>
In-Reply-To: <20240417182445.019fb351@kernel.org>
From: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= <maheshb@google.com>
Date: Wed, 17 Apr 2024 21:25:12 -0700
Message-ID: <CAF2d9jgWb8-HqEBkN4qUCsUA9zGJo4q36L=8WqLYG0eHSiVpaw@mail.gmail.com>
Subject: Re: [PATCHv1 next] ptp: update gettimex64 to provide ts optionally in
 mono-raw base.
To: Jakub Kicinski <kuba@kernel.org>
Cc: Netdev <netdev@vger.kernel.org>, Linux <linux-kernel@vger.kernel.org>, 
	David Miller <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Paolo Abeni <pabeni@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, 
	Richard Cochran <richardcochran@gmail.com>, Arnd Bergmann <arnd@arndb.de>, 
	Sagi Maimon <maimon.sagi@gmail.com>, Jonathan Corbet <corbet@lwn.net>, John Stultz <jstultz@google.com>, 
	Mahesh Bandewar <mahesh@bandewar.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 17, 2024 at 6:24=E2=80=AFPM Jakub Kicinski <kuba@kernel.org> wr=
ote:
>
> On Tue, 16 Apr 2024 14:59:42 -0700 Mahesh Bandewar wrote:
> >               if (extoff->n_samples > PTP_MAX_SAMPLES
> > -                 || extoff->rsv[0] || extoff->rsv[1] || extoff->rsv[2]=
) {
> > +                 || extoff->rsv[0] || extoff->rsv[1]
> > +                 || (extoff->clockid !=3D CLOCK_REALTIME
> > +                     && extoff->clockid !=3D CLOCK_MONOTONIC_RAW)) {
>
> Since you're touching this condition it's probably a good opportunity
> to fox the coding style.
will do! I was just matching the existing style.